Created attachment 257842 [details]
x11/wezterm: Update to 20250213-133349

Rebase patch after cf7c4b037d7e9cadfa539f3b9cd45396c1a00dfb (lang/rust: Bump revisions after 1.85.0)

I've been using your patch for a while.
Everything seems to work fine.

(In reply to Sascha Folie from comment #2)
Thank you for your feedback. I'm glad it works fine for you.
I use wezterm daily, and I observe no regressions either.

Can anyone please advise if there is anything what needs to be added, changed or approved by somebody to get this patch merged into the ports tree?

Thank you

Consider setting maintainer-feedback to + on the PR. This may be more likely to get attention from committers.

Essentially any time I submit a patch, I need to set maintainer-approval on the patch and maintainer-feedback on the PR. Set to + if I'm the maintainer, set to ? if I'm not and to request feedback/approval from the maintainer.

(In reply to Pat Maddox from comment #5)

It looks like I have shared incorrect information... my apologies.

from https://wiki.freebsd.org/Bugzilla/DosAndDonts

> DON'T use maintainer-feedback flag to declare approval of a patch. (DO use the maintainer-approval flag)

Created attachment 259313 [details]
x11/wezterm: Update to 20250213-133349

Fix build with DOCS=ON after textproc/mdbook update to 0.4.48

Original report: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=285875

Created attachment 259395 [details]
x11/wezterm: Update to 20250213-133349

Rebase patch after 2a5976aebeefd09d36fd4ac2e7e2eefde5491c0d (lang/rust: Bump revisions after 1.86.0)

Created attachment 259412 [details]
x11/wezterm: Update to 20250213-133349

Rebase after 6c294f6ff1a8f7924bc9d5b9de36ccd70410aa78 (x11/wezterm: Unbreak DOCS build with mdbook 0.4.48)

Comment 10 commit-hook 2025-04-16 08:33:50 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0ab77175892b58b450a90a3c54c9a7bbceb61022

commit 0ab77175892b58b450a90a3c54c9a7bbceb61022
Author:     Vladyslav Movchan <vladislav.movchan@gmail.com>
AuthorDate: 2025-04-09 12:50:38 +0000
Commit:     Mikael Urankar <mikael@FreeBSD.org>
CommitDate: 2025-04-16 08:32:19 +0000

    x11/wezterm: Update to 20250213-133349 (nightly)

    Also:
     - update the project URL
     - drop local patches which are no longer necessary
     - install bash/fish/zsh shell completions
     - use `distro-defaults` feature, which sets `check_for_updates` to
       false by default

    Release changes: https://wezterm.org/changelog.html#continuousnightly

    PR:             284964

 x11/wezterm/Makefile                               |   80 +-
 x11/wezterm/Makefile.crates                        |  922 +++++-----
 x11/wezterm/distinfo                               | 1872 ++++++++++----------
 x11/wezterm/files/patch-Cargo.lock (gone)          |   14 -
 ....31_src_format__description_parse_mod.rs (gone) |   19 -
 x11/wezterm/files/patch-ci_generate-docs.py (new)  |   20 +
 x11/wezterm/files/patch-docs (gone)                |   44 -
 x11/wezterm/files/patch-docs_contributing.md (new) |   11 +
 x11/wezterm/files/patch-docs_index.md (new)        |   11 +
 x11/wezterm/files/patch-window_Cargo.toml (gone)   |   11 -
 10 files changed, 1562 insertions(+), 1442 deletions(-)

Comment 11 Mikael Urankar 2025-04-16 08:35:34 UTC

Thanks.

Can you check this warning reported by poudriere testport:
Warning: you may not need USES=desktop-file-utils

https://docs.freebsd.org/en/books/porters-handbook/book/#desktop-entries

grep -i mimetype work/wezterm-ee0c04e735fb94cb5119681f704fb7fa6731e713/assets/wezterm.desktop

(In reply to Mikael Urankar from comment #11)
Thanks a lot!

I'll take a look and try to address this warning.

(In reply to Mikael Urankar from comment #11)
Thank you for noticing this and for the link to documentation - USES=desktop-file-utils is not necessary indeed.

I'm attaching the patch. I checked the corrected version with poudriere testport - it no longer shows the original warning.

Created attachment 259625 [details]
Avoid updating desktop database

Comment 15 commit-hook 2025-04-17 08:16:39 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=17fb92ba39b01227821194ed4b94bb17550c295c

commit 17fb92ba39b01227821194ed4b94bb17550c295c
Author:     Vladyslav Movchan <vladislav.movchan@gmail.com>
AuthorDate: 2025-04-16 15:37:06 +0000
Commit:     Mikael Urankar <mikael@FreeBSD.org>
CommitDate: 2025-04-17 08:15:28 +0000

    x11/wezterm: Avoid updating desktop database as .desktop file has no MimeType entry

    This fixes the following poudriere warning:
    Warning: you may not need USES=desktop-file-utils

    PR:             284964

 x11/wezterm/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)