Bug 285143 - net/netatalk4 fails on configure, can't find xsltproc
Summary: net/netatalk4 fails on configure, can't find xsltproc
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Joe Marcus Clarke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-03-03 23:13 UTC by Raivo Hool
Modified: 2025-03-06 19:41 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (marcus)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Raivo Hool 2025-03-03 23:13:58 UTC 
net/netatalk4 fails on configure citing failure to find xsltproc:

Program xsltproc found: NO

meson.build:1672:24: ERROR: command 'xsltproc' not found or not executable

I believe it's due to the fact that the port pulls xsltproc in via:

USE_GNOME=      libxslt:build

I don't have Gnome anywhere, and this build dependency does not get triggered. I propose replacing it with:

BUILD_DEPENDS=  docbook-xsl>=0:textproc/docbook-xsl \
                xsltproc:textproc/libxslt

This way, the port builds fine.
Comment 1 Joe Marcus Clarke freebsd_committer freebsd_triage 2025-03-06 18:50:16 UTC 
This should be fixed now.
Comment 2 commit-hook freebsd_committer freebsd_triage 2025-03-06 18:50:21 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e944cba64c634a551be79b5e0db4dc2ada2f178b

commit e944cba64c634a551be79b5e0db4dc2ada2f178b
Author:     Joe Marcus Clarke <marcus@FreeBSD.org>
AuthorDate: 2025-03-06 18:48:04 +0000
Commit:     Joe Marcus Clarke <marcus@FreeBSD.org>
CommitDate: 2025-03-06 18:48:04 +0000

    net/netatalk4: Unmask the libxslt dependency

    Since DBUS is a default option, it was masking the libxslt requirement
    for building manpages.

    PR:             285143

 net/netatalk4/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 3 Raivo Hool 2025-03-06 19:25:48 UTC 
DBus was enabled, but I don't build manpages, so DBus doesn't pull in textproc/minixmlto, which in turn pulls in textproc/libxslt. It matters when building with Poudriere.
Comment 4 Joe Marcus Clarke freebsd_committer freebsd_triage 2025-03-06 19:40:46 UTC 
I get it.  The fix makes sure libxslt is included.  I tested this and I now see it show up in the build-depends-list.
Comment 5 Raivo Hool 2025-03-06 19:41:51 UTC 
Coolness. Thank you.