Created attachment 258387 [details] patch file for the new port sff is a simple, fast, and feature-rich terminal file manager inspired by nnn and guided by the suckless philosophy.
Created attachment 259289 [details] patch file for the new port: sff (1.0) sff has been updated to version 1.0. The previous patch file for the older version is now obsolete and has been replaced by the new one.
Created attachment 261004 [details] patch file for the new port: sff (1.1) sff has been updated to version 1.1. The previous patch file for the older version is now obsolete and has been replaced by the new one.
Created attachment 261031 [details] patch file for the new port: sff (1.1 rev)
Hello, cflags aren't respected: cc -c -std=c11 -pedantic -Wall -Wextra -Wshadow -Wno-deprecated-declarations -Os ... Could you take a look at: https://docs.freebsd.org/en/books/porters-handbook/book/#dads-cflags ? Cheers
Created attachment 261096 [details] Fix CFLAGS, port category - Respect CFLAGS - Move to appropriate category that could be misc or deskutils. Since sff is inspired in nnn, let's put it in same category: misc.
(In reply to Nuno Teixeira from comment #5) (...) And it should be present `USE_CSTD= c11`to preserve upstream compiler standard. NOTE: port is using base ncurses. I'm investigating the USES=ncurses:port and see what best solution is for this port. https://docs.freebsd.org/en/books/porters-handbook/book/#uses-ncurses
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=19dac35585b5f4c1680a7b81a2e795e5abbfec7d commit 19dac35585b5f4c1680a7b81a2e795e5abbfec7d Author: Shi Yanling <sylphenix@outlook.com> AuthorDate: 2025-06-10 00:00:08 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2025-06-10 00:02:51 +0000 misc/sff: New port: Simple and fast terminal file manager - Submitter becomes maintainer sff is a simple, fast, and feature-rich terminal file manager inspired by nnn and guided by the suckless philosophy. It aims to provide a reliable, efficient, and user-friendly file management experience with high extensibility. WWW: https://codeberg.org/sylphenix/sff PR: 285216 misc/Makefile | 1 + misc/sff/Makefile (new) | 22 ++++++++++++++++++++++ misc/sff/distinfo (new) | 3 +++ misc/sff/pkg-descr (new) | 20 ++++++++++++++++++++ misc/sff/pkg-plist (new) | 6 ++++++ 5 files changed, 52 insertions(+)
I've committed port with ncurses:port that provides a newest version of ncurses. Also, ncurses detection is made by pkgconfig. I will leave this PR open just in case we need to do some adjustments. Committed, thanks!
Hi Nuno, Apologies for the delayed response - I was on vacation and just saw these updates. Thank you for your help with the port and for making those improvements. Regarding the ncurses dependency: since sff was originally developed and tested on FreeBSD using the base system's ncurses, I'd recommend keeping the system-provided version for maximum compatibility. This ensures consistent behavior with the development environment where all testing was performed. I really appreciate you shepherding this port to completion.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=2597d086d9e857ae9ecfe9db586b7af7f46462bf commit 2597d086d9e857ae9ecfe9db586b7af7f46462bf Author: Nuno Teixeira <eduardo@FreeBSD.org> AuthorDate: 2025-06-11 06:41:40 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2025-06-11 06:41:40 +0000 misc/sff: Switch back to ncurses:base While here, add PREFIX to MAKE_ARGS instead of upstream hardcoded one. PR: 285216 misc/sff/Makefile | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
Hello Shi, I've restored ncurses:base to port. I did remove pkgonfig because it fails to detect base ncurses on 13.5-RELEASE and I'm still investigating the reason. Please let me know if it is ok now. Cheers
Hi Nuno, I've tested the changes and everything works perfectly now. Thank you for making these adjustments!
Closing PR. Thanks!