Bug 285530 - net-mgmt/netdata: Update to v2.4.0
Summary: net-mgmt/netdata: Update to v2.4.0
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL: https://github.com/netdata/netdata/re...
Keywords:
: 285548 (view as bug list)
Depends on:
Blocks:
 
Reported: 2025-03-19 16:40 UTC by Namkhai B.
Modified: 2025-04-20 11:41 UTC (History)
5 users (show)

See Also:


Attachments
incomplete patch (4.59 KB, patch)
2025-04-16 23:16 UTC, Craig Leres
no flags Details | Diff
net-mgmt/netdata: Update to v2.4.0 (86.64 KB, patch)
2025-04-18 04:18 UTC, Namkhai B.
no flags Details | Diff
net-mgmt/netdata: Update to v2.4.0 (86.25 KB, patch)
2025-04-19 03:15 UTC, Namkhai B.
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Namkhai B. 2025-03-19 16:40:16 UTC
Will start working on this ASAP.
Changelog: https://github.com/netdata/netdata/releases/tag/v2.3.0
Comment 1 Trond Endrestøl 2025-03-20 14:30:00 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=285548 is a duplicate of this one.
Comment 2 Jordan Ostreff 2025-03-20 19:38:28 UTC
(In reply to Trond Endrestøl from comment #1)

Which to be closed?
Comment 3 Jordan Ostreff 2025-03-20 19:38:50 UTC
(In reply to Trond Endrestøl from comment #1)

Which to be closed?
Comment 4 Trond Endrestøl 2025-03-21 07:47:16 UTC
(In reply to Jordan Ostreff from comment #3)
I should like to close this one, 285530, as the other one is more actionable.
Comment 5 Namkhai B. 2025-03-21 15:33:43 UTC
I'm working on the update and thanks to Trond for providing a patch for the ipfw plugin.
Will try to get the update ready in the next few days.
Either bug can be closed, but this one was submitted earlier I think.
I'll import the ipfw patch in my update to v2.3 anyways.
Comment 6 Jordan Ostreff 2025-03-21 16:36:08 UTC
(In reply to Namkhai B. from comment #5)
Actually https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=285548 was reported:	2025-03-20 13:26 UTC. But really for me this is not criteria. If port maintainer prefer i'm ok with every decision.
Comment 7 Trond Endrestøl 2025-03-21 17:47:17 UTC
(In reply to Namkhai B. from comment #5)
I just want to point out that my patch needs more attention. It may contain logical flaws as I only have a rudimentary understanding of the internals of ipfw. And as stated in the other PR, ipfw isn't displayed in the netdata UI at all for src/main. src/stable/{13,14} and releng/{13.5,14.2} are all okay. I'm able to test the new netdata on the branches I have mentioned.
Comment 8 Jordan Ostreff 2025-03-25 11:48:15 UTC
*** Bug 285548 has been marked as a duplicate of this bug. ***
Comment 9 Jordan Ostreff 2025-03-28 17:07:15 UTC
anything as working patch ?
Comment 10 Namkhai B. 2025-03-31 06:31:05 UTC
(In reply to Jordan Ostreff from comment #9)

I have something close but I'm traveling until April 7th and away from my workstation.
Comment 11 Jordan Ostreff 2025-03-31 15:59:44 UTC
2.3.1 is published already
https://github.com/netdata/netdata/releases/tag/v2.3.1
Comment 12 Jordan Ostreff 2025-04-03 10:52:28 UTC
https://github.com/netdata/netdata/releases/tag/v2.3.2

new version published.
Comment 13 Jordan Ostreff 2025-04-15 20:57:50 UTC
2.4.0 released https://github.com/netdata/netdata/tree/v2.4.0

any plans when new patches will be provided for testing?
Comment 14 Jordan Ostreff 2025-04-16 11:32:26 UTC
Is anybody working on this changes?
Comment 15 Namkhai B. 2025-04-16 19:40:32 UTC
I have some time now, will work on new patches this afternoon.
Comment 16 Craig Leres freebsd_committer freebsd_triage 2025-04-16 23:16:41 UTC
Created attachment 259627 [details]
incomplete patch

Here's a patch that solves some issues. It doesn't work when ML is on and even then it doesn't stage. (I forgot to check for an existing PR before I took a look at this for a friend who needs 2.4.0.
Comment 17 Namkhai B. 2025-04-18 04:18:38 UTC
Created attachment 259656 [details]
net-mgmt/netdata: Update to v2.4.0

Initial v2.4.0 patch.

Dropped legacy dashboard as it was removed by netdata.
Lightly tested on 14.2-RELEASE-p1
Comment 18 Craig Leres freebsd_committer freebsd_triage 2025-04-18 19:47:00 UTC
(In reply to Namkhai B. from comment #17)
Your patch doesn't apply for me; I think your diff is against an older version of the port Makefile.

--------------------------
Patching file net-mgmt/netdata/Makefile using Plan A...
Hunk #1 failed at 1.
Hunk #2 succeeded at 75 (offset 1 line).
Hunk #3 succeeded at 156 (offset 1 line).
1 out of 3 hunks failed--saving rejects to net-mgmt/netdata/Makefile.rej
Hmm...  The next patch looks like a unified diff to me...
The text leading up to this was:
--------------------------

If I manually make failed change it fails to stage. I'm building with the default options.

=======================<phase: package        >============================
===== env: 'PKG_NOTES=build_timestamp ports_top_git_hash ports_top_checkout_unclean port_git_hash port_checkout_unclean built_by' 'PKG_NOTE_build_timestamp=2025-04-18T19:42:06+0000' 'PKG_NOTE_ports_top_git_hash=14a57cfea9d' 'PKG_NOTE_ports_top_checkout_unclean=yes' 'PKG_NOTE_port_git_hash=186a8781b0d' 'PKG_NOTE_port_checkout_unclean=yes' 'PKG_NOTE_built_by=poudriere-git-3.4.2' NO_DEPENDS=yes USER=root UID=0 GID=0
===>  Building packages for netdata-2.4.0
===>   Building netdata-2.4.0
pkg-static: Unable to access file /wrkdirs/usr/ports/net-mgmt/netdata/work/stage/usr/local/libexec/netdata/plugins.d/ndsudo:No such file or directory
*** Error code 1

Stop.
make: stopped in /usr/ports/net-mgmt/netdata
=>> Cleaning up wrkdir
===>  Cleaning for netdata-2.4.0
build of net-mgmt/netdata | netdata-2.4.0 ended at Fri Apr 18 12:45:31 PDT 2025
build time: 00:03:25
Comment 19 Jordan Ostreff 2025-04-18 20:09:21 UTC
Today they have bumped port revision, this is the only problem. You must manually edit Makefile, before apply proposed patch.
Comment 20 Namkhai B. 2025-04-19 03:15:24 UTC
Created attachment 259684 [details]
net-mgmt/netdata: Update to v2.4.0

Fixed stage with DASHBOARD=off.
Rebased ports tree
Comment 21 Jordan Ostreff 2025-04-20 11:41:42 UTC
(In reply to Namkhai B. from comment #20)
It works perfectly for me, on bare metal 14.3-PRERELEASE stable/14-n271131-ee7a874557f4.