Bug 285902 - devel/libosinfo: Fails to build with libxml2 2.24.1
Summary: devel/libosinfo: Fails to build with libxml2 2.24.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Roman Bogorodskiy
URL:
Keywords:
Depends on:
Blocks: 279705
  Show dependency tree / graph
 
Reported: 2025-04-05 14:51 UTC by Daniel Engberg
Modified: 2025-04-18 08:39 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (novel)

Attachments
Poudriere log (9.77 KB, application/octet-stream)
2025-04-05 14:51 UTC, Daniel Engberg 		no flags Details
Port patch (1.41 KB, patch)
2025-04-15 15:04 UTC, Roman Bogorodskiy 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2025-04-05 14:51:06 UTC 
Created attachment 259341 [details]
Poudriere log

../osinfo/osinfo_loader.c:1948:23: error: incompatible function pointer types assigning to 'errorSAXFunc' (aka 'void (*)(void *, const char *, ...)') from 'void (void *, const char *)' [-Wincompatible-function-pointer-types]

Possibly related,
https://gitlab.com/libosinfo/libosinfo/-/commit/5bbdd06503456784c5ffa22409e8bab50470d673
Comment 1 Roman Bogorodskiy freebsd_committer freebsd_triage 2025-04-10 15:02:21 UTC 
I've created a merge request upstream: https://gitlab.com/libosinfo/libosinfo/-/merge_requests/162; plan to wait for some feedback a bit, then convert it to a port patch.
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2025-04-10 20:31:55 UTC 
Sounds great, thanks!
Comment 3 Roman Bogorodskiy freebsd_committer freebsd_triage 2025-04-15 15:04:47 UTC 
Created attachment 259584 [details]
Port patch

The fix was merged upstream and I've updated the port to include it. Let me know if you want me to push it now or it's easier for you to push it together with other libxml2 changes.
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2025-04-17 17:44:00 UTC 
If it's backwards compatible it'd be great if you could push it now so we can have a "cleaner" exp-run.
Comment 5 commit-hook freebsd_committer freebsd_triage 2025-04-18 08:38:19 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1c219f16353f02f51afdfe4b7756a3b7c9ef4b0e

commit 1c219f16353f02f51afdfe4b7756a3b7c9ef4b0e
Author:     Roman Bogorodskiy <novel@FreeBSD.org>
AuthorDate: 2025-04-15 14:54:04 +0000
Commit:     Roman Bogorodskiy <novel@FreeBSD.org>
CommitDate: 2025-04-18 08:37:40 +0000

    devel/libosinfo: fix build with libxml2 2.24.1

    Backport the upstream fix for building with the newer libxml2.

    PR:             285902
    Reported by:    diizzy

 devel/libosinfo/Makefile | 3 +++
 devel/libosinfo/distinfo | 4 +++-
 2 files changed, 6 insertions(+), 1 deletion(-)