Created attachment 259384 [details] v0 waf included in the release does not work with Python 3.12+ so port does not build; pull in upstream commit updating waf to a version that does.
Hi Charlie, from a first glance this looks good to me, thanks for involving me and providing a patch. I'd like to do a test run tomorrow when my build machine has finished its current poudriere build, but I don't expect any problems. I think the SOSSO option already includes the newer waf, have to check that. Best regards, Florian
Comment on attachment 259384 [details] v0 Did a test build, no regressions, ready to go!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=69b09af5f8da06be36867a558b902ac3e445d747 commit 69b09af5f8da06be36867a558b902ac3e445d747 Author: Charlie Li <vishwin@FreeBSD.org> AuthorDate: 2025-04-08 01:44:51 +0000 Commit: Charlie Li <vishwin@FreeBSD.org> CommitDate: 2025-04-15 05:24:30 +0000 audio/jack: pull in upstream commit updating waf Needed to allow building on Python 3.12 and later PR: 285953 Approved by: Florian Walpen (maintainer) audio/jack/Makefile | 3 +++ audio/jack/distinfo | 4 +++- 2 files changed, 6 insertions(+), 1 deletion(-)
Committed, thanks!
After upgrading to which the patch committed, newly added patch doesn't apply if option SOSSO is enabled. Disabling it fixed patch and builds/packages fine. Looking into Makefile, option SOSSO uses specific GH_TAGNAME. So the new patch should be conditionalized or temporarily excluding SOSSO option would be needed.
(In reply to Tomoaki AOKI from comment #5) Yeah, sorry about that, I didn't realize that said patch would be applied to both pre-sosso and sosso sources. Maybe it's easier to just take the head of the main (develop) branch here. IIRC there's some fixes in there but no big changes, and a release is overdue by more than a year now. Development has stalled anyway. I'll look into it when time admits, probably friday.