Bug 285973 - update devel/godot to v4.4.1
Summary: update devel/godot to v4.4.1
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Zsolt Udvari
URL: https://godotengine.github.io/godot-i...
Keywords:
Depends on:
Blocks:
 
Reported: 2025-04-09 06:20 UTC by Shane
Modified: 2025-04-28 01:50 UTC (History)
1 user (show)

See Also:


Attachments
maintainer update for devel/godot (3.70 KB, patch)
2025-04-09 06:20 UTC, Shane
FreeBSD: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shane 2025-04-09 06:20:22 UTC
Created attachment 259401 [details]
maintainer update for devel/godot

maintenance release v4.4.1 for godot
Comment 1 Zsolt Udvari freebsd_committer freebsd_triage 2025-04-26 19:05:48 UTC
Hello Shane,
thanks for your work.
I've a question about The TEST option. As I see it creates a do-test target. The TEST shouldn't be an option it should be a possibility to run 'make test' (see [1]).

Another: could you please run portlint/portfmt/portclippy?

[1] https://docs.freebsd.org/en/books/porters-handbook/book/#make-test
Comment 2 Shane 2025-04-28 01:50:23 UTC
The test option enables build settings that enable the tests to be run, If you don't want to run the test you don't build with test enabled. The tests aren't separate compiled binaries, they are compiled into the one binary.

The port is built using scons adding to MAKE_ARGS to enable tests, to get TEST_TARGET to work, you would need something like TEST_TARGET= MAKE_ARGS=tests=True or TEST_TARGET_MAKE_ARGS=

I haven't thought of a way to make that work.

I have run portlint -AC and portclippy on this port.