286020 – devel/msp430-debug-stack: Don't delete devd configuration file upon uninstall

Bug 286020 - devel/msp430-debug-stack: Don't delete devd configuration file upon uninstall

Summary: devel/msp430-debug-stack: Don't delete devd configuration file upon uninstall

Status:	Closed FIXED

Alias:	None

Product:	Ports & Packages
Classification:	Unclassified
Component:	Individual Port(s) (show other bugs)
Version:	Latest
Hardware:	Any Any

Importance:	--- Affects Some People
Assignee:	Lev A. Serebryakov

URL:	https://forums.freebsd.org/threads/pr...
Keywords:

Depends on:
Blocks:

Reported:	2025-04-10 20:19 UTC by Yusuf Yaman
Modified:	2025-04-11 11:58 UTC (History)
CC List:	3 users (show)

See Also:

Flags:	bugzilla: maintainer-feedback? (lev)

Attachments
devel/msp430-debug-stack.patch (2.34 KB, patch) 2025-04-10 20:20 UTC, Yusuf Yaman	nxjoseph: maintainer-approval? (lev)	Details \| Diff
replacement mspfet.conf (1.70 KB, text/plain) 2025-04-11 04:42 UTC, Petre Rodan	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Yusuf Yaman 2025-04-10 20:19:03 UTC

Comment 1 Yusuf Yaman 2025-04-10 20:20:21 UTC

Created attachment 259447 [details]
devel/msp430-debug-stack.patch

This change makes the port:
- Install devd configuration file as a sample file so that upon
  uninstalling the port doesn't accidentally delete the configuration file.

See also:	https://forums.freebsd.org/threads/protection-of-usr-local-etc-files-or-lack-thereof.97479

Poudriere testport passes on 142amd64-default.

Thanks in advance.

Comment 2 Petre Rodan 2025-04-11 04:42:52 UTC

Created attachment 259456 [details]
replacement mspfet.conf

thanks again for the PR.

also here is my devd configuration file which I would appreciate if you'd consider adding to the port. the changes include:

 - add access to the back-channel UART for all launchpad ezFETs and the official msp430 FET programmer
 - add support for the Olimex ISO programmer
 - make sure the user can discover the usb device itself
 - fix space + tab whitespace
 - reword header text

tested on 9 launchpads, 2 standalone programmers, 4 olimex boards and 4 custom boards.

Comment 3 Lev A. Serebryakov freebsd_committer

2025-04-11 11:42:46 UTC

Thank you everybody for submission.
I don't have access to MSP430 boards now, so report from people who uses them right now is very valuable.

I'll apply changes ASAP!

Comment 4 commit-hook freebsd_committer

2025-04-11 11:57:48 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6d6ce04aaa7a5b1c8067321e82e6b95d20dcd144

commit 6d6ce04aaa7a5b1c8067321e82e6b95d20dcd144
Author:     Lev A. Serebryakov <lev@FreeBSD.org>
AuthorDate: 2025-04-11 11:54:50 +0000
Commit:     Lev A. Serebryakov <lev@FreeBSD.org>
CommitDate: 2025-04-11 11:54:50 +0000

    devel/msp430-debug-stack: Better devd config installed as sample.

     1. Install devd config as sample, to preserve actual config on package removal.
     2. Make this config better to support more devices and back-channel UART.

    PR:             286020
    Reported by:    Yusuf Yaman <nxjoseph@protonmail.com> [1]
    Reported by:    Petre Rodan <petre.rodan@subdimension.ro> [2]

 devel/msp430-debug-stack/Makefile                  |  4 +-
 devel/msp430-debug-stack/files/mspfet.conf (gone)  | 22 ---------
 .../files/mspfet.conf.sample (new)                 | 53 ++++++++++++++++++++++
 devel/msp430-debug-stack/pkg-plist                 |  2 +-
 4 files changed, 56 insertions(+), 25 deletions(-)

Comment 5 Lev A. Serebryakov freebsd_committer

2025-04-11 11:58:07 UTC

Committed, thanx!