Created attachment 259455 [details] git -C /usr/ports diff recent commit to audio/re broke build of audio/baresip see: PR 285946 / commit 51a9fe1d this minimal patch allows it to build+package again BUT i have NOT yet done any testing and really dont have the bandwidth presently to try it out error was as follows: FAILED: CMakeFiles/baresip.dir/src/aureceiver.c.o /usr/bin/cc -DARCH=\"amd64\" -DFREEBSD -DHAVE_ARC4RANDOM -DHAVE_ATOMIC -DHAVE_EXECINFO -DHAVE_FORK -DHAVE_GETIFADDRS -DHAVE_GETOPT -DHAVE_KQUEUE -DHAVE_PTHREAD -DHAVE_PWD_H -DHAVE_RESOLV -DHAVE_ROUTE_LIST -DHAVE_SELECT -DHAVE_SELECT_H -DHAVE_SETRLIMIT -DHAVE_SIGNAL -DHAVE_STRERROR_R -DHAVE_STRINGS_H -DHAVE_SYSLOG -DHAVE_SYS_TIME_H -DHAVE_UNAME -DHAVE_UNISTD_H -DHAVE_UNIXSOCK=1 -DMOD_PATH=\"/usr/local/lib/baresip/modules\" -DOS=\"FreeBSD\" -DRELEASE -DSHARE_PATH=\"/usr/local/share/baresip\" -DUSE_DTLS -DUSE_OPENSSL -DUSE_OPENSSL_AES -DUSE_OPENSSL_HMAC -DUSE_TLS -DUSE_ZLIB -DVERSION=\"3.20.0\" -DVER_MAJOR=3 -DVER_MINOR=20 -DVER_PATCH=0 -D_GNU_SOURCE -Dbaresip_EXPORTS -I/usr/ports/audio/baresip/work/baresip-3.20.0/include -I/usr/ports/audio/baresip/work/baresip-3.20.0/src -I/usr/local/include/re -isystem /usr/local/include -O2 -pipe -march=opteron-sse3 -fstack-protector-strong -fno-strict-aliasing -O2 -pipe -march=opteron-sse3 -fstack-protector-strong -fno-strict-aliasing -DNDEBUG -std=gnu11 -fPIC -Wall -Wextra -pedantic -Wcast-align -Wbad-function-cast -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wno-strict-aliasing -Wold-style-definition -Wshadow -Waggregate-return -Wstrict-prototypes -Wuninitialized -Wvla -Watomic-implicit-seq-cst -Wshorten-64-to-32 -Wno-gnu-zero-variadic-macro-arguments -Wno-c2x-extensions -pthread -MD -MT CMakeFiles/baresip.dir/src/aureceiver.c.o -MF CMakeFiles/baresip.dir/src/aureceiver.c.o.d -o CMakeFiles/baresip.dir/src/aureceiver.c.o -c /usr/ports/audio/baresip/work/baresip-3.20.0/src/aureceiver.c /usr/ports/audio/baresip/work/baresip-3.20.0/src/aureceiver.c:281:29: error: static declaration of 'rtpext_find' follows non-static declaration 281 | static const struct rtpext *rtpext_find(const struct rtpext *extv, size_t extc, | ^ /usr/local/include/re/re_rtpext.h:44:22: note: previous declaration is here 44 | const struct rtpext *rtpext_find(const struct rtpext *extv, size_t extc, | ^ 1 error generated.
PORTREVISION line must be removed/reset.
Created attachment 259470 [details] git -C /usr/ports diff (In reply to Herbert J. Skuhra from comment #1) good point
If no one else is interested in maintaining audio/re and audio/baresip I can try to do so.
(In reply to Herbert J. Skuhra from comment #3) by all means. that would be swell thank you.
First: sorry, I didn't find baresip port requires audio/re. Second: working on it. Thanks for report.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=5f1294d5d659f34030d960c9cead1647d7120e50 commit 5f1294d5d659f34030d960c9cead1647d7120e50 Author: Chad Jacob Milios <milios@ccsys.com> AuthorDate: 2025-04-11 13:00:56 +0000 Commit: Zsolt Udvari <uzsolt@FreeBSD.org> CommitDate: 2025-04-11 13:01:52 +0000 audio/baresip: Update to 3.21.0 Co-worker in PR takes maintainership. PR: 286024 audio/baresip/Makefile | 7 +++---- audio/baresip/distinfo | 6 +++--- 2 files changed, 6 insertions(+), 7 deletions(-)
Thanks for your work, committed. Herbert, as new maintainer, would you like clean and modernize the Makefile? I have ideas shorten it.
(In reply to Zsolt Udvari from comment #7) Thanks. My priorities are: 1. Keeping audio/re and audio/baresip up-to-date 2. Adding missing features (e.g. GTK) and fixing features (gstreamer seems to be broken!) 3. Improving the port (Flavour?) so that the port is usable when installed via packages. Do you mean something like the OpenSSL ports do? I am open for suggestions and if you have something ready, feel free to commit them!
(In reply to Herbert J. Skuhra from comment #8) The flavors doesn't an option in this case because it's designed for mutually exclusive options (for example: qt4 or qt5). The options helpers (see https://docs.freebsd.org/en/books/porters-handbook/book/#options-helpers) is preferred over '.if ${PORT_OPTIONS:M*}...' (and shorter). And doesn't need the for-loop at line 193. The MODULES_LIST can be space-separated and in CMAKE_ARGS can use ":ts" variable modifiers (see "man make") - so doesn't need the ":=" assignment and can use simple "+=". Maybe the ABI_* variables are unneeded because they appear only once or twice in pkg-plist. Would you try implement it?
(In reply to Zsolt Udvari from comment #9) It's funny that the port had no MAINTAINER for a very long time and now... I've thought I could use FLAVOR to create a LITE (audio only) and a FULL version (audio and video). I have to admit that I have to read porters handbook again, recheck files in Mk and read some other ports. So it will take some time. If you can improve the port instantly please go on!
(In reply to Herbert J. Skuhra from comment #10) Hi Herbert, I modernized the Makefile. The Makefile is shorter (about 80 lines).
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=724c2486e632fc451c0ca70a372e9fd409fe7f54 commit 724c2486e632fc451c0ca70a372e9fd409fe7f54 Author: Zsolt Udvari <uzsolt@FreeBSD.org> AuthorDate: 2025-04-25 14:07:25 +0000 Commit: Zsolt Udvari <uzsolt@FreeBSD.org> CommitDate: 2025-04-25 14:11:20 +0000 audio/baresip: Modernize port Use option helpers instead of many if-statements. The MODULES_LIST is handled by OPT_VARS option helpers. The make's variable modifier sets the semicolon separator in CMAKE_ARGS. PR: 286024 Approved by: Herbert J. Skuhra <herbert@gojira.at> (maintainer) audio/baresip/Makefile | 240 ++++++++++++++++-------------------------------- audio/baresip/pkg-plist | 2 - 2 files changed, 78 insertions(+), 164 deletions(-)