Created attachment 259477 [details] tremotesf-2.8.0.patch https://github.com/equeim/tremotesf2/releases/tag/2.8.0
(In reply to Denis Shaposhnikov from comment #0) Yeah, test builds are running on my poudriere right now. Would be done 2 days ago if portscout wouldn't bug out again... Couple of comments on patch: 1. According to section 9.5 of Committer's Guide [0], first subject letter should be capitalized, i.e. '<...>: Update <...>', not 'update'. 2. I didn't find specific rule for this, but I would still suggest prefix GitHub link with 'Changelog: '. [0]: https://docs.freebsd.org/en/articles/committers-guide/#_capitalize_the_first_letter_of_the_subject
Created attachment 259525 [details] v0 (apply via 'git am') Meanwhile, 2.8.1 released. I can confirm it builds on all supported FreeBSD releases (amd64 tested), and also works fine on 14.2R.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=1fbd62e7c4f0024f698b222c0b23927958d4492b commit 1fbd62e7c4f0024f698b222c0b23927958d4492b Author: Anton Saietskiiv <sasjason@gmail.com> AuthorDate: 2025-04-14 06:38:01 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2025-04-15 06:07:37 +0000 net-p2p/tremotesf: update to 2.8.0 ChangeLog: https://github.com/equeim/tremotesf2/releases/tag/2.8.1 Added * Option to show torrent properties in a panel in the main window instead of dialog * Ability to set labels on torrents and filter torrent list by labels * Option to display relative time * Option to display only names of download directories in sidebar and torrents list Changed * Options dialog is rearranged to use multiple tabs * Message that's shown when trying to add torrent while disconnected from server is now displayed in a dialog instead of main window Fixed * Delayed loading of peers for active torrents * Window activation from clicking on notification * Not working file dialogs when installed through Flatpak PR: 286044 net-p2p/tremotesf/Makefile | 2 +- net-p2p/tremotesf/distinfo | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-)
Committed, Thanks!
(In reply to Fernando Apesteguía from comment #4) I'd like to note couple of issues with commit: 1. First letter of subject is not capitalized (please see no. 1 in comment #1). 2. It mentions '2.8.0' whereas update has been made for newer version, 2.8.1. Additionally, distinfo timestamp is different, which means you didn't apply maintainer-approved patch as it does not contain mentioned above errors. If there's a need to copy changelog from GitHub release page and distfile itself into commit message (which I honestly don't think is very useful) or apply any other changes (like inserting PR link which I also did) -- it's still totally possible do 'git am < patch' with '<whatever> && git commit --amend' afterwards. Not sure if something could be done now, but I would be very grateful if my patches will be used as base in future (unless proven wrong).
(In reply to Anton Saietskii from comment #5) Hi Anton, 1. - That is a generic "rule", for many types of commits. This does not apply to ports since the subject line always starts with "category/port" and that *should not* be capitalized (i.e. Category/port). 2. - That is what the subject in this PR says. I should have double checked, but also the subject of the PR should have been changed to reflect the state of the patch. TIMESTAMP is different because I had to do a "make makesum" again due to a problem applying your patch. In addition, proper attribution was given: commit 1fbd62e7c4f0024f698b222c0b23927958d4492b Author: Anton Saietskiiv <sasjason@gmail.com> <---- Date: Mon Apr 14 08:38:01 2025 +0200 The only difference in the patch is the TIMESTAMP (besides the 2.8.0 number that I already warned about). Also, no subject line should contain any tags, especially [PATCH]
(In reply to Fernando Apesteguía from comment #6) > This does not apply to ports This is not true. > subject line always starts with "category/port" and that *should not* be capitalized (i.e. Category/port) Of course, but section 9.5. of Committer's Guide explicitly states this: "Capitalize the first letter of the subject itself. The prefix, if any, is not capitalized unless necessary (e.g., USB: is capitalized)." And section 9.4. [0] gives a specific example: "foo: Add -k option to keep temporary data" So, correct would be 'net-p2p/tremotesf: Update ...' with capital 'U'. Should we consult with portmgr@ on this matter to confirm if I'm right? > I had to do a "make makesum" again due to a problem applying your patch I'm pretty confident there's no any issues with my patch if downloaded by correct link [1] (*name of the patch* in first column of 'Attachments' table, , not 'Diff' link from last column). [0]: https://docs.freebsd.org/en/articles/committers-guide/#_prefix_the_subject_line_with_a_component_if_applicable [1]: https://bz-attachments.freebsd.org/attachment.cgi?id=259525
(In reply to Anton Saietskii from comment #7) > So, correct would be 'net-p2p/tremotesf: Update ...' with capital 'U'. Should we consult with portmgr@ on this matter to confirm if I'm right? Please do. > I'm pretty confident there's no any issues with my patch if downloaded by correct link [1] (*name of the patch* in first column of 'Attachments' table, , not 'Diff' link from last column). I didn't say so. Reread my message carefully. I said I had a problem applying your patch, not that was your fault.
(In reply to Fernando Apesteguía from comment #8) Dear portmgr team, Please advise on the no. 1 from comment comment #5. If I read sections 9.4 [0] and 9.5 [1] of Committer's Guide correctly, commit message of 1fbd62e7c4f0024f698b222c0b23927958d4492b should be "net-p2p/tremotesf: Update to 2.8.0" with capital 'U', not "net-p2p/tremotesf: update to 2.8.0" (which is also wrong in version number). Am I right that saying "This does not apply to ports" (comment #6) is straight up misinformation? Additionally (just noticed that), Author: is wrong as well -- I'm not " Anton Saietskiiv <sasjason@gmail.com>", I'm "Anton Saietskii <vsasjason@gmail.com>" (which is also set correctly in the patch I attached to this PR). [0]: https://docs.freebsd.org/en/articles/committers-guide/#_prefix_the_subject_line_with_a_component_if_applicable [1]: https://docs.freebsd.org/en/articles/committers-guide/#_capitalize_the_first_letter_of_the_subject
Please, accept my deepest apologies. Yes, I gave misinformation and tried to misled you when interpreting the Committer's Guide. I did not use your patch (I already said that, but I think you don't care). Sorry again portmgr@, bugmeister@m, ports-committers@ and the whole FreeBSD Project. To avoid any more confusions in the future, I will not take any other PRs from you. Please, have a good day, and apologies again.
A commit in branch 2025Q2 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=f993049dbe24c8525e2c86da209d1754b66b395a commit f993049dbe24c8525e2c86da209d1754b66b395a Author: Anton Saietskiiv <sasjason@gmail.com> AuthorDate: 2025-04-14 06:38:01 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2025-04-18 01:10:02 +0000 net-p2p/tremotesf: update to 2.8.0 ChangeLog: https://github.com/equeim/tremotesf2/releases/tag/2.8.1 Added * Option to show torrent properties in a panel in the main window instead of dialog * Ability to set labels on torrents and filter torrent list by labels * Option to display relative time * Option to display only names of download directories in sidebar and torrents list Changed * Options dialog is rearranged to use multiple tabs * Message that's shown when trying to add torrent while disconnected from server is now displayed in a dialog instead of main window Fixed * Delayed loading of peers for active torrents * Window activation from clicking on notification * Not working file dialogs when installed through Flatpak PR: 286044 (cherry picked from commit 1fbd62e7c4f0024f698b222c0b23927958d4492b) net-p2p/tremotesf/Makefile | 2 +- net-p2p/tremotesf/distinfo | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-)