Bug 286050 - [PATCH] www/nginx-devel: update modsecurity nginx connector to latest commit 17405e0
Summary: [PATCH] www/nginx-devel: update modsecurity nginx connector to latest commit ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Sergey A. Osokin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-04-12 05:57 UTC by Saiful Alam
Modified: 2025-04-12 18:07 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (osa)


Attachments
modsecurity nginx connector patch (13.89 KB, patch)
2025-04-12 05:57 UTC, Saiful Alam
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saiful Alam 2025-04-12 05:57:08 UTC
Created attachment 259488 [details]
modsecurity nginx connector patch

Hi,

Please review my patch to update the ModSecurity NGINX connector to the latest upstream commit 17405e0.

The previous commit fb678c5 introduced an issue where the response body was sometimes corrupted — HTML pages would often not start with <html> tags and, in some cases, the response would be incomplete. Updating to 17405e0 resolves this issue.

Thank you.
Comment 1 commit-hook freebsd_committer freebsd_triage 2025-04-12 17:56:13 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=71d982a7dd4cf45b9f5e00074558b61c814a6a79

commit 71d982a7dd4cf45b9f5e00074558b61c814a6a79
Author:     Sergey A. Osokin <osa@FreeBSD.org>
AuthorDate: 2025-04-12 17:53:25 +0000
Commit:     Sergey A. Osokin <osa@FreeBSD.org>
CommitDate: 2025-04-12 17:53:25 +0000

    www/nginx-devel: third-party ModSecurity module update (+)

    ... to the latest snapshot.

    Bump PORTREVISION.

    Submitted by:   Saiful Alam <saifulmr@hotmail.com>
    PR:             286050

 www/nginx-devel/Makefile        | 2 +-
 www/nginx-devel/Makefile.extmod | 2 +-
 www/nginx-devel/distinfo        | 6 +++---
 3 files changed, 5 insertions(+), 5 deletions(-)
Comment 2 Sergey A. Osokin freebsd_committer freebsd_triage 2025-04-12 17:57:16 UTC
Committed with some modifications, thank you for the report, Saiful!
Comment 3 Saiful Alam 2025-04-12 18:07:43 UTC
Hi Sergey,
I noticed that in your commit, the repository for Modsecurity NGINX Connector is changed to SpiderLabs again, where as the distinfo refer to owasp-modsecurity. 

Makefile.extmod:
-MODSECURITY3_GH_TUPLE=		owasp-modsecurity:ModSecurity-nginx:fb678c5:modsecurity3
+MODSECURITY3_GH_TUPLE=		SpiderLabs:ModSecurity-nginx:ef64996:modsecurity3

distinfo:
-SHA256 (owasp-modsecurity-ModSecurity-nginx-fb678c5_GH0.tar.gz) = ec7fa90e36ccb339ee38f5d273820d56b014d5e469239c0d11a7567bc7e5a4a8
-SIZE (owasp-modsecurity-ModSecurity-nginx-fb678c5_GH0.tar.gz) = 52666
+SHA256 (owasp-modsecurity-ModSecurity-nginx-17405e0_GH0.tar.gz) = 356f2dcf7160c739dc05fe3b011d0515d5d721d9e9c7c8b3864a822614d7523b
+SIZE (owasp-modsecurity-ModSecurity-nginx-17405e0_GH0.tar.gz) = 115994

I think it may cause build errors