Bug 286100 - www/go-www: update to 2.0.5
Summary: www/go-www: update to 2.0.5
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Zsolt Udvari
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-04-14 20:10 UTC by Nicolas Embriz
Modified: 2026-02-15 17:38 UTC (History)
2 users (show)

See Also:
nbari: maintainer-feedback+

Attachments
patch (1.78 KB, patch)
2025-04-14 20:10 UTC, Nicolas Embriz 		no flags Details | Diff
git format-patch (2.26 KB, patch)
2025-05-14 16:41 UTC, Nicolas Embriz 		nbari: maintainer-approval+
Details | Diff
modified diff (1.99 KB, patch)
2026-01-11 09:00 UTC, Zsolt Udvari 		uzsolt: maintainer-approval?
Details | Diff
2.0.5 (2.12 KB, patch)
2026-02-15 14:31 UTC, Nicolas Embriz 		nbari: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Embriz 2025-04-14 20:10:56 UTC 
Created attachment 259559 [details]
patch

Update to 2.0.4 (bump versions)
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2025-04-21 16:37:09 UTC 
Please use git to generate patches

PORTVERSION should be DISTVERSION (Porters Handbook)
WWW is dead
You can't use go:modules (see Porters Handbook)?
GO_BUILDFLAGS are probably not needed, https://cgit.freebsd.org/ports/tree/Mk/Uses/go.mk#n110

Best regards,
Daniel
Comment 2 Nicolas Embriz 2025-04-22 02:07:56 UTC 
Hi Daniel, using  poudriere testport -p default -j 14amd64 www/go-www works

Regarding WWW, what do you mean by dead? And git you mean GitHub (a Pull request)
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2025-05-04 20:03:18 UTC 
https://cgit.freebsd.org/ports/tree/www/go-www/Makefile#n9

Also,  you should follow https://docs.freebsd.org/en/books/porters-handbook/book/#using-go including the use of variables
Comment 4 Nicolas Embriz 2025-05-14 16:41:37 UTC 
Created attachment 260410 [details]
git format-patch

Updated port using now modules2tuple and git patch
Comment 5 Zsolt Udvari freebsd_committer freebsd_triage 2026-01-11 09:00:22 UTC 
Created attachment 267029 [details]
modified diff

I made some modifications against your diff:
Add go:modules.
Remove GO_BUILDFLAGS.
Pet portlint, portfmt.
Comment 6 Zsolt Udvari freebsd_committer freebsd_triage 2026-02-15 13:16:39 UTC 
Friendly ping.
Comment 7 Nicolas Embriz 2026-02-15 14:31:19 UTC 
Created attachment 268075 [details]
2.0.5

Hi, plese find attached new patch
Comment 8 Zsolt Udvari freebsd_committer freebsd_triage 2026-02-15 17:38:11 UTC 
Thanks for work, Nicolas! Committed!
Comment 9 commit-hook freebsd_committer freebsd_triage 2026-02-15 17:38:32 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3b51df453f8fc59d1f1f12a2dbec1bf838e5b09e

commit 3b51df453f8fc59d1f1f12a2dbec1bf838e5b09e
Author:     Nicolas Embriz <nbari@tequila.io>
AuthorDate: 2026-02-15 17:35:17 +0000
Commit:     Zsolt Udvari <uzsolt@FreeBSD.org>
CommitDate: 2026-02-15 17:37:34 +0000

    www/go-www: Update to 2.0.5

    Remove GO_BUILDFLAGS.
    Update WWW.

    Changelogs:
    https://github.com/nbari/www/releases/tag/2.0.4
    https://github.com/nbari/www/releases/tag/2.0.5

    PR:             286100
    Approved by:    submitter is maintainer

 www/go-www/Makefile | 11 +++++------
 www/go-www/distinfo | 14 +++++++++-----
 2 files changed, 14 insertions(+), 11 deletions(-)