Bug 286110 - textproc/py-docstring_parser: update to 0.16
Summary: textproc/py-docstring_parser: update to 0.16
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kai Knoblich
URL: https://github.com/rr-/docstring_pars...
Keywords:
Depends on:
Blocks:
 
Reported: 2025-04-15 10:23 UTC by Hiroki Tagato
Modified: 2025-04-16 12:16 UTC (History)
1 user (show)

See Also:
kai: maintainer-feedback+


Attachments
Patch (1.39 KB, patch)
2025-04-15 10:23 UTC, Hiroki Tagato
kai: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hiroki Tagato freebsd_committer freebsd_triage 2025-04-15 10:23:27 UTC
Created attachment 259578 [details]
Patch

textproc/py-docstring_parser: update to 0.16

While here, switch to USE_PYTHON=pep517.

Changelog: https://github.com/rr-/docstring_parser/blob/0.16/CHANGELOG.md

QA: poudriere testport: OK ({142,134}{amd64,i386})
Comment 1 Kai Knoblich freebsd_committer freebsd_triage 2025-04-16 05:48:04 UTC
(In reply to Hiroki Tagato from comment #0)

Hi,

thanks for your patch. It looks good for me and I've only two hints/suggestions:

- If you like, you can simplify the Makefile further by using "USE_PYTHON=pytest" and remove the "TEST_DEPENDS" and the "do-test" target.

- One the patch lands into the ports tree it will break the port misc/py-instructor you maintain due its version requirements in its RUN_DEPENDS for py-docstring_parser.

If you already have a patch for py-instructor and intend to commit it as soon as py-docstring_parser has been updated, it would make sense to do both in one go.

If this is the case, you are welcome to commit the patch for py-docstring_parser yourself.
Comment 2 Hiroki Tagato freebsd_committer freebsd_triage 2025-04-16 11:37:02 UTC
(In reply to Kai Knoblich from comment #1)

Hi Kai,

Thanks for the helpful suggestions.

It does make sense to use USE_PYTHON=pytest for a simpler Makefile. Regarding the second comment, I have prepared a patch for py-instructor and would like to update the two ports at the same time.

I will soon commit the changes.

Thanks for your approval.
Comment 3 commit-hook freebsd_committer freebsd_triage 2025-04-16 12:15:08 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3fbc3a4208ba5e20987d7c9f22f82a3acf9b141e

commit 3fbc3a4208ba5e20987d7c9f22f82a3acf9b141e
Author:     Hiroki Tagato <tagattie@FreeBSD.org>
AuthorDate: 2025-04-16 12:05:19 +0000
Commit:     Hiroki Tagato <tagattie@FreeBSD.org>
CommitDate: 2025-04-16 12:13:59 +0000

    textproc/py-docstring_parser: update to 0.16

    While here:
    - switch to USE_PYTHON=pep517
    - switch to USE_PYTHON=pytest and remove TEST_DEPENDS and do-test target

    Changelog: https://github.com/rr-/docstring_parser/blob/0.16/CHANGELOG.md

    PR:             286110
    Reviewed by:    kai
    Approved by:    kai

 textproc/py-docstring_parser/Makefile | 10 +++-------
 textproc/py-docstring_parser/distinfo |  6 +++---
 2 files changed, 6 insertions(+), 10 deletions(-)
Comment 4 Hiroki Tagato freebsd_committer freebsd_triage 2025-04-16 12:16:48 UTC
Committed, thanks!