Created attachment 259623 [details] textproc/git-who.patch Unlike `git blame`, which can tell you who wrote a line of code, git-who tells you the people responsible for entire components or subsystems in a codebase. You can think of git-who sort of like `git blame` but for file trees rather than individual files. WWW: https://github.com/sinclairtarget/git-who Poudriere testport passes on 142amd64-default. Also pet'd port{clippy,fmt,lint}. Thanks in advance.
Created attachment 259624 [details] Screenshot of the program output
Thanks for a new port submission. It's been a while since you have filed this PR. Are you still interested in getting this into the ports tree? If so, can you update the patch and resubmit? Upstream has updated to 1.1.
Created attachment 261491 [details] textproc/git-who.patch > Are you still interested in getting this into the ports tree? Yes :) > can you update the patch and resubmit? Upstream has updated to 1.1. consider it done. Thanks!
(In reply to Yusuf Yaman from comment #4) Thanks for updating the patch. This is what I failed to notice at the first review. But I think "devel" is more appropriate category than "textproc" because the port is a kind of development statistics tools on git repositories. Another comment is about post-extract stage. Is "${MKDIR} vendor" necessary? The vendor directory is already present at this point in time. So it seems the command is redundant.
Created attachment 261526 [details] devel/git-who.patch (In reply to Hiroki Tagato from comment #5) > But I think "devel" is more appropriate category than "textproc" because the port is a kind of development statistics tools on git repositories. Right, i agree with you. > Is "${MKDIR} vendor" necessary? I found out that it isn't necessary, thanks.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=7fd991b5a5495d3fbffe3906d06e0707bbfa9c83 commit 7fd991b5a5495d3fbffe3906d06e0707bbfa9c83 Author: Yusuf Yaman <nxjoseph@protonmail.com> AuthorDate: 2025-04-16 19:45:20 +0000 Commit: Hiroki Tagato <tagattie@FreeBSD.org> CommitDate: 2025-06-24 12:51:52 +0000 devel/git-who: new port: Git blame for file trees Unlike `git blame`, which can tell you who wrote a line of code, git-who tells you the people responsible for entire components or subsystems in a codebase. You can think of git-who sort of like `git blame` but for file trees rather than individual files. WWW: https://github.com/sinclairtarget/git-who PR: 286146 Reported by: Yusuf Yaman <nxjoseph@protonmail.com> (new maintainer) devel/Makefile | 1 + devel/git-who/Makefile (new) | 28 ++++++++++++++++++++++++++++ devel/git-who/distinfo (new) | 15 +++++++++++++++ devel/git-who/files/modules.txt (new) | 24 ++++++++++++++++++++++++ devel/git-who/pkg-descr (new) | 4 ++++ 5 files changed, 72 insertions(+)
Committed, thanks!
(In reply to Hiroki Tagato from comment #8) Thanks! I now wondered that if it would be better if i use post-patch instead of post-extract?
(In reply to Yusuf Yaman from comment #9) What makes you think so? I personally think post-extract is fine because modules.txt is about downloaded (in our case, extracted) vendored modules.
(In reply to Hiroki Tagato from comment #10) > I personally think post-extract is fine because modules.txt is about downloaded (in our case, extracted) vendored modules. That's fine too but i feel like if we are replacing a file in WRKSRC, it should be called in a patch stage. I guess not too much important here.