Patch is on https://reviews.freebsd.org/D49906 if necessary, we can attach it here.
Hi, checking on this PR and associated exp-run. We need to switch our default ASAP as 1.21 is unsupported and not receiving any of the security fixes. It makes no sense to switch to anything but 1.24 (see associated PRs). I intend to follow through with my plan and fix whatever breaks after the switch, unless exp-run results show something awful.
Closing loops: I set go124 as the default. I'll keep an eye on it and we can reset it if needed.
(In reply to Adam Weinberger from comment #2) Awesome! I maintain 14 go ports. Is it a good procedure that I remove version specifiers now, do a personal exp-run and if all good, commit ports without version specifiers right away? Thanks!
(In reply to Nuno Teixeira from comment #3) Great question! My thoughts here are that there's no NEED to remove the version specifiers today, but there's also no reason not to. What would be hugely helpful though is knowing whether things that previously needed a hardcoded version can now build without incident on 1.24. That's kindof the big looming question: if the new-and-improved toolchain isn't as rock-solid as they claim it is, it's better to know now rather than later! So, TL;DR--By all means, please do remove version restrictors and let us know how the build goes! But as for committing them... if it were me, I'd prefer building them on 1.24 (the toolchain only gets better and better over time), but if you want to err on the side of caution you could wait and nobody would blame you.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=aea1b30840ddafa7cf18406c7454e72334b14be1 commit aea1b30840ddafa7cf18406c7454e72334b14be1 Author: Nuno Teixeira <eduardo@FreeBSD.org> AuthorDate: 2025-05-22 02:06:32 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2025-05-22 02:08:34 +0000 */*: Remove version specifiers on go ports I maintain PR: 286214 dns/blocky/Makefile | 4 ++-- net-mgmt/blackbox_exporter/Makefile | 4 ++-- security/gopass/Makefile | 4 ++-- security/picocrypt/Makefile | 4 ++-- sysutils/gomi/Makefile | 4 ++-- sysutils/gomplate/Makefile | 4 ++-- sysutils/kopia/Makefile | 4 ++-- sysutils/restic/Makefile | 4 ++-- x11/wallutils/Makefile | 4 ++-- 9 files changed, 18 insertions(+), 18 deletions(-)
(In reply to commit-hook from comment #5) exp-run on my side was OK and I've run-tested some of the ports. No issues at all. I did reference commit to this PR because it may be usefull.
(In reply to Nuno Teixeira from comment #6) Thanks! I'm really glad to hear the positive report.
*** Bug 281773 has been marked as a duplicate of this bug. ***
Portmgr: I committed a first, much smaller step instead, so I'm taking the PR back to the go team. Next step is to ignore version specifiers (i.e. build everything with GO_DEFAULT, now 1.24). I'll put that patch back on your radar once it's ready, as that will definitely need an exp-run.