Bug 286432 - devel/newt: Update to 0.52.25
Summary: devel/newt: Update to 0.52.25
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL: https://releases.pagure.org/newt/
Keywords:
Depends on:
Blocks:
 
Reported: 2025-04-29 04:21 UTC by Atanu Biswas
Modified: 2025-05-09 14:09 UTC (History)
1 user (show)

See Also:
vvd: merge-quarterly+


Attachments
patch to update devel/newt to 0.52.25 (966 bytes, patch)
2025-04-29 04:21 UTC, Atanu Biswas
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Atanu Biswas 2025-04-29 04:21:20 UTC
Created attachment 259982 [details]
patch to update devel/newt to 0.52.25

Summary

- Update to 0.52.25

- Use DISTVERSION instead of PORTVERSION

- Update distinfo checksum and size

- poudriere testport ok (amd64, 14.0-RELEASE)

- check-plist passed cleanly
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2025-04-29 13:01:30 UTC
TCL option is broken.
Can you fix it?

cc -o whiptail whiptail.o dialogboxes.o -L. -L/usr/local/lib -lncurses -fstack-protector-strong  -lnewt -lslang -lintl -lpopt
cc -fPIC -c -O2 -pipe -march=nehalem  -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -I/usr/local/include -I/usr/local/include/tcl8.6 -isystem /usr/local/include  -o shared/whiptcl.o whiptcl.c
whiptcl.c:188:14: error: no member named 'result' in 'struct Tcl_Interp'
  188 |             interp->result = "list-height missing";
      |             ~~~~~~  ^
whiptcl.c:193:14: error: no member named 'result' in 'struct Tcl_Interp'
  193 |             interp->result = "list-height is not a number";
      |             ~~~~~~  ^
whiptcl.c:183:13: warning: 4 enumeration values not handled in switch: 'MODE_NONE', 'MODE_MSGBOX', 'MODE_YESNO'... [-Wswitch]
  183 |     switch (mode) {
      |             ^~~~
whiptcl.c:216:14: error: no member named 'result' in 'struct Tcl_Interp'
  216 |             interp->result = "yes";
      |             ~~~~~~  ^
whiptcl.c:218:14: error: no member named 'result' in 'struct Tcl_Interp'
  218 |             interp->result = "no";
      |             ~~~~~~  ^
whiptcl.c:225:14: error: no member named 'result' in 'struct Tcl_Interp'
  225 |             interp->result = result;
      |             ~~~~~~  ^
whiptcl.c:226:14: error: no member named 'freeProc' in 'struct Tcl_Interp'
  226 |             interp->freeProc = TCL_DYNAMIC;
      |             ~~~~~~  ^
whiptcl.c:234:14: error: no member named 'result' in 'struct Tcl_Interp'
  234 |             interp->result = result;
      |             ~~~~~~  ^
whiptcl.c:235:14: error: no member named 'freeProc' in 'struct Tcl_Interp'
  235 |             interp->freeProc = TCL_DYNAMIC;
      |             ~~~~~~  ^
whiptcl.c:243:14: error: no member named 'result' in 'struct Tcl_Interp'
  243 |             interp->result = selections[0];
      |             ~~~~~~  ^
whiptcl.c:244:14: error: no member named 'freeProc' in 'struct Tcl_Interp'
  244 |             interp->freeProc = TCL_DYNAMIC;
      |             ~~~~~~  ^
Comment 2 Atanu Biswas 2025-04-30 08:30:31 UTC
(In reply to Vladimir Druzenko from comment #1)
Checking how to fix this
Comment 3 Vladimir Druzenko freebsd_committer freebsd_triage 2025-05-09 13:15:08 UTC
Patch (workaround):
-TCL_CPPFLAGS=           -I${TCL_INCLUDEDIR:Q}
+TCL_CPPFLAGS=           -I${TCL_INCLUDEDIR:Q} -DUSE_INTERP_RESULT

https://trac.macports.org/ticket/37725
https://bugzilla.redhat.com/show_bug.cgi?id=902561
https://github.com/hoche/cicb/issues/1
Comment 4 commit-hook freebsd_committer freebsd_triage 2025-05-09 14:06:28 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4a8caba0e86e024c4c38a04ecdd716b27c2fd241

commit 4a8caba0e86e024c4c38a04ecdd716b27c2fd241
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2025-05-09 13:51:55 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2025-05-09 14:06:06 +0000

    devel/newt: Update 0.52.24 => 0.52.25, set maintainership

    Changelog:
    https://pagure.io/newt/blob/master/f/CHANGES

    Improve port:
    - Replace PORTVERSION with DISTVERSION
    - Replace CPPFLAGS and LDFLAGS with USES=localbase:ldflags
    - Remove GNU_CONFIGURE_MANPREFIX
    - Remove MAKE_JOBS_UNSAFE
    - Fix {NLS,PYTHON}_USES - gettext-runtime
    - Fix TCL option with tcl86 (workaround)
    - Fix warnings from portclippy
    - Set MAINTAINER to Atanu Biswas <atanubiswas484@gmail.com>

    PR:             286432
    Co-authored-by: Atanu Biswas <atanubiswas484@gmail.com>
    MFH:            2025Q2

 devel/newt/Makefile | 32 +++++++++++++-------------------
 devel/newt/distinfo |  6 +++---
 2 files changed, 16 insertions(+), 22 deletions(-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2025-05-09 14:07:28 UTC
A commit in branch 2025Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8825013f1e9ec6dcb7d47b08bb437cb047ecceed

commit 8825013f1e9ec6dcb7d47b08bb437cb047ecceed
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2025-05-09 13:51:55 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2025-05-09 14:06:50 +0000

    devel/newt: Update 0.52.24 => 0.52.25, set maintainership

    Changelog:
    https://pagure.io/newt/blob/master/f/CHANGES

    Improve port:
    - Replace PORTVERSION with DISTVERSION
    - Replace CPPFLAGS and LDFLAGS with USES=localbase:ldflags
    - Remove GNU_CONFIGURE_MANPREFIX
    - Remove MAKE_JOBS_UNSAFE
    - Fix {NLS,PYTHON}_USES - gettext-runtime
    - Fix TCL option with tcl86 (workaround)
    - Fix warnings from portclippy
    - Set MAINTAINER to Atanu Biswas <atanubiswas484@gmail.com>

    PR:             286432
    Co-authored-by: Atanu Biswas <atanubiswas484@gmail.com>
    MFH:            2025Q2
    (cherry picked from commit 4a8caba0e86e024c4c38a04ecdd716b27c2fd241)

 devel/newt/Makefile | 32 +++++++++++++-------------------
 devel/newt/distinfo |  6 +++---
 2 files changed, 16 insertions(+), 22 deletions(-)
Comment 6 Vladimir Druzenko freebsd_committer freebsd_triage 2025-05-09 14:09:58 UTC
Can you as maintainer report to upstream (https://pagure.io/newt/issues ?) build errors with TLC 8.6?

Thanks.