Hi, I'm using the latest head (commit base 83507f9e6fedbc02d1acecc9fb5c09eae34b1ae6 date: Sun May 4 00:49:28 2025 -0700). pam_ssh.so started reporting an undefined symbol. This is very very similar to an issue I reported years ago in bug #258384 Looks like this is caused by commits base 1c99af1ebe61cbaf633792941640dcd254acf921 and base 65d8491719bbc88ed45637d2381931c2d29cfe87 The last one works fine for ssh parts itself, but leaves out pam_ssh, whcih now is missing the implementation of ssh-sk-client. I have fixed the issue locally by adding back ssh-sk-client.c to libssh SRCS, but this is not the correct fix. A first try at adding ssh-sk-client.c to pam_ssh SRCS fails, since it causes redefined symbols, some more glue is needed. I'm investigating how to fix this properly.
I would prefer to partially revert base 65d8491719bbc88ed45637d2381931c2d29cfe87. I heed to change the commit log and test more, but here is the review: https://reviews.freebsd.org/D50020 Let me know if you can test this review and see if it removes the warning.
(In reply to Jose Luis Duran from comment #1) I've tested the patch in the review and it fixes the issue.