in #280931 (which was about adding a dependency on publicsuffixlist), a few other changes were proposed, general cleanup stuff re:whitespace and modern standards. I'm opening this bug to track those. - fix warnings from portclippy, Straightforward, I'll do that in my own time (i.e. not on this issue). I think I last tested this with only portlint (and poudriere testport). I can create separate commits: 1) add dns/public_suffix_list only, 2) "improve port" with all other changes. 2. - adjust whitespaces, Could you clarify? Align values in LICENSE* variables, remove/add several empty lines. 3. - remove GNU_CONFIGURE_MANPREFIX, I didn't know that was a thing, but sure, can do that (again, outside of scope for this issue) This was temporarily added during the man migration from "${PREFIX}/man" to "${PREFIX}/share/man". Since the migration has long been completed and the default value of this variable is the same "${PREFIX}/share", it must be deleted, which is what we do when we update a port. 4. - use "${DISTVERSION:S/./-/g}" in GH_TAGNAME instead of hardcoded version "1-4-2": Can also do that!
As soon as you confirm the proposed changes, I will commit them immediately.
I approve these, as the port maintainer. -Dan
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=d396e8428a4aada5c29a2281dd47c5be60cdff8f commit d396e8428a4aada5c29a2281dd47c5be60cdff8f Author: Vladimir Druzenko <vvd@FreeBSD.org> AuthorDate: 2025-05-05 11:24:55 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2025-05-05 11:44:30 +0000 net/openrsync: Improve port - Fix warnings from portclippy. - Adjust whitespaces: allign values in LICENSE* variables, remove/add several empty lines. - Remove GNU_CONFIGURE_MANPREFIX. - Use "${DISTVERSION:S/./-/g}" in GH_TAGNAME instead of hardcoded version "1-4-2". - Use ${PORTNAME} instead of "opendmarc" in GH_TAGNAME and USE_RC_SUBR. PR: 286588 Approved by: Dan Mahoney <freebsd@gushi.org> (maintainer) mail/opendmarc/Makefile | 38 ++++++++++++++++++-------------------- 1 file changed, 18 insertions(+), 20 deletions(-)
Thanks.