Created attachment 260179 [details] jackit.log Patches are not applied cleanly. I attached the log of "make -DBATCH all deinstall install clean".
Created attachment 260503 [details] jack.patch My guess is that the patch is already in the sources. I tried compiling with and without SOSSO and it builds. As the patch I removed is for waf (the build system), not the code, no functionality should be changed.
The proposed patch totally disables SOSSO, so please ignore my clumsy attempt to fix the build.
Hi Meka, sorry for the long wait, I was drowning in work at my new job. There is a second patch to fix this in bug #285953 (which actually introduced) the problem, but it seems to be ignored by the committer. How about we migrate that patch to this PR here and then call for it to be committed? I'll probably do that later today, still working through my backlog of missed FreeBSD duties. Cheers, Flo
Created attachment 260692 [details] Fix build with SOSSO option after waf update patch. This fixes the build of audio/jack with SOSSO option set. The sources used for SOSSO already include the waf update that was brought in by bug #285953.
Hello Florian, Just take your time and I hope your new job is fun! As for the patch, it works, but please bump PORTREVISION. Thank you so much for the patch!
(In reply to Florian Walpen from comment #4) Option-depend patch should be EXTRA_PATCHES (see [1], Example 3). [1] https://docs.freebsd.org/en/books/porters-handbook/book/#slow-patch-extra
(In reply to Goran Mekić from comment #5) @Meka, why bump PORTREVISION? There's no functional change apart from fixing the build, or am I missing something?
(In reply to Zsolt Udvari from comment #6) > Option-depend patch should be EXTRA_PATCHES (see [1], Example 3). It's not obvious to me whether this applies to downloaded patches, and how that would work. For example we don't have a full path to the patch, which seems required for EXTRA_PATCHES?