Bug 287052 - irc/atheme-services: Update to use PCRE2
Summary: irc/atheme-services: Update to use PCRE2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tim Bishop
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-05-24 18:03 UTC by ek
Modified: 2025-05-27 17:09 UTC (History)
2 users (show)

See Also:


Attachments
atheme-services PCRE2 patch (1.97 KB, patch)
2025-05-24 18:03 UTC, ek
no flags Details | Diff
atheme-services PCRE2 patch2 (1.97 KB, patch)
2025-05-25 19:06 UTC, ek
ek: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description ek 2025-05-24 18:03:12 UTC
Created attachment 260691 [details]
atheme-services PCRE2 patch

Since devel/pcre has reached EOL upstream and is marked as DEPRECATED, we can use devel/pcre2 instead. The patch provided updates the lib depends and config args for PCRE2.

It also includes some cleanup from portclippy, portfmt and portlint.
Comment 1 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2025-05-25 18:18:42 UTC
1. USE_RC_SUBR=${PORTNAME}
2. If you pet portclippy/portfmt it will have a blank line in between USE_RC_SUBR and GNU_CONFIGURE.
Apart from that it looks good. I haven't done any build/runtime tests.
Comment 2 ek 2025-05-25 19:06:50 UTC
Created attachment 260709 [details]
atheme-services PCRE2 patch2

(In reply to Muhammad Moinur Rahman from comment #1)

1. USE_RC_SUBR=${PORTNAME}

  Fixed!

2. If you pet portclippy/portfmt it will have a blank line in between USE_RC_SUBR and GNU_CONFIGURE.

  Strangely enough, running portclippy and portfmt didn't show a blank line for me. But, I went ahead and added it because of your recommendation. :)

Thank you for the feedback!
Comment 3 commit-hook freebsd_committer freebsd_triage 2025-05-27 17:07:24 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=895e23ed6942dae304aafe582868b1c10c69abf6

commit 895e23ed6942dae304aafe582868b1c10c69abf6
Author:     ek <ek@purplehat.org>
AuthorDate: 2025-05-27 17:02:54 +0000
Commit:     Tim Bishop <tdb@FreeBSD.org>
CommitDate: 2025-05-27 17:06:15 +0000

    irc/atheme-services: Switch from pcre to pcre2

    Also cleanups from portlint, etc.

    PR:     287052

 irc/atheme-services/Makefile | 39 +++++++++++++++++++--------------------
 1 file changed, 19 insertions(+), 20 deletions(-)
Comment 4 Tim Bishop freebsd_committer freebsd_triage 2025-05-27 17:09:42 UTC
Committed, thanks!