Bug 287164 - devel/isa-l: Unbreak build on aarch64
Summary: devel/isa-l: Unbreak build on aarch64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Jason W. Bacon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-05-30 12:51 UTC by Jason W. Bacon
Modified: 2025-06-14 12:20 UTC (History)
0 users

See Also:
sunpoet: maintainer-feedback+


Attachments
Unified diff to unbreak build on aarch64 (2.65 KB, patch)
2025-05-30 12:51 UTC, Jason W. Bacon
no flags Details | Diff
isa-l.patch (2.66 KB, patch)
2025-06-10 17:32 UTC, Mark Linimon
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jason W. Bacon freebsd_committer freebsd_triage 2025-05-30 12:51:41 UTC
Created attachment 260806 [details]
Unified diff to unbreak build on aarch64

The attached patch allows isa-l to build on aarch64 by using the portable base functions.  The upstream aarch-specific code is proving difficult to build on FreeBSD.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2025-06-10 17:32:20 UTC
Created attachment 261151 [details]
isa-l.patch

^Triage: rebase patch.
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2025-06-14 01:05:14 UTC
LGTM. Please name the patch as patch-aarch64. Thanks.
Comment 3 commit-hook freebsd_committer freebsd_triage 2025-06-14 12:18:39 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ec7391b149b965867f36a51eaf96f3e397a03d96

commit ec7391b149b965867f36a51eaf96f3e397a03d96
Author:     Jason W. Bacon <jwb@FreeBSD.org>
AuthorDate: 2025-06-14 12:15:10 +0000
Commit:     Jason W. Bacon <jwb@FreeBSD.org>
CommitDate: 2025-06-14 12:15:10 +0000

    devel/isa-l: Enable build on aarch64

    Using generic portable code for now.
    Upstream has optimized aarch64 code, but it is not portable.
    No changes on other archs.

    PR:             287164
    Approved by:    sunpoet

 devel/isa-l/Makefile                  |  4 ++-
 devel/isa-l/distinfo                  |  4 +--
 devel/isa-l/files/patch-aarch64 (new) | 53 +++++++++++++++++++++++++++++++++++
 3 files changed, 57 insertions(+), 4 deletions(-)