Created attachment 260867 [details] Patch for perl/Amanda/Tapelist.pm removing the unnecessary and non-exisistant qw( :severity ) I have three patches that should be committed to allow Amanda 3.5.1 to coexist with Perl 5.40. See also https://github.com/zmanda/amanda/issues/262
Created attachment 260868 [details] Patch for perl/Amanda/Taper/Scribe.pm adding -> now mandatory in Perl 5.40
Created attachment 260869 [details] Patch for perl/Amanda/Tapelist.swg This patch isn't necessary at this moment, but it might come handy down the road.
I began dabbling in Amanda 3.5.4 yesterday, but it's giving some headache since we now have to deal with the source coming from GitHub and we have to run autotools before the configure phase. This clashes with the current patch set. Unless there's a better way, we must patch, possibly different files, before and after running the autotools.
Created attachment 262694 [details] Patch for misc/amanda-server/Makefile adding NO_SHLIB_REQUIRES_GLOB and converters/p5-Encode-Locale for server-only Without NO_SHLIB_REQUIRES_GLOB it becomes impossible to depend on misc/amanda-server in other ports, leading to build-time error messages such as: pkg-static: Missing shlib dependency: libamanda-3.5.1.so. converters/p5-Encode-Locale was omitted by not testing this port on a system with no other packages installed.
Is there a way to help this move forward? I installed amanda-server a few days ago, and struggled to get it to behave - finding all the issues that have patches in here... Also, it still depends on 5.40, for whatever reason in ports I don't understand - so the system installed 5.40 in addition to the primary perl which is now 5.42 (this works, but is a python-esque evilness that should not be needed for perl)
Created attachment 273474 [details] Patch for common-src/bsdtcp-security.c fixing suppressed 1st char of error message in case of bsdtcp auth See also https://github.com/zmanda/amanda/commit/6fc364280b0aa5dbfe45fe7448c33d5234611788
Created attachment 273475 [details] Patch for misc/amanda-server/Makefile adding NO_SHLIB_REQUIRES_GLOB and converters/p5-Encode-Locale for server-only and converters/p5-JSON et al. for client-only
(In reply to Gert Doering from comment #5) Make sure your make.conf doesn't lock Perl5 to 5.40. I've locked my builder to Perl 5.42, and I have no issues.
Created attachment 273476 [details] Patch for common-src/bsdtcp-security.c fixing suppressed 1st char of error message in case of bsdtcp auth. I forgot the line above the call to strlen(3).
Created attachment 273480 [details] Patch for perl/Amanda/Script_App.pm suppressing all informational output since amcheck(8) treats anything received as error messages