Created attachment 260954 [details] Proposed fix The port lacks required build dependencies.
Was the 1.5.1 update tested under poudriere before being committed? That step should never be skipped, no matter how small the change seems. This regression is an example. The port builds fine if setuptools and wheel happen to be installed, but fails under poudriere which starts with a blank slate. I verified that both setuptools and wheel are required and sufficient to fix the poudriere build, so delphij's patch looks good.
I made the same patch. And I guess it should be committed right away as it fixes a build.
(In reply to Juraj Lutter from comment #2) Yes, it should be committed ASAP. py-joblib has 22 direct dependencies, probably at least hundreds of indirect dependencies for which pkg builds are going to fail until this is fixed.
(In reply to Jason W. Bacon from comment #3) I can do the commit if nobody else wants to. Let's just coordinate here to avoid a collision.
According to https://wiki.freebsd.org/Python/setuptools we can use ${PY_SETUPTOOLS} for dependency on setuptools. I'm currently building it in poudriere with: BUILD_DEPENDS= ${PY_SETUPTOOLS} \ ${PYTHON_PKGNAMEPREFIX}wheel>=0:devel/py-wheel@${PY_FLAVOR}
(In reply to Einar Bjarni Halldórsson from comment #5) Good catch. ${PY_SETUPTOOLS} worked fine in my poudriere tests. I'm guessing there's a bulk change coming soon anyway, but I think it's a good idea to go with the newer standard here.
(In reply to Jason W. Bacon from comment #4) The maintainer has not responded yet. IMHO, since this is a build fix, you can commit without approval.
(In reply to Vladimir Druzenko from comment #7) Agreed, I was just about to.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=0b1ab7cf4c4dfce99f8a60e7eb37798a7a6b6559 commit 0b1ab7cf4c4dfce99f8a60e7eb37798a7a6b6559 Author: Jason W. Bacon <jwb@FreeBSD.org> AuthorDate: 2025-06-11 14:01:15 +0000 Commit: Jason W. Bacon <jwb@FreeBSD.org> CommitDate: 2025-06-11 14:11:11 +0000 devel/py-joblib: Unbreak build Missing setuptools and wheel dependencies since 1.5.1 update Also alphabetize USE_PYTHON PR: 287286 Reported by: delphij Reviewed by: otis, vvd, einar@isnic.is Tested by: jwb Approved by: blanket (build fix, maintainer timeout) Fixes: 0d65e1ba4c18 devel/py-joblib: update to v1.5.1 devel/py-joblib/Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Thanks for taking care of this. I was pretty sure I committed a fix but I just looked at the checkout and realized I never actually pushed the change. apologies for all the grief it caused