Bug 287287 - math/cgal: missing needed include for boost 1.88
Summary: math/cgal: missing needed include for boost 1.88
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Wen Heping
URL:
Keywords:
: 286742 (view as bug list)
Depends on:
Blocks:
 
Reported: 2025-06-04 01:48 UTC by Edward.Sanford.Sutton, III
Modified: 2025-06-05 22:08 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (wen)


Attachments
add missing boost include, bump PORTREVESION (1.05 KB, patch)
2025-06-04 01:48 UTC, Edward.Sanford.Sutton, III
no flags Details | Diff
add missing boost include, bump PORTREVESION (970 bytes, patch)
2025-06-04 09:28 UTC, Edward.Sanford.Sutton, III
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Edward.Sanford.Sutton, III 2025-06-04 01:48:57 UTC
Created attachment 260955 [details]
add missing boost include, bump PORTREVESION

Build issues on stable/14 (commit 5c10e8eae0f0) in graphics/colmap (I assume bug # 286742) and cad/PrusaSlicer are resolved with upstream patch https://github.com/CGAL/cgal/commit/138b06ca1188c9aaa734801cdda7f7a6cac54602 that is intended to become 5.6.3. I am not sure but assumed PORTREVISION needs to be bumped. I don't have compatible video drivers on this machine for PrusaSlicer and still finding further build errors for colmap so they have not been run-tested. Both ports are prone to the same build error without the fix:

In file included from /usr/local/include/CGAL/basic.h:28:p
In file included from /usr/local/include/CGAL/number_type_basic.h:51:
In file included from /usr/local/include/CGAL/double.h:22:
/usr/local/include/CGAL/number_utils.h:197:22: error: no type named 'if_c' in namespace 'boost::mpl'
197 | typename boost::mpl::if_c<
| ~~~~~~~~~~~~~~~~~~~~~^~~~
Comment 1 Edward.Sanford.Sutton, III 2025-06-04 09:28:59 UTC
Created attachment 260962 [details]
add missing boost include, bump PORTREVESION

Accidentally deleted a blank line in Makefile; fixed with this patch.
Comment 2 commit-hook freebsd_committer freebsd_triage 2025-06-05 00:24:44 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7df85a640e2ebcc76848bab804554d4eccd75ccf

commit 7df85a640e2ebcc76848bab804554d4eccd75ccf
Author:     Edward.Sanford.Sutton, III <mirror176@hotmail.com>
AuthorDate: 2025-06-04 07:02:27 +0000
Commit:     Wen Heping <wen@FreeBSD.org>
CommitDate: 2025-06-05 00:21:42 +0000

    math/cgal: Add missing needed include for boost

    PR:             287287
    Reported by:    Edward.Sanford.Sutton, III <mirror176@hotmail.com>

 math/cgal/Makefile                                       |  2 +-
 math/cgal/files/patch-include_CGAL_number__utils.h (new) | 10 ++++++++++
 2 files changed, 11 insertions(+), 1 deletion(-)
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2025-06-05 22:08:38 UTC
*** Bug 286742 has been marked as a duplicate of this bug. ***