Bug 287309 - x11-clocks/tclock: Take maintainership
Summary: x11-clocks/tclock: Take maintainership
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Hiroki Tagato
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-06-04 23:17 UTC by mew14930xvi
Modified: 2025-06-09 08:57 UTC (History)
1 user (show)

See Also:

Attachments
take maintainership (1.09 KB, patch)
2025-06-04 23:17 UTC, mew14930xvi 		no flags Details | Diff
take maintainership (1.13 KB, patch)
2025-06-08 23:26 UTC, mew14930xvi 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mew14930xvi 2025-06-04 23:17:07 UTC 
Created attachment 260987 [details]
take maintainership

Add MASTER_SITES.
Comment 1 Hiroki Tagato freebsd_committer freebsd_triage 2025-06-08 13:13:31 UTC 
Change of maintainer needs port revision bump. Can you amend the patch and resubmit?

See https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-portrevision
Comment 2 mew14930xvi 2025-06-08 23:26:51 UTC 
Created attachment 261100 [details]
take maintainership

I know that's stated, but aren't committers who actually make changes in the minority.
Comment 3 commit-hook freebsd_committer freebsd_triage 2025-06-09 08:52:01 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=51eeb39578cf902834384f00c0fd59b8cae57aae

commit 51eeb39578cf902834384f00c0fd59b8cae57aae
Author:     mew14930xvi <mew14930xvi@inbox.lv>
AuthorDate: 2025-06-08 23:20:59 +0000
Commit:     Hiroki Tagato <tagattie@FreeBSD.org>
CommitDate: 2025-06-09 08:51:30 +0000

    x11-clocks/tclock: take maintainership

    While here:
    - switch to DISTVERSION
    - add another MASTER_SITES
    - add missing USE_XORG=xorgproto
    - reorder variables to make portclippy happy

    PR:             287309
    Reported by:    mew14930xvi <mew14930xvi@inbox.lv> (new maintainer)
    MFH:            2025Q2

 x11-clocks/tclock/Makefile | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2025-06-09 08:54:04 UTC 
A commit in branch 2025Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=780ed934f98fc3585ba55643d4e71531dca6036e

commit 780ed934f98fc3585ba55643d4e71531dca6036e
Author:     mew14930xvi <mew14930xvi@inbox.lv>
AuthorDate: 2025-06-08 23:20:59 +0000
Commit:     Hiroki Tagato <tagattie@FreeBSD.org>
CommitDate: 2025-06-09 08:53:19 +0000

    x11-clocks/tclock: take maintainership

    While here:
    - switch to DISTVERSION
    - add another MASTER_SITES
    - add missing USE_XORG=xorgproto
    - reorder variables to make portclippy happy

    PR:             287309
    Reported by:    mew14930xvi <mew14930xvi@inbox.lv> (new maintainer)
    MFH:            2025Q2

    (cherry picked from commit 51eeb39578cf902834384f00c0fd59b8cae57aae)

 x11-clocks/tclock/Makefile | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)
Comment 5 Hiroki Tagato freebsd_committer freebsd_triage 2025-06-09 08:57:01 UTC 
(In reply to mew14930xvi from comment #2)

As you said, it is documented in the Porter's Handbook, not the Committer's Guide. I would like a porter to prepare a patch in good shape as best as possible.

Thank you for your cooperation and now the changes have been committed.