Bug 287329 - x11/xcb-util-cursor update to 0.1.5
Summary: x11/xcb-util-cursor update to 0.1.5
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-x11 (Nobody)
URL:
Keywords:
Depends on:
Blocks: 280573
  Show dependency treegraph
 
Reported: 2025-06-05 20:29 UTC by Jesper Schmitz Mouridsen
Modified: 2025-06-06 17:54 UTC (History)
4 users (show)

See Also:
manu: maintainer-feedback+


Attachments
update to 0.1.5 (3.64 KB, patch)
2025-06-05 20:29 UTC, Jesper Schmitz Mouridsen
no flags Details | Diff
EXTRACT_SFX -> USES tar:xz (3.62 KB, patch)
2025-06-06 13:52 UTC, Jesper Schmitz Mouridsen
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jesper Schmitz Mouridsen freebsd_committer freebsd_triage 2025-06-05 20:29:47 UTC
Created attachment 261014 [details]
update to 0.1.5

Update to 0.1.5
Add an upstream patch which corrects default CURSORPATH.
Add autoreconf since upstream used aclocal-1.16
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2025-06-05 23:01:02 UTC
"EXTRACT_SUFX=.tar.xz" => "USES=tar:xz"?
Comment 2 Jesper Schmitz Mouridsen freebsd_committer freebsd_triage 2025-06-06 13:52:34 UTC
Created attachment 261036 [details]
EXTRACT_SFX -> USES tar:xz



Before:

Function "cursor_path" not defined.
Make breakpoint pending on future shared library load? (y or [n]) y
Breakpoint 1 (cursor_path) pending.
(gdb) r
Starting program: /usr/home/jesper/cursortest6 
[New LWP 109597 of process 66386]
[New LWP 109598 of process 66386]
Loaded themed cursor: hand1

Thread 1 hit Breakpoint 1, cursor_path (c=0x8034106e0) at load_cursor.c:48
48	    if (c->path == NULL) {
(gdb) n
49	        c->path = getenv("XCURSOR_PATH");
(gdb) n
50	        if (c->path == NULL)
(gdb) n
51	            c->path = XCURSORPATH;
(gdb) n
52	    }
(gdb) print c->path
$1 = 0x8031c0ea0 "~/.icons:/usr/share/icons:/usr/share/pixmaps:/usr/X11R6/lib/X11/icons"

After:
Reading symbols from ./cursortest6...
(gdb) b cursor_path
Function "cursor_path" not defined.
Make breakpoint pending on future shared library load? (y or [n]) y
Breakpoint 1 (cursor_path) pending.
(gdb) r
Starting program: /usr/home/jesper/cursortest6 
[New LWP 109816 of process 69865]
[New LWP 109817 of process 69865]
Loaded themed cursor: hand1

Thread 1 hit Breakpoint 1, cursor_path (c=0x8034106e0) at load_cursor.c:55
55	    if (c->path == NULL) {
(gdb) n
56	        c->path = getenv("XCURSOR_PATH");
(gdb) n
57	        if (c->path == NULL)
(gdb) n
58	            c->path = XCURSORPATH;
(gdb) n
59	    }
(gdb) print c->path
$1 = 0x8031c0bf1 "~/.local/share/icons:~/.icons:/usr/local/share/icons:/usr/local/share/pixmaps"
Comment 3 Vladimir Druzenko freebsd_committer freebsd_triage 2025-06-06 14:03:49 UTC
[17:13] bsdimp: x11 has stated that you don't even need to wait for the timeout period if it's been built and tested.

AFAIU, you can commit it with "Approved by: x11 (maintainer, implicit)".
Comment 4 Emmanuel Vadot freebsd_committer freebsd_triage 2025-06-06 15:43:59 UTC
(In reply to Vladimir Druzenko from comment #3)

Since I'm the only one in x11@ I'm surprised by this statement as I've never said that.
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2025-06-06 15:54:33 UTC
(In reply to Emmanuel Vadot from comment #4)
Hm…
Sorry for spreading false information. It was just copy&paste.

Offtopic: I'm thinking of doing these PR: https://bugs.freebsd.org/bugzilla/buglist.cgi?bug_status=__open__&email2=mew14930xvi%40inbox.lv&emailreporter2=1&short_desc=x11%2F&short_desc_type=allwordssubstr
Comment 6 Emmanuel Vadot freebsd_committer freebsd_triage 2025-06-06 16:08:06 UTC
(In reply to Vladimir Druzenko from comment #5)

I need to find some time to review all those but if you could take a look at some that would be great.
For all the update pkg-descr if the patch is fine you have my blessing to commit them.
Comment 7 Daniel Engberg freebsd_committer freebsd_triage 2025-06-06 16:16:00 UTC
(In reply to Emmanuel Vadot from comment #6)
There was an announcement (mail) on 2023-08-10

"Opening the gates on x11@ ports

x11@ is looking for more people to help maintain its ports. Most of the xorg 
ecosystem is in a maintenance phase, which does not require the restrictive 
maintainership clause of the past.

So if you see an x11@ port that is out of date, or see an improvement that 
could be made to it, please prepare a patch and give x11@ a heads-up of the 
upcoming change. If you don't here anything negative back within a week, 
please feel free to land it with an implicit approval."
Comment 8 Emmanuel Vadot freebsd_committer freebsd_triage 2025-06-06 16:26:08 UTC
(In reply to Daniel Engberg from comment #7)

Which isn't the same as what imp@ allegedly said.
Comment 9 Warner Losh freebsd_committer freebsd_triage 2025-06-06 17:53:52 UTC
I did say it, but I conveyed the wrong meaning, so go with the email, not the imperfect recollection of the email...
Comment 10 Warner Losh freebsd_committer freebsd_triage 2025-06-06 17:54:49 UTC
(In reply to Warner Losh from comment #9)

Or even further, newer modifications that manu@ wants.