Bug 287391 - textproc/libxml2: security patches for 2.11.9
Summary: textproc/libxml2: security patches for 2.11.9
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-desktop (Team)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-06-09 03:48 UTC by SASAKI Katuhiro
Modified: 2025-06-15 02:31 UTC (History)
14 users (show)

See Also:
vishwin: maintainer-feedback+


Attachments
Patch for textproc/libxml2 (5.19 KB, patch)
2025-06-09 03:48 UTC, SASAKI Katuhiro
no flags Details | Diff
libxml2.diff (5.17 KB, patch)
2025-06-10 13:39 UTC, Mark Linimon
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description SASAKI Katuhiro 2025-06-09 03:48:41 UTC
Created attachment 261105 [details]
Patch for textproc/libxml2

I've created a patch to apply to "textproc/libxml2" that incorporates
the fixes for CVE-2024-56171, CVE-2025-24928, and CVE-2025-32414, which
I obtained from "https://github.com/GNOME/libxml2".
Could you please review it?
Comment 1 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2025-06-10 08:24:34 UTC
Aloha freebsd-desktop team,

can I support you in any way, to update libxml2 or to check, if these patches are fine?

Best,
tz (with ports-sec-hat)
Comment 2 Michael Osipov freebsd_committer freebsd_triage 2025-06-10 08:52:04 UTC
Apply to quarterly as well, please.
Comment 3 Max Brazhnikov freebsd_committer freebsd_triage 2025-06-10 10:14:14 UTC
(In reply to Torsten Zuehlsdorff from comment #1)
yes, please!
Comment 4 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2025-06-10 12:32:32 UTC
(In reply to Max Brazhnikov from comment #3)

> yes, please!

How can i support you best?
Comment 5 Mark Linimon freebsd_committer freebsd_triage 2025-06-10 13:39:46 UTC
Created attachment 261145 [details]
libxml2.diff

^Triage: rebase patch.
Comment 6 Daniel Engberg freebsd_committer freebsd_triage 2025-06-10 16:55:08 UTC
As someone who has been trying to push a version that is supported upstream I'm not too fond of this idea. 2.11 branch is dead and unsupported upstream, there have been many changes to internal code between 2.11 - 2.14 so I would suggest that further investigation needs to be done to ensure that functionality is retained as intended and there are more CVEs but I didn't list all in VuXML.

https://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=libxml2

These are new and fixes have been committed upstream
https://gitlab.gnome.org/GNOME/libxml2/-/issues/932
https://gitlab.gnome.org/GNOME/libxml2/-/issues/931
https://gitlab.gnome.org/GNOME/libxml2/-/issues/933

We do have a pretty much final version (PR 279705) however there are a few fallouts left. In case you're wondering about why there are two versions, the CMake version has been used for testing pretty much the whole time including fixing PRs except for the last exp-run (which is pretty much identical the previous one). The current also includes upstream commits (various bug fixes etc) which are to be included in next release for 2.14 branch which the other version lacks. Charlie is only one blocking it (so if you want to get it going I'd suggest you ask portmgr for a final decision, futher testing as it has recieved a lot less testing and evaluation) if we are go that route.
Comment 7 Charlie Li freebsd_committer freebsd_triage 2025-06-10 17:30:09 UTC
(In reply to Daniel Engberg from comment #6)
I'm also not fond of this idea for the same and additional reasons. Not only have the internals changed, but starting 2.12, with a compatibility switch that has effectively gone away in 2.14, major (public) API changes happened.

A member of portmgr chimed in over there saying we are going back to autotools. The only blockers anymore are fixing the remaining fallouts, and then the *autotools* version will be committed.