Created attachment 261125 [details] Patch to update emulators/ppsspp to 1.19.1 emulators/ppsspp: update to 1.19.1
Thanks for a submission for port update. A couple of comments: - Can you add LICENSE_FILE? The source archive contains a license file (LICENSE.TXT). - According to LICENSE.TXT, some files are licensed under BSD 3 Clause. So I would suggest adding BSD3CLAUSE to LICENSE. The other part of the port looks good to me.
Created attachment 261184 [details] Patch to update emulators/ppsspp to 1.19.1, fix vulkan graphics backend hang emulators/ppsspp: * Update to 1.19.1. * Fix hang when using vulkan graphics backend. This is due to FreeBSD mesa- ports, currently on version 24, only supporting vulkan api version 1.3. * Add LICENSE_FILE and BSD3CLAUSE to LICENSE Changelog: https://www.ppsspp.org/news/release-1.19/
(In reply to Kevin Reinholz from comment #2) Fetching manpage file fails: =======================<phase: fetch >============================ ===== env: DEVELOPER_MODE=yes STRICT_DEPENDS=yes USER=root UID=0 GID=0 ===> License BSD3CLAUSE GPLv2+ accepted by the user ===> ppsspp-1.19.1 depends on file: /usr/local/sbin/pkg - found => ppsspp.1 doesn't seem to exist in /portdistfiles/. => Attempting to fetch https://bazaar.launchpad.net/~sergio-br2/ppsspp/debian-sdl/download/5/ppsspp.1-20140802045408-dd26dik367ztj5xg-8/ppsspp.1 fetch: https://bazaar.launchpad.net/~sergio-br2/ppsspp/debian-sdl/download/5/ppsspp.1-20140802045408-dd26dik367ztj5xg-8/ppsspp.1: Not Found => Couldn't fetch it - please try to retrieve this => port manually into /portdistfiles/ and try again. *** Error code 1 Stop. Can you check the URL and update the patch? In addition, LICENSE_COMB should be "multi" instead of "dual" in this case.
Created attachment 261215 [details] Patch to update emulators/ppsspp to 1.19.1, fix vulkan graphics backend hang and other minor cleanup Updated patch: removed 2014 Debian man page. The fetch link for the man page is broken. There's no longer a ppsspp package for Debian. Set LICENSE_COMB to multi.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=67e9480101171049732ea3e763f8e867d5aed7dd commit 67e9480101171049732ea3e763f8e867d5aed7dd Author: Kevin Reinholz <kreinholz@gmail.com> AuthorDate: 2025-06-12 23:50:01 +0000 Commit: Hiroki Tagato <tagattie@FreeBSD.org> CommitDate: 2025-06-13 07:18:10 +0000 emulators/ppsspp: update to 1.19.1 While here: - fix hang when using vulkan graphics backend. This is due to FreeBSD mesa- ports, currently on version 24, only supporting vulkan api version 1.3. - add BSD3CLAUSE to LICENSE and LICENSE_FILE. - remove defunct 2014 Debian man page. The fetch link for the man page is broken. There's no longer a ppsspp package for Debian. Changelog: https://www.ppsspp.org/news/release-1.19/ PR: 287409 Reported by: Kevin Reinholz <kreinholz@gmail.com> (maintainer) emulators/ppsspp/Makefile | 13 +++++-------- emulators/ppsspp/distinfo | 8 +++----- .../files/patch-Common_GPU_Vulkan_VulkanContext.cpp (new) | 11 +++++++++++ emulators/ppsspp/pkg-plist | 1 - 4 files changed, 19 insertions(+), 14 deletions(-)
Committed, thanks!