The root password dialog shows Password [ ] Repeat password [ ] Typing in the password and pressing Enter selects the OK button and reports that the passwords do not match. Tab switches focus to the OK / Skip buttons. The down key needs to be pressed to get to the Repeat password field.
This is also true in other bsdinstall dialogs, I'm always pressing Enter on static IPv4 address configuration page after entering the address and have to redo it later.
For what it's worth, I instinctively used the Tab key. Using the down key was trial-and-error.
Ok, I changed the default behavior of the forms and the --switch-buttons option for the forms, to provide two possibilities. To test: % git clone https://gitlab.com/alfix/bsddialog.git % cd bsddialog % make Case 1: --switch-buttons ./bsddialog --switch-buttons --form test 0 0 0 Input1 0 0 "xxx" 0 7 30 50 Input2 1 0 "xxx" 1 7 30 50 TAB and ENTER have been added as navigation keys. The form can be fully navigated by repeatedly pressing TAB. Pressing ENTER moves the focus to the next input field; after the last field (the second, Input2, one in this case), focus shifts to the buttons (e.g., [OK]). At that point, pressing ENTER will close the form. Case 2: Forms default behavior ./bsddialog --form test 0 0 0 Input1 0 0 "xxx" 0 7 30 50 Input2 1 0 "xxx" 1 7 30 50 The form can be fully navigated by repeatedly pressing TAB. Pressing ENTER immediately closes the form because the buttons below are always active. This default behavior was implemented based on a request I received a few years ago. If these changes meet the requirements, I can run a make world on my laptop over the weekend and import the new version.
New functionality makes sense to me. Found some odd behaviour though: - run the ./bsddialog command in comment 3 - press Tab-Tab-Tab-Tab (so cursor cycles through and ends on Input1 field - type test; observe no characters are printed - press Tab - observe Input2 field now reports "testxxx"
Fixed. Thank you for testing and the report. I’ll try to import the updated version this weekend or as soon as possible.
*** Bug 289910 has been marked as a duplicate of this bug. ***
Added as a 15.0 issue to https://wiki.freebsd.org/Releng/15.0ISSUES
Thank you for the reminder. This week I will import a new bsddialog version that will fix the PR, also because the new version is needed to finalize the GoSC project.
A commit in branch vendor/bsddialog references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=653f765f05b8c7e3908ae92e9bf61522a50cefc9 commit 653f765f05b8c7e3908ae92e9bf61522a50cefc9 Author: Alfonso S. Siciliano <asiciliano@FreeBSD.org> AuthorDate: 2025-10-09 15:31:26 +0000 Commit: Alfonso S. Siciliano <asiciliano@FreeBSD.org> CommitDate: 2025-10-09 15:31:26 +0000 contrib/bsddialog: Import version 1.0.5 Version for change and feature requests. * Improve documentation for --alternate-screen and --normal-screen. Request: https://bugs.freebsd.org/285459. (This PR is not about bsddialog itself but is used as an example for an official FreeBSD documentation request.) * Reduce the number of screen refreshes to improve performance over a 115200 UART connection. Request: https://gitlab.com/alfix/bsddialog/-/issues/8. * Change textbox buttons to return distinct values (previously always returned OK). Request: https://reviews.freebsd.org/D48668; already committed in contrib/ 96a241a35905078bdc5d20bf25943cdb67758dea * Change forms navigation key behavior for ENTER and TAB. Request: https://bugs.freebsd.org/287592. Refer to /usr/src/contrib/bsddialog/CHANGELOG to know more. PR: 287592 Reported by: adrian Sponsored by: The FreeBSD Foundation .gitignore | 1 + CHANGELOG | 50 ++++++++++++++++++++++++++++-- LICENSE | 2 +- Makefile | 13 ++++++-- README.md | 5 ++- examples_library/compile | 8 +++-- examples_library/textbox.c (new) | 38 +++++++++++++++++++++++ lib/GNUmakefile | 19 +++++++++++- lib/Makefile | 21 ++++++++++++- lib/barbox.c | 37 +++++++++++----------- lib/bsddialog.3 | 16 +++++++--- lib/bsddialog.h | 5 +-- lib/bsddialog_theme.h | 2 +- lib/datebox.c | 28 ++++++++--------- lib/formbox.c | 48 ++++++++++++++++++++--------- lib/lib_util.c | 3 +- lib/lib_util.h | 4 +-- lib/libbsddialog.c | 14 +++++++-- lib/menubox.c | 18 +++++------ lib/messagebox.c | 16 +++++----- lib/textbox.c | 18 +++++------ lib/theme.c | 6 ++-- lib/timebox.c | 16 +++++----- utility/GNUmakefile | 11 ++++++- utility/Makefile | 11 ++++++- utility/bsddialog.1 | 21 ++++++++++--- utility/bsddialog.c | 2 +- utility/util.h | 2 +- utility/util_builders.c | 66 ++++++++++++++++++++-------------------- utility/util_cli.c | 2 +- utility/util_theme.c | 4 +-- 31 files changed, 354 insertions(+), 153 deletions(-)
The tag vendor/bsddialog/1.0.5 references this bug: URL: https://cgit.FreeBSD.org/src/tag/?h=vendor/bsddialog/1.0.5 tag vendor/bsddialog/1.0.5 Tagger: Alfonso S. Siciliano <asiciliano@FreeBSD.org> TaggerDate: 2025-10-09 15:32:01 +0000 contrib/bsddialog: Import version 1.0.5 Version for change and feature requests. * Improve documentation for --alternate-screen and --normal-screen. Request: https://bugs.freebsd.org/285459. (This PR is not about bsddialog itself but is used as an example for an official FreeBSD documentation request.) * Reduce the number of screen refreshes to improve performance over a 115200 UART connection. Request: https://gitlab.com/alfix/bsddialog/-/issues/8. * Change textbox buttons to return distinct values (previously always returned OK). Request: https://reviews.freebsd.org/D48668; already committed in contrib/ 96a241a35905078bdc5d20bf25943cdb67758dea * Change forms navigation key behavior for ENTER and TAB. Request: https://bugs.freebsd.org/287592. Refer to /usr/src/contrib/bsddialog/CHANGELOG to know more. PR: 287592 Reported by: adrian Sponsored by: The FreeBSD Foundation -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEE7PRC2fzW39CS7j0J4Jx+sedxxcgFAmjn1X4ACgkQ4Jx+sedx xcgvZggAseOgTLJG8otrHj+V/liqFwpn0q0zajO64PtpqyjOBT6K3hGzKjwDGPz9 +lCPY1tpw82zS1iwJvaMK+17NSCjlo6nuniSq6DxLo7d8et3w9CAfp/i+YGEBx+1 /KRpMhoH0wZ/WlqKy+MXB3SZfyDSKmwyohaM7oKK/YGecVqFUygsTKJhFOHyd4Br qeVvywrhKVuXizmOG8sdYqKUF9mPQaltO6+UhGls6pXD1MtlYj16it3mu6pQmeIy bohhPfQlMAruuGwi8tgQTbNBahiWiW1ng1VURjccloIJIZtozBZpFPGyQkPucGWS ep7xOUTy3Dt52Rhf3sZfwRbil8+eHA== =crin -----END PGP SIGNATURE----- commit 653f765f05b8c7e3908ae92e9bf61522a50cefc9 Author: Alfonso S. Siciliano <asiciliano@FreeBSD.org> AuthorDate: 2025-10-09 15:31:26 +0000 Commit: Alfonso S. Siciliano <asiciliano@FreeBSD.org> CommitDate: 2025-10-09 15:31:26 +0000 contrib/bsddialog: Import version 1.0.5 Version for change and feature requests. * Improve documentation for --alternate-screen and --normal-screen. Request: https://bugs.freebsd.org/285459. (This PR is not about bsddialog itself but is used as an example for an official FreeBSD documentation request.) * Reduce the number of screen refreshes to improve performance over a 115200 UART connection. Request: https://gitlab.com/alfix/bsddialog/-/issues/8. * Change textbox buttons to return distinct values (previously always returned OK). Request: https://reviews.freebsd.org/D48668; already committed in contrib/ 96a241a35905078bdc5d20bf25943cdb67758dea * Change forms navigation key behavior for ENTER and TAB. Request: https://bugs.freebsd.org/287592. Refer to /usr/src/contrib/bsddialog/CHANGELOG to know more. PR: 287592 Reported by: adrian Sponsored by: The FreeBSD Foundation .gitignore | 1 + CHANGELOG | 50 ++++++++++++++++++++++++++++-- LICENSE | 2 +- Makefile | 13 ++++++-- README.md | 5 ++- examples_library/compile | 8 +++-- examples_library/textbox.c (new) | 38 +++++++++++++++++++++++ lib/GNUmakefile | 19 +++++++++++- lib/Makefile | 21 ++++++++++++- lib/barbox.c | 37 +++++++++++----------- lib/bsddialog.3 | 16 +++++++--- lib/bsddialog.h | 5 +-- lib/bsddialog_theme.h | 2 +- lib/datebox.c | 28 ++++++++--------- lib/formbox.c | 48 ++++++++++++++++++++--------- lib/lib_util.c | 3 +- lib/lib_util.h | 4 +-- lib/libbsddialog.c | 14 +++++++-- lib/menubox.c | 18 +++++------ lib/messagebox.c | 16 +++++----- lib/textbox.c | 18 +++++------ lib/theme.c | 6 ++-- lib/timebox.c | 16 +++++----- utility/GNUmakefile | 11 ++++++- utility/Makefile | 11 ++++++- utility/bsddialog.1 | 21 ++++++++++--- utility/bsddialog.c | 2 +- utility/util.h | 2 +- utility/util_builders.c | 66 ++++++++++++++++++++-------------------- utility/util_cli.c | 2 +- utility/util_theme.c | 4 +-- 31 files changed, 354 insertions(+), 153 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3e42d7194bdcd4fbfd781518258f919d6ac803d3 commit 3e42d7194bdcd4fbfd781518258f919d6ac803d3 Merge: a28b44ddc348 653f765f05b8 Author: Alfonso S. Siciliano <asiciliano@FreeBSD.org> AuthorDate: 2025-10-09 15:39:10 +0000 Commit: Alfonso S. Siciliano <asiciliano@FreeBSD.org> CommitDate: 2025-10-09 15:39:10 +0000 contrib/bsddialog: Import version 1.0.5 Version for change and feature requests. * Improve documentation for --alternate-screen and --normal-screen. Request: https://bugs.freebsd.org/285459. (This PR is not about bsddialog itself but is used as an example for an official FreeBSD documentation request.) * Reduce the number of screen refreshes to improve performance over a 115200 UART connection. Request: https://gitlab.com/alfix/bsddialog/-/issues/8. * Change textbox buttons to return distinct values (previously always returned OK). Request: https://reviews.freebsd.org/D48668; already committed in contrib/ 96a241a35905078bdc5d20bf25943cdb67758dea * Change forms navigation key behavior for ENTER and TAB. Request: https://bugs.freebsd.org/287592. Refer to /usr/src/contrib/bsddialog/CHANGELOG to know more. PR: 287592 Reported by: adrian Sponsored by: The FreeBSD Foundation Merge commit '653f765f05b8c7e3908ae92e9bf61522a50cefc9' into YYY contrib/bsddialog/.gitignore | 1 + contrib/bsddialog/CHANGELOG | 50 +++++++++++++++- contrib/bsddialog/LICENSE | 2 +- contrib/bsddialog/Makefile | 13 ++++- contrib/bsddialog/README.md | 5 +- contrib/bsddialog/examples_library/compile | 8 ++- contrib/bsddialog/examples_library/textbox.c (new) | 38 +++++++++++++ contrib/bsddialog/lib/GNUmakefile | 19 ++++++- contrib/bsddialog/lib/Makefile | 21 ++++++- contrib/bsddialog/lib/barbox.c | 37 ++++++------ contrib/bsddialog/lib/bsddialog.3 | 16 ++++-- contrib/bsddialog/lib/bsddialog.h | 5 +- contrib/bsddialog/lib/bsddialog_theme.h | 2 +- contrib/bsddialog/lib/datebox.c | 28 ++++----- contrib/bsddialog/lib/formbox.c | 48 +++++++++++----- contrib/bsddialog/lib/lib_util.c | 3 +- contrib/bsddialog/lib/lib_util.h | 4 +- contrib/bsddialog/lib/libbsddialog.c | 14 ++++- contrib/bsddialog/lib/menubox.c | 18 +++--- contrib/bsddialog/lib/messagebox.c | 16 +++--- contrib/bsddialog/lib/textbox.c | 16 +++--- contrib/bsddialog/lib/theme.c | 6 +- contrib/bsddialog/lib/timebox.c | 16 +++--- contrib/bsddialog/utility/GNUmakefile | 11 +++- contrib/bsddialog/utility/Makefile | 11 +++- contrib/bsddialog/utility/bsddialog.1 | 21 +++++-- contrib/bsddialog/utility/bsddialog.c | 2 +- contrib/bsddialog/utility/util.h | 2 +- contrib/bsddialog/utility/util_builders.c | 66 +++++++++++----------- contrib/bsddialog/utility/util_cli.c | 2 +- contrib/bsddialog/utility/util_theme.c | 4 +- 31 files changed, 353 insertions(+), 152 deletions(-)
Can this be merged to stable/15 soon so it can land in 15.0?
Ok, we can merge to STABLE. Anyway, the version in STABLE is very old (0.4). This CURRENT version is 1.0.4. Probably all the TUI utilities need to be updated, and in particular all the bsdinstall screens need to be tested. Also, some utilities in STABLE still use LGPL-dialog, certainly bsdconfig, so we could finish the replacement in STABLE and disabling LGPL-dialog. Does it seem feasible to you? How much time is available?
> Probably all the TUI utilities need to be updated, Ok, that's not feasible. If this is going into 15.0 it needs to be there by the end of the month. If we can't fix the "set root password" dialog without changing a bunch of other stuff at the same time, it's going to have to stay nonintuitive for 15.0.
My mistake, I confused stable/14 with 15, sorry. Stable 15 and Releng 15 have bsddialog 1.0.4, so we can MFC this bsddialog version (1.0.5).
Ok, in that case we need it to land... well, yesterday would have been good, but I'll take today. Or maybe tomorrow. Anyway, ASAP if we're going to get it into 15.0-RELEASE.
A commit in branch stable/15 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=aa2fe36f5e4b3b907af2ea94945ae9cab7263d0c commit aa2fe36f5e4b3b907af2ea94945ae9cab7263d0c Author: Alfonso S. Siciliano <asiciliano@FreeBSD.org> AuthorDate: 2025-10-09 15:39:10 +0000 Commit: Alfonso S. Siciliano <asiciliano@FreeBSD.org> CommitDate: 2025-11-04 18:26:44 +0000 contrib/bsddialog: Import version 1.0.5 Version for change and feature requests. * Improve documentation for --alternate-screen and --normal-screen. Request: https://bugs.freebsd.org/285459. (This PR is not about bsddialog itself but is used as an example for an official FreeBSD documentation request.) * Reduce the number of screen refreshes to improve performance over a 115200 UART connection. Request: https://gitlab.com/alfix/bsddialog/-/issues/8. * Change textbox buttons to return distinct values (previously always returned OK). Request: https://reviews.freebsd.org/D48668; already committed in contrib/ 96a241a35905078bdc5d20bf25943cdb67758dea * Change forms navigation key behavior for ENTER and TAB. Request: https://bugs.freebsd.org/287592. Refer to /usr/src/contrib/bsddialog/CHANGELOG to know more. PR: 287592 Reported by: adrian Sponsored by: The FreeBSD Foundation Merge commit '653f765f05b8c7e3908ae92e9bf61522a50cefc9' into YYY (cherry picked from commit 3e42d7194bdcd4fbfd781518258f919d6ac803d3) contrib/bsddialog/.gitignore | 1 + contrib/bsddialog/CHANGELOG | 50 +++++++++++++++- contrib/bsddialog/LICENSE | 2 +- contrib/bsddialog/Makefile | 13 ++++- contrib/bsddialog/README.md | 5 +- contrib/bsddialog/examples_library/compile | 8 ++- contrib/bsddialog/examples_library/textbox.c (new) | 38 +++++++++++++ contrib/bsddialog/lib/GNUmakefile | 19 ++++++- contrib/bsddialog/lib/Makefile | 21 ++++++- contrib/bsddialog/lib/barbox.c | 37 ++++++------ contrib/bsddialog/lib/bsddialog.3 | 16 ++++-- contrib/bsddialog/lib/bsddialog.h | 5 +- contrib/bsddialog/lib/bsddialog_theme.h | 2 +- contrib/bsddialog/lib/datebox.c | 28 ++++----- contrib/bsddialog/lib/formbox.c | 48 +++++++++++----- contrib/bsddialog/lib/lib_util.c | 3 +- contrib/bsddialog/lib/lib_util.h | 4 +- contrib/bsddialog/lib/libbsddialog.c | 14 ++++- contrib/bsddialog/lib/menubox.c | 18 +++--- contrib/bsddialog/lib/messagebox.c | 16 +++--- contrib/bsddialog/lib/textbox.c | 16 +++--- contrib/bsddialog/lib/theme.c | 6 +- contrib/bsddialog/lib/timebox.c | 16 +++--- contrib/bsddialog/utility/GNUmakefile | 11 +++- contrib/bsddialog/utility/Makefile | 11 +++- contrib/bsddialog/utility/bsddialog.1 | 21 +++++-- contrib/bsddialog/utility/bsddialog.c | 2 +- contrib/bsddialog/utility/util.h | 2 +- contrib/bsddialog/utility/util_builders.c | 66 +++++++++++----------- contrib/bsddialog/utility/util_cli.c | 2 +- contrib/bsddialog/utility/util_theme.c | 4 +- 31 files changed, 353 insertions(+), 152 deletions(-)
A commit in branch releng/15.0 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=0595e10ec77383a3038c45fbd9fcdb6922c971fe commit 0595e10ec77383a3038c45fbd9fcdb6922c971fe Author: Alfonso S. Siciliano <asiciliano@FreeBSD.org> AuthorDate: 2025-10-09 15:39:10 +0000 Commit: Alfonso S. Siciliano <asiciliano@FreeBSD.org> CommitDate: 2025-11-04 18:30:32 +0000 contrib/bsddialog: Import version 1.0.5 Version for change and feature requests. * Improve documentation for --alternate-screen and --normal-screen. Request: https://bugs.freebsd.org/285459. (This PR is not about bsddialog itself but is used as an example for an official FreeBSD documentation request.) * Reduce the number of screen refreshes to improve performance over a 115200 UART connection. Request: https://gitlab.com/alfix/bsddialog/-/issues/8. * Change textbox buttons to return distinct values (previously always returned OK). Request: https://reviews.freebsd.org/D48668; already committed in contrib/ 96a241a35905078bdc5d20bf25943cdb67758dea * Change forms navigation key behavior for ENTER and TAB. Request: https://bugs.freebsd.org/287592. Refer to /usr/src/contrib/bsddialog/CHANGELOG to know more. PR: 287592 Reported by: adrian Approved by: re (cperciva) Sponsored by: The FreeBSD Foundation Merge commit '653f765f05b8c7e3908ae92e9bf61522a50cefc9' into YYY (cherry picked from commit 3e42d7194bdcd4fbfd781518258f919d6ac803d3) (cherry picked from commit aa2fe36f5e4b3b907af2ea94945ae9cab7263d0c) contrib/bsddialog/.gitignore | 1 + contrib/bsddialog/CHANGELOG | 50 +++++++++++++++- contrib/bsddialog/LICENSE | 2 +- contrib/bsddialog/Makefile | 13 ++++- contrib/bsddialog/README.md | 5 +- contrib/bsddialog/examples_library/compile | 8 ++- contrib/bsddialog/examples_library/textbox.c (new) | 38 +++++++++++++ contrib/bsddialog/lib/GNUmakefile | 19 ++++++- contrib/bsddialog/lib/Makefile | 21 ++++++- contrib/bsddialog/lib/barbox.c | 37 ++++++------ contrib/bsddialog/lib/bsddialog.3 | 16 ++++-- contrib/bsddialog/lib/bsddialog.h | 5 +- contrib/bsddialog/lib/bsddialog_theme.h | 2 +- contrib/bsddialog/lib/datebox.c | 28 ++++----- contrib/bsddialog/lib/formbox.c | 48 +++++++++++----- contrib/bsddialog/lib/lib_util.c | 3 +- contrib/bsddialog/lib/lib_util.h | 4 +- contrib/bsddialog/lib/libbsddialog.c | 14 ++++- contrib/bsddialog/lib/menubox.c | 18 +++--- contrib/bsddialog/lib/messagebox.c | 16 +++--- contrib/bsddialog/lib/textbox.c | 16 +++--- contrib/bsddialog/lib/theme.c | 6 +- contrib/bsddialog/lib/timebox.c | 16 +++--- contrib/bsddialog/utility/GNUmakefile | 11 +++- contrib/bsddialog/utility/Makefile | 11 +++- contrib/bsddialog/utility/bsddialog.1 | 21 +++++-- contrib/bsddialog/utility/bsddialog.c | 2 +- contrib/bsddialog/utility/util.h | 2 +- contrib/bsddialog/utility/util_builders.c | 66 +++++++++++----------- contrib/bsddialog/utility/util_cli.c | 2 +- contrib/bsddialog/utility/util_theme.c | 4 +- 31 files changed, 353 insertions(+), 152 deletions(-)
Done, this is my first MFC. Please feel free to fix or to revert anything.