Bug 287756 - devel/jsonnet: update to 0.21.0
Summary: devel/jsonnet: update to 0.21.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL: https://github.com/google/jsonnet/rel...
Keywords:
Depends on: 287840
Blocks: 287760
  Show dependency tree / graph
 
Reported: 2025-06-23 23:40 UTC by Pavel Timofeev
Modified: 2025-09-04 23:30 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (gasol.wu)


Attachments
port patch (3.50 KB, patch)
2025-06-23 23:40 UTC, Pavel Timofeev
no flags Details | Diff
port patch rev 2 (3.04 KB, patch)
2025-06-26 18:27 UTC, Pavel Timofeev
no flags Details | Diff
v1 (5.54 KB, patch)
2025-07-26 13:15 UTC, Vladimir Druzenko
vvd: maintainer-approval?
Details | Diff
testport output (54.96 KB, text/plain)
2025-09-04 14:38 UTC, Gasol Wu
gasol.wu: maintainer-approval+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Timofeev 2025-06-23 23:40:44 UTC
Created attachment 261520 [details]
port patch

- update to v0.21.0
- remove devel/rapidyaml dependency and corresponding patch to make this port build the bundled one.
  This is done because of version mismatch: ports tree currenly has 0.3.0 while 0.5.0 is needed at least.
- update plist
Comment 1 Pavel Timofeev 2025-06-23 23:43:46 UTC
forgot to add this one
- remove upstreamed part from files/patch-core_vm.cpp
Comment 2 Pavel Timofeev 2025-06-24 04:15:26 UTC
WARNING! Has dependents https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=287760
Comment 3 Gasol Wu 2025-06-24 16:04:59 UTC
I’m curious why not just upgrade devel/rapidyaml instead? Is there any particular reason for avoiding that approach?
Comment 4 Pavel Timofeev 2025-06-24 16:09:11 UTC
(In reply to Gasol Wu from comment #3)
Oh, I didn't see you're the maintainer of devel/rapidyaml as well.
So I just thought it would be easier to contact with less.
But anyway, I'll look at devel/rapidyaml update.
Comment 5 Pavel Timofeev 2025-06-26 18:27:00 UTC
Created attachment 261643 [details]
port patch rev 2

Ok, here it is.
Comment 6 Pavel Timofeev 2025-06-26 18:28:16 UTC
(In reply to Pavel Timofeev from comment #5)
- update to v0.21.0
- remove fix for json.hpp include in files/patch-core_vm.cpp as it is upstreamed
- regenerate patch-CMakeLists.txt against current source code
- update plist
Comment 7 Vladimir Druzenko freebsd_committer freebsd_triage 2025-07-26 13:15:43 UTC
Created attachment 262438 [details]
v1

Please test the port in runtime with this patch.
Comment 8 Vladimir Druzenko freebsd_committer freebsd_triage 2025-09-03 16:42:58 UTC
Friendly ping!
Or maintainer timeout 1 month?
Comment 9 Gasol Wu 2025-09-04 14:38:10 UTC
Created attachment 263486 [details]
testport output

lgtm


```
$ pkg info | egrep 'c4core|rapid|jsonnet'
c4core-0.2.6                   Library of low-level C++ utilities
jsonnet-0.21.0                 JSON data templating language
rapidyaml-0.9.0                Library to parse and emit YAML
```
Comment 10 commit-hook freebsd_committer freebsd_triage 2025-09-04 23:15:49 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9b010c8152f7638f18064a50d6178ca23a8d361b

commit 9b010c8152f7638f18064a50d6178ca23a8d361b
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2025-09-04 23:02:34 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2025-09-04 23:14:25 +0000

    devel/jsonnet: Update 0.20.0 => 0.21.0

    Changelog:
    https://github.com/google/jsonnet/releases/tag/v0.21.0

    - Replace the bundled rapidyaml hpp file with a newer one for
      compatibility with devel/rapidyaml.
    - Refresh patches.
    - Replace PORTVERSION with DISTVERSION and VERSION in PLIST_SUB.

    PR:             287756
    Approved by:    Gasol Wu <gasol.wu@gmail.com> (maintainer)
    Co-authored-by: Pavel Timofeev <timp87@gmail.com>

 devel/jsonnet/Makefile                             | 13 +++++++++--
 devel/jsonnet/distinfo                             |  8 ++++---
 devel/jsonnet/files/patch-CMakeLists.txt           |  6 +++---
 devel/jsonnet/files/patch-core_CMakeLists.txt      |  4 ++--
 devel/jsonnet/files/patch-core_vm.cpp              | 25 +++++++---------------
 ...atch-third__party_rapidyaml_ryml__all.hpp (new) | 20 +++++++++++++++++
 devel/jsonnet/pkg-plist                            |  4 ++--
 7 files changed, 51 insertions(+), 29 deletions(-)
Comment 11 Vladimir Druzenko freebsd_committer freebsd_triage 2025-09-04 23:30:58 UTC
Thanks.