Bug 287840 - devel/rapidyaml: update to v0.6.0
Summary: devel/rapidyaml: update to v0.6.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL: https://github.com/biojppm/rapidyaml/...
Keywords:
Depends on: 287839
Blocks: 287756
  Show dependency treegraph
 
Reported: 2025-06-26 18:22 UTC by Pavel Timofeev
Modified: 2025-09-04 23:30 UTC (History)
2 users (show)

See Also:
gasol.wu: maintainer-feedback+


Attachments
port patch v0.6.0 (3.09 KB, patch)
2025-06-26 18:22 UTC, Pavel Timofeev
no flags Details | Diff
port patch v0.9.0 (just in case) (4.75 KB, patch)
2025-06-26 18:26 UTC, Pavel Timofeev
no flags Details | Diff
v1 (4.61 KB, patch)
2025-07-26 13:14 UTC, Vladimir Druzenko
vvd: maintainer-approval?
Details | Diff
test build log (29.32 KB, text/plain)
2025-08-04 03:11 UTC, Gasol Wu
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Timofeev 2025-06-26 18:22:34 UTC
Created attachment 261641 [details]
port patch v0.6.0

- update to v0.6.0
- move GH_TAGNAME a bit higher in Makefile per portclippy advice
- regenerate patch-CMakeLists.txt per current source


WARNING: v0.6.0 is not the latest version.

I do have patch for v0.9.0 (attached just in case), but since latest jsonnet (0.21.0 in the time) can't be built against it w/o modification I post v0.6.0.

https://github.com/biojppm/rapidyaml/releases/tag/v0.7.0
> The existing parse_...() methods in the Parser class were all removed. Use the corresponding parse_...(Parser*, ...) function from the header c4/yml/parse.hpp.

Just don't have enough c++ experience/confidence/knowledge to properly patch jsonnet for newer rapidyaml.
Comment 1 Pavel Timofeev 2025-06-26 18:26:07 UTC
Created attachment 261642 [details]
port patch v0.9.0 (just in case)

Attaching v0.9.0 patch just in case
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2025-07-26 13:14:51 UTC
Created attachment 262437 [details]
v1

Please test the port in runtime with this patch.
Comment 3 Gasol Wu 2025-08-04 03:11:22 UTC
Created attachment 262691 [details]
test build log
Comment 4 Gasol Wu 2025-08-04 03:11:51 UTC
Comment on attachment 262437 [details]
v1

lgtm
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2025-08-07 15:34:48 UTC
(In reply to Gasol Wu from comment #4)
I can't commit this patch without commit patch from bug#287756.
Comment 6 Gasol Wu 2025-08-07 15:49:00 UTC
(In reply to Vladimir Druzenko from comment #5)

Ok. I’ll need some more time to evaluate that patch.
Comment 7 commit-hook freebsd_committer freebsd_triage 2025-09-04 23:15:51 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ebc4075857c64b9660102a84d0d92ef04ec63cca

commit ebc4075857c64b9660102a84d0d92ef04ec63cca
Author:     Pavel Timofeev <timp87@gmail.com>
AuthorDate: 2025-09-04 22:38:53 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2025-09-04 23:14:25 +0000

    devel/rapidyaml: Update 0.3.0 => 0.9.0

    Changelogs:
    https://github.com/biojppm/rapidyaml/releases/tag/v0.4.0
    https://github.com/biojppm/rapidyaml/releases/tag/v0.4.1
    https://github.com/biojppm/rapidyaml/releases/tag/v0.5.0
    https://github.com/biojppm/rapidyaml/releases/tag/v0.6.0
    https://github.com/biojppm/rapidyaml/releases/tag/v0.7.0
    https://github.com/biojppm/rapidyaml/releases/tag/v0.7.1
    https://github.com/biojppm/rapidyaml/releases/tag/v0.7.2
    https://github.com/biojppm/rapidyaml/releases/tag/v0.8.0
    https://github.com/biojppm/rapidyaml/releases/tag/v0.9.0

    - Refresh patches.
    - Replace PORTVERSION with DISTVERSION and VERSION in PLIST_SUB.
    - Fix warnings from portclippy.

    PR:             287840
    Approved by:    Gasol Wu <gasol.wu@gmail.com> (maintainer)
    Co-authored-by: Vladimir Druzenko <vvd@FreeBSD.org>

 devel/rapidyaml/Makefile                                |  6 +++---
 devel/rapidyaml/distinfo                                | 10 +++++-----
 devel/rapidyaml/files/patch-CMakeLists.txt              | 17 +++++++++--------
 devel/rapidyaml/files/patch-src_c4_yml_common.hpp (new) | 11 +++++++++++
 devel/rapidyaml/pkg-plist                               | 13 ++++++++++++-
 5 files changed, 40 insertions(+), 17 deletions(-)
Comment 8 Vladimir Druzenko freebsd_committer freebsd_triage 2025-09-04 23:30:05 UTC
Thanks.