Bug 288003 - deskutils/syncthingtray: update to 1.7.10
Summary: deskutils/syncthingtray: update to 1.7.10
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Hiroki Tagato
URL: https://github.com/Martchus/syncthing...
Keywords:
Depends on:
Blocks:
 
Reported: 2025-07-04 14:46 UTC by Denis Shaposhnikov
Modified: 2025-07-07 07:28 UTC (History)
2 users (show)

See Also:


Attachments
syncthingtray-1.7.9.patch (3.48 KB, patch)
2025-07-04 14:46 UTC, Denis Shaposhnikov
dsh: maintainer-approval+
Details | Diff
syncthingtray-1.7.10.patch (5.37 KB, patch)
2025-07-05 14:06 UTC, Denis Shaposhnikov
dsh: maintainer-approval+
Details | Diff
syncthingtray-1.7.10.patch (6.43 KB, patch)
2025-07-06 14:12 UTC, Denis Shaposhnikov
dsh: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Denis Shaposhnikov 2025-07-04 14:46:40 UTC
Created attachment 261865 [details]
syncthingtray-1.7.9.patch

https://github.com/Martchus/syncthingtray/releases/tag/v1.7.9
Comment 1 Hiroki Tagato freebsd_committer freebsd_triage 2025-07-05 05:49:25 UTC
Thanks for an update to the port.

I tried to build the port with poudriere and got the following warnings/errors in stage-qa and check-plist phases.

Qt5 flavor:
====> Running Q/A tests (stage-qa)
Error: /usr/local/bin/syncthingtray is linked to /usr/local/lib/qt5/libQt5Positioning.so.5 from devel/qt5-location but it is not declared as a dependency
Warning: you need USES=qt:5 and USE_QT+=location
Notice: You have some Perl modules as dependencies but you do not have devel/p5-Module-CoreList installed, the perlcore QA check gets better results when using it, especially with older Perl versions.
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: share/syncthingconnector/translations/syncthingconnector_ru_RU.qm
Error: Orphaned: share/syncthingfileitemaction/translations/syncthingfileitemaction_ru_RU.qm
Error: Orphaned: share/syncthingmodel/translations/syncthingmodel_ru_RU.qm
Error: Orphaned: share/syncthingplasmoid/translations/syncthingplasmoid_cs_CZ.qm
Error: Orphaned: share/syncthingplasmoid/translations/syncthingplasmoid_ru_RU.qm
Error: Orphaned: share/syncthingplasmoid/translations/syncthingplasmoid_zh_CN.qm
Error: Orphaned: %%DATADIR%%/translations/syncthingtray_ru_RU.qm
Error: Orphaned: share/syncthingwidgets/translations/syncthingwidgets_ru_RU.qm
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1

Stop.


Qt6 flavor:
====> Running Q/A tests (stage-qa)
Error: /usr/local/bin/syncthingtray is linked to /usr/local/lib/qt6/libQt6Positioning.so.6 from devel/qt6-positioning but it is not declared as a dependency
Warning: you need USES=qt:6 and USE_QT+=positioning
Notice: You have some Perl modules as dependencies but you do not have devel/p5-Module-CoreList installed, the perlcore QA check gets better results when using it, especially with older Perl versions.
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: share/syncthingconnector/translations/syncthingconnector_ru_RU.qm
Error: Orphaned: share/syncthingfileitemaction/translations/syncthingfileitemaction_ru_RU.qm
Error: Orphaned: share/syncthingmodel/translations/syncthingmodel_ru_RU.qm
Error: Orphaned: share/syncthingplasmoid/translations/syncthingplasmoid_cs_CZ.qm
Error: Orphaned: share/syncthingplasmoid/translations/syncthingplasmoid_ru_RU.qm
Error: Orphaned: share/syncthingplasmoid/translations/syncthingplasmoid_zh_CN.qm
Error: Orphaned: %%DATADIR%%/translations/syncthingtray_ru_RU.qm
Error: Orphaned: share/syncthingwidgets/translations/syncthingwidgets_ru_RU.qm
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1

Stop.

Can you address those issues and revise the patch?
Comment 2 Denis Shaposhnikov 2025-07-05 14:06:44 UTC
Created attachment 261888 [details]
syncthingtray-1.7.10.patch

Update to 1.7.10
https://github.com/Martchus/syncthingtray/releases/tag/v1.7.10

All fixed, except

====> Running Q/A tests (stage-qa)
Error: /usr/local/bin/syncthingtray is linked to /usr/local/lib/qt6/libQt6Positioning.so.6 from devel/qt6-positioning but it is not declared as a dependency
Warning: you need USES=qt:6 and USE_QT+=positioning

I don't know how did you get it. My `poudriere testport` shows nothing about libQt6Positioning.so.6:

====> Running Q/A tests (stage-qa)
Notice: You have some Perl modules as dependencies but you do not have devel/p5-Module-CoreList installed, the perlcore QA check gets better results when using it, especially with older Perl versions.
Warning: You have disabled the licenses framework with DISABLE_LICENSES, unable to run checks
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
===> No pkg-plist issues found (check-plist)
=>> Checking for staging violations... done

=>> Checking shared library dependencies
 0x0000000000000001 NEEDED               Shared library: [libGLX.so.0]
 0x0000000000000001 NEEDED               Shared library: [libOpenGL.so.0]
 0x0000000000000001 NEEDED               Shared library: [libQt6Concurrent.so.6]
 0x0000000000000001 NEEDED               Shared library: [libQt6Core.so.6]
 0x0000000000000001 NEEDED               Shared library: [libQt6DBus.so.6]
 0x0000000000000001 NEEDED               Shared library: [libQt6Gui.so.6]
 0x0000000000000001 NEEDED               Shared library: [libQt6Network.so.6]
 0x0000000000000001 NEEDED               Shared library: [libQt6Qml.so.6]
 0x0000000000000001 NEEDED               Shared library: [libQt6Svg.so.6]
 0x0000000000000001 NEEDED               Shared library: [libQt6Widgets.so.6]
 0x0000000000000001 NEEDED               Shared library: [libX11.so.6]
 0x0000000000000001 NEEDED               Shared library: [libboost_atomic.so.1.88.0]
 0x0000000000000001 NEEDED               Shared library: [libboost_filesystem.so.1.88.0]
 0x0000000000000001 NEEDED               Shared library: [libboost_iostreams.so.1.88.0]
 0x0000000000000001 NEEDED               Shared library: [libboost_random.so.1.88.0]
 0x0000000000000001 NEEDED               Shared library: [libboost_regex.so.1.88.0]
 0x0000000000000001 NEEDED               Shared library: [libboost_system.so.1.88.0]
 0x0000000000000001 NEEDED               Shared library: [libc++.so.1]
 0x0000000000000001 NEEDED               Shared library: [libc.so.7]
 0x0000000000000001 NEEDED               Shared library: [libcxxrt.so.1]
 0x0000000000000001 NEEDED               Shared library: [libgcc_s.so.1]
 0x0000000000000001 NEEDED               Shared library: [libm.so.5]
 0x0000000000000001 NEEDED               Shared library: [libthr.so.3]
Comment 3 Vladimir Druzenko freebsd_committer freebsd_triage 2025-07-06 03:51:19 UTC
(In reply to Denis Shaposhnikov from comment #2)
For qt5 flavor add to USE_QT+=location (line 45) and for qt6 flavor USE_QT+=positioning (line 52).
Comment 4 Hiroki Tagato freebsd_committer freebsd_triage 2025-07-06 04:11:46 UTC
(In reply to Denis Shaposhnikov from comment #2)

> I don't know how did you get it. My `poudriere testport` shows nothing about libQt6Positioning.so.6

What I did is:
poudriere bulk -t -v -j r142amd64 -p tests -b latest deskutils/syncthingtray@all

One thing I can think of is the version of poudriere. I use stable version (v3.4.2). What version do you use?

In my environment, it still fails to build with the latest patch:

Qt5 flavor:
====> Running Q/A tests (stage-qa)
Error: /usr/local/bin/syncthingtray is linked to /usr/local/lib/qt5/libQt5Positioning.so.5 from devel/qt5-location but it is not declared as a dependency
Warning: you need USES=qt:5 and USE_QT+=location
Notice: You have some Perl modules as dependencies but you do not have devel/p5-Module-CoreList installed, the perlcore QA check gets better results when using it, especially with older Perl versions.
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: share/syncthingfileitemaction/translations/syncthingfileitemaction_ru_RU.qm
Error: Orphaned: share/syncthingplasmoid/translations/syncthingplasmoid_cs_CZ.qm
Error: Orphaned: share/syncthingplasmoid/translations/syncthingplasmoid_ru_RU.qm
Error: Orphaned: share/syncthingplasmoid/translations/syncthingplasmoid_zh_CN.qm
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1

Stop.

Qt6 flavor:
====> Running Q/A tests (stage-qa)
Error: /usr/local/bin/syncthingtray is linked to /usr/local/lib/qt6/libQt6Positioning.so.6 from devel/qt6-positioning but it is not declared as a dependency
Warning: you need USES=qt:6 and USE_QT+=positioning
Notice: You have some Perl modules as dependencies but you do not have devel/p5-Module-CoreList installed, the perlcore QA check gets better results when using it, especially with older Perl versions.
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: share/syncthingfileitemaction/translations/syncthingfileitemaction_ru_RU.qm
Error: Orphaned: share/syncthingplasmoid/translations/syncthingplasmoid_cs_CZ.qm
Error: Orphaned: share/syncthingplasmoid/translations/syncthingplasmoid_ru_RU.qm
Error: Orphaned: share/syncthingplasmoid/translations/syncthingplasmoid_zh_CN.qm
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1

Stop.
Comment 5 Denis Shaposhnikov 2025-07-06 14:12:20 UTC
Created attachment 261923 [details]
syncthingtray-1.7.10.patch

All fixed.
Comment 6 commit-hook freebsd_committer freebsd_triage 2025-07-07 07:27:23 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ac31b042b96f9e6fd16d3ef6e653c08e23952607

commit ac31b042b96f9e6fd16d3ef6e653c08e23952607
Author:     Denis Shaposhnikov <dsh@bamus.cz>
AuthorDate: 2025-07-06 14:10:40 +0000
Commit:     Hiroki Tagato <tagattie@FreeBSD.org>
CommitDate: 2025-07-07 07:26:21 +0000

    deskutils/syncthingtray: update to 1.7.10

    Changelog: https://github.com/Martchus/syncthingtray/compare/v1.7.8...v1.7.10

    PR:             288003
    Reported by:    Denis Shaposhnikov <dsh@bamus.cz> (maintainer)
    Reviewed by:    vvd

 deskutils/syncthingtray/Makefile  | 16 ++++++++--------
 deskutils/syncthingtray/distinfo  | 18 +++++++++---------
 deskutils/syncthingtray/pkg-plist |  8 ++++++++
 3 files changed, 25 insertions(+), 17 deletions(-)
Comment 7 Hiroki Tagato freebsd_committer freebsd_triage 2025-07-07 07:28:12 UTC
Committed, thanks!