Bug 288557 - devel/git-who: Update 1.1 => 1.2
Summary: devel/git-who: Update 1.1 => 1.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Älven
URL: https://github.com/sinclairtarget/git...
Keywords:
Depends on:
Blocks:
 
Reported: 2025-07-30 18:55 UTC by Yusuf Yaman
Modified: 2025-08-03 16:44 UTC (History)
4 users (show)

See Also:
alven: maintainer-feedback+
alven: maintainer-feedback? (yuri)


Attachments
devel/git-who.patch (2.36 KB, patch)
2025-07-30 19:03 UTC, Yusuf Yaman
nxjoseph: maintainer-approval+
Details | Diff
0001-devel-git-who-Fix-build-fail-due-to-distinfo-mismatc.patch (1.19 KB, patch)
2025-08-03 08:21 UTC, Yusuf Yaman
nxjoseph: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuf Yaman freebsd_committer freebsd_triage 2025-07-30 18:55:22 UTC

    
Comment 1 Yusuf Yaman freebsd_committer freebsd_triage 2025-07-30 19:03:18 UTC
Created attachment 262565 [details]
devel/git-who.patch

thanks in advance.
Comment 2 Älven freebsd_committer freebsd_triage 2025-07-30 19:58:36 UTC
> % git-who
> could not parse args: failed to run git rev-parse: failed to start subprocess: exec: "git": executable file not found in $PATH

I suggest adding:
RUN_DEPENDS=	git:devel/git

Would you agree?
Comment 3 Älven freebsd_committer freebsd_triage 2025-07-30 19:59:33 UTC
No need to add new version of patch: just say "yes" if you agree, and I'll add it myself before commit :)
Comment 4 Yusuf Yaman freebsd_committer freebsd_triage 2025-07-30 20:02:02 UTC
(In reply to Älven from comment #2)
Yes, I think I've overlooked this part. I didn't think anyone would try to use this without devel/git installed.

(In reply to Älven from comment #3)
Thanks for your kindness! Yes.
Comment 5 Älven freebsd_committer freebsd_triage 2025-07-30 20:20:20 UTC
Builds and runs OK. May commit when approved by my mentor.

(In reply to Yusuf Yaman from comment #4)
> Thanks for your kindness! Yes.
I always like to be kind :)
Especially after been so welcomed by this friendly community and even been trusted with committer duty :)

Before I was happy enough to be supported by very kind committer - Vladimir Druzenko (vvd@). Now being a committer myself, I try to be kind and helpful with other developers to make them feel my care and support. :)

You also may become a committer one day, if you would like so ;)
Comment 6 Yuri Victorovich freebsd_committer freebsd_triage 2025-07-31 04:40:46 UTC
Hi Älven,

Approved.

Thanks,
Yuri
Comment 7 commit-hook freebsd_committer freebsd_triage 2025-07-31 17:38:27 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=dbeb51179c39b8aaf2f87871ac6f3780ededca88

commit dbeb51179c39b8aaf2f87871ac6f3780ededca88
Author:     Yusuf Yaman <nxjoseph@protonmail.com>
AuthorDate: 2025-07-30 18:51:15 +0000
Commit:     Älven <alven@FreeBSD.org>
CommitDate: 2025-07-31 17:36:16 +0000

    devel/git-who: Update 1.1 => 1.2

    Changelog:
    https://github.com/sinclairtarget/git-who/releases/tag/v1.2

    While here, don't specify a go version since go is backwards-compatible,
    and fix unknown version problem on `git-who -version` command.

    Add devel/git to RUN_DEPENDS

    PR:             288557
    Approved by:    yuri@ (Mentor)

 devel/git-who/Makefile | 8 ++++++--
 devel/git-who/distinfo | 6 +++---
 2 files changed, 9 insertions(+), 5 deletions(-)
Comment 8 Yusuf Yaman freebsd_committer freebsd_triage 2025-08-03 08:21:25 UTC
Created attachment 262655 [details]
0001-devel-git-who-Fix-build-fail-due-to-distinfo-mismatc.patch

Hi,

upstream maintainer committed some more changes to v1.2 which caused my port to get build fails due to distinfo file size mismatch, so to fix this, i've had prepared a patch, thanks in advance.
Comment 9 Yusuf Yaman freebsd_committer freebsd_triage 2025-08-03 08:22:16 UTC
re-opening the PR because of build fail fix patch.
Comment 10 Älven freebsd_committer freebsd_triage 2025-08-03 08:35:36 UTC
OK, I'll look at it and will fix it ASAP.
Comment 11 commit-hook freebsd_committer freebsd_triage 2025-08-03 09:36:42 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=96cc69b9c1373f906f50f1e810833e93d79d1027

commit 96cc69b9c1373f906f50f1e810833e93d79d1027
Author:     Yusuf Yaman <nxjoseph@protonmail.com>
AuthorDate: 2025-08-03 08:17:47 +0000
Commit:     Älven <alven@FreeBSD.org>
CommitDate: 2025-08-03 09:34:24 +0000

    devel/git-who: Fix build fail due to distinfo mismatch

    Fixes:  dbeb51179c39b8aaf2f87871ac6f3780ededca88
    PR:     288557

    Approved by:    yuri@ (Mentor, implicit)

 devel/git-who/distinfo | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Comment 12 Älven freebsd_committer freebsd_triage 2025-08-03 09:39:46 UTC
Committed. Thanks!
Should work well now :)
Comment 13 commit-hook freebsd_committer freebsd_triage 2025-08-03 14:58:20 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=852ee8cfd4eb856e34dfce3db03f373f1cee64cf

commit 852ee8cfd4eb856e34dfce3db03f373f1cee64cf
Author:     Älven <alven@FreeBSD.org>
AuthorDate: 2025-08-03 14:55:39 +0000
Commit:     Älven <alven@FreeBSD.org>
CommitDate: 2025-08-03 14:55:39 +0000

    devel/git-who: bump PORTREVISION after upstream silent distfile change

    PR:             288557
    Approved by:    yuri@ (Mentor, implicit)

 devel/git-who/Makefile | 1 +
 1 file changed, 1 insertion(+)
Comment 14 Älven freebsd_committer freebsd_triage 2025-08-03 14:59:26 UTC
Forgot to bump within previous commit. Think it should be done for safety.
Comment 15 Anton Saietskii 2025-08-03 15:24:28 UTC
(In reply to Älven from comment #14)

Dear Älven, I'd like to humbly ask you to review section 9 of Committer's Guide, especially subsection 9.5 [0]. Thanks.

[0]: https://docs.freebsd.org/en/articles/committers-guide/#_capitalize_the_first_letter_of_the_subject
Comment 16 Älven freebsd_committer freebsd_triage 2025-08-03 16:44:37 UTC
(In reply to Anton Saietskii from comment #15)
Thank you Anton! :)

I like to know and follow the rules.
Sure I will follow the one you so kindly and politely asked me to follow. :)

Älven