Bug 288945 - misc/compat14x: add powerpc / powerpc64 / powerpc64le
Summary: misc/compat14x: add powerpc / powerpc64 / powerpc64le
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: powerpc Any
: --- Affects Some People
Assignee: Gleb Popov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-08-19 08:43 UTC by Piotr Kubaj
Modified: 2025-09-11 07:31 UTC (History)
1 user (show)

See Also:
arrowd: maintainer-feedback+


Attachments
patch (5.51 KB, patch)
2025-08-19 08:43 UTC, Piotr Kubaj
no flags Details | Diff
patch (5.28 KB, patch)
2025-08-19 08:44 UTC, Piotr Kubaj
no flags Details | Diff
gen-compat.sh patch (1.06 KB, patch)
2025-08-20 11:45 UTC, Piotr Kubaj
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2025-08-19 08:43:20 UTC
Created attachment 263063 [details]
patch

Add powerpc / powerpc64 and powerpc64le compatibility to the port for openjdk bootstraps.
Distfiles available at https://people.freebsd.org/~pkubaj/.
Patch is attached.
Comment 1 Piotr Kubaj freebsd_committer freebsd_triage 2025-08-19 08:44:30 UTC
Created attachment 263064 [details]
patch
Comment 2 Gleb Popov freebsd_committer freebsd_triage 2025-08-19 08:44:52 UTC
Were those generated with "make makedist"?
Comment 3 Piotr Kubaj freebsd_committer freebsd_triage 2025-08-19 08:45:19 UTC
BTW, it's not a part of this patch, but lib32 is available for aarch64 as well.
Comment 4 Piotr Kubaj freebsd_committer freebsd_triage 2025-08-19 08:45:44 UTC
No, but they pass poudriere testport.
Comment 5 Gleb Popov freebsd_committer freebsd_triage 2025-08-19 09:26:01 UTC
Would you mind first modifying Tools/scripts/gen-compat.sh so that it works for powerpc? This way the port would be more sustainable.
Comment 6 Piotr Kubaj freebsd_committer freebsd_triage 2025-08-19 09:50:46 UTC
I started looking at it after you mentioned makedist.
This fragment puzzles me:
tarch=${arch}
if [ $tarch = "arm64" ]; then
        tarch="aarch64"
fi
if [ $tarch = "aarch64" ]; then
        arch="arm64"
fi

Let's assume we're on aarch64 - since that is passed. Then that value is changed to arm64 - that's ok. But why would arm64 end up being passed? And even if it's passed, it would be changed to aarch64 only to be changed in the next conditional back to arm64. That doesn't make sense.
Comment 7 Piotr Kubaj freebsd_committer freebsd_triage 2025-08-19 09:53:10 UTC
Ah, ok, first conditional modifies tarch, but the second  one modifies arch, I didn't notice that.
Comment 8 Piotr Kubaj freebsd_committer freebsd_triage 2025-08-20 11:45:46 UTC
Created attachment 263086 [details]
gen-compat.sh patch

I went ahead and added riscv64 and lib32 for aarch64. lib32 for aarch64 seems to be available since 14.
Comment 9 Baptiste Daroussin freebsd_committer freebsd_triage 2025-09-03 08:05:01 UTC
LGTM, please push.
Comment 10 Gleb Popov freebsd_committer freebsd_triage 2025-09-03 09:24:21 UTC
I will handle the rest, thanks.
Comment 11 commit-hook freebsd_committer freebsd_triage 2025-09-03 11:01:09 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c2f9699d12082d7d6ba94afe02978be0a7f4da36

commit c2f9699d12082d7d6ba94afe02978be0a7f4da36
Author:     Piotr Kubaj <pkubaj@FreeBSD.org>
AuthorDate: 2025-09-03 10:28:19 +0000
Commit:     Gleb Popov <arrowd@FreeBSD.org>
CommitDate: 2025-09-03 10:59:57 +0000

    misc/compat14x: add powerpc{,64,64le}

    PR:             288945

 misc/compat14x/Makefile                    |  6 ++--
 misc/compat14x/distinfo                    | 10 ++-----
 misc/compat14x/pkg-plist.powerpc (new)     | 23 +++++++++++++++
 misc/compat14x/pkg-plist.powerpc64 (new)   | 46 ++++++++++++++++++++++++++++++
 misc/compat14x/pkg-plist.powerpc64le (new) | 23 +++++++++++++++
 5 files changed, 99 insertions(+), 9 deletions(-)
Comment 12 commit-hook freebsd_committer freebsd_triage 2025-09-03 11:01:10 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a85e8a103eecfa5a4df23435c1c7f4fc22111526

commit a85e8a103eecfa5a4df23435c1c7f4fc22111526
Author:     Piotr Kubaj <pkubaj@FreeBSD.org>
AuthorDate: 2025-09-03 09:26:54 +0000
Commit:     Gleb Popov <arrowd@FreeBSD.org>
CommitDate: 2025-09-03 10:59:57 +0000

    Tools/scripts/gen-compat.sh: Support powerpc and riscv

    PR:             288945
    Approved by:    bapt

 Tools/scripts/gen-compat.sh | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
Comment 13 Piotr Kubaj freebsd_committer freebsd_triage 2025-09-03 11:33:27 UTC
While already here, can you also do the same for compat13x? You will need to remove aarch64 from lib32 list in Tools/scripts/gen-compat.sh, otherwise it's the same.
Comment 14 Gleb Popov freebsd_committer freebsd_triage 2025-09-03 11:34:12 UTC
Sure, will do, but a bit later.
Comment 15 commit-hook freebsd_committer freebsd_triage 2025-09-04 11:48:34 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=125d90b25f7ea9ac1f9ae94d59a29730ee2989a6

commit 125d90b25f7ea9ac1f9ae94d59a29730ee2989a6
Author:     Gleb Popov <arrowd@FreeBSD.org>
AuthorDate: 2025-09-04 11:46:39 +0000
Commit:     Gleb Popov <arrowd@FreeBSD.org>
CommitDate: 2025-09-04 11:46:39 +0000

    misc/compat14x: Fix distinfo after the last change

    PR:             288945
    Reported by:    fluffy
    Fixes:  c2f9699d12082d7d6ba94afe02978be0a7f4da36

 misc/compat14x/distinfo | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)
Comment 16 commit-hook freebsd_committer freebsd_triage 2025-09-11 07:31:25 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8ec4d7f4887384471ac961d11cb6788c8c1af0b6

commit 8ec4d7f4887384471ac961d11cb6788c8c1af0b6
Author:     Gleb Popov <arrowd@FreeBSD.org>
AuthorDate: 2025-09-11 05:56:56 +0000
Commit:     Gleb Popov <arrowd@FreeBSD.org>
CommitDate: 2025-09-11 07:30:28 +0000

    misc/compat13x: Add libdvp.so.2 and powerpc support

    PR:             288945
    Reported by:    des

 misc/compat13x/Makefile                    | 23 +++++++++++++++++------
 misc/compat13x/distinfo                    | 20 +++++++++++++-------
 misc/compat13x/pkg-plist.aarch64           |  2 +-
 misc/compat13x/pkg-plist.amd64             | 12 ++++++------
 misc/compat13x/pkg-plist.i386              |  2 +-
 misc/compat13x/pkg-plist.powerpc (new)     |  5 +++++
 misc/compat13x/pkg-plist.powerpc64 (new)   | 10 ++++++++++
 misc/compat13x/pkg-plist.powerpc64le (new) |  5 +++++
 8 files changed, 58 insertions(+), 21 deletions(-)