Bug 289016 - games/veloren-weekly: fails to build with rust 1.89.0
Summary: games/veloren-weekly: fails to build with rust 1.89.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-08-23 07:33 UTC by Mikael Urankar
Modified: 2025-09-11 00:26 UTC (History)
0 users

See Also:
jbeich: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mikael Urankar freebsd_committer freebsd_triage 2025-08-23 07:33:14 UTC
I'm not able to fix the following error:

error[E0391]: cycle detected when computing revealed normalized predicates of `veloren_voxygen::scene::figure::load::BodySpec::bone_meshes::{constant#0}`
   --> /wrkdirs/usr/ports/games/veloren-weekly/work/veloren-v0.17.0-973-gec58a04dc1/voxygen/src/scene/figure/load.rs:137:35
    |
137 |     ) -> [Option<Self::BoneMesh>; anim::MAX_BONE_COUNT];
    |                                   ^^^^^^^^^^^^^^^^^^^^
    |
note: ...which requires computing normalized predicates of `veloren_voxygen::scene::figure::load::BodySpec::bone_meshes::{constant#0}`...
   --> /wrkdirs/usr/ports/games/veloren-weekly/work/veloren-v0.17.0-973-gec58a04dc1/voxygen/src/scene/figure/load.rs:137:35
    |
137 |     ) -> [Option<Self::BoneMesh>; anim::MAX_BONE_COUNT];
    |                                   ^^^^^^^^^^^^^^^^^^^^
    = note: ...which again requires computing revealed normalized predicates of `veloren_voxygen::scene::figure::load::BodySpec::bone_meshes::{constant#0}`, completing the cycle
note: cycle used when computing normalized predicates of `veloren_voxygen::scene::figure::load::BodySpec::bone_meshes`
   --> /wrkdirs/usr/ports/games/veloren-weekly/work/veloren-v0.17.0-973-gec58a04dc1/voxygen/src/scene/figure/load.rs:133:5
    |
133 | /     fn bone_meshes(
134 | |         key: &FigureKey<Self>,
135 | |         manifests: &Self::Manifests,
136 | |         extra: Self::Extra,
137 | |     ) -> [Option<Self::BoneMesh>; anim::MAX_BONE_COUNT];
    | |________________________________________________________^
    = note: see https://rustc-dev-guide.rust-lang.org/overview.html#queries and https://rustc-dev-guide.rust-lang.org/query.html for more information
Comment 1 commit-hook freebsd_committer freebsd_triage 2025-09-01 08:26:42 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=457787fc6540d3e21d558967d7c399a9ce54cc5f

commit 457787fc6540d3e21d558967d7c399a9ce54cc5f
Author:     Mikael Urankar <mikael@FreeBSD.org>
AuthorDate: 2025-08-31 14:50:38 +0000
Commit:     Mikael Urankar <mikael@FreeBSD.org>
CommitDate: 2025-09-01 08:24:01 +0000

    games/veloren-weekly: Use rust 1.88.0

    veloren doesn't build with rust 1.89.0

    error[E0391]: cycle detected when computing revealed normalized predicates of `veloren_voxygen::scene::figure::load::BodySpec::bone_meshes::{constant#0}`
       --> voxygen/src/scene/figure/load.rs:137:35

    PR:             289016

 games/veloren-weekly/Makefile | 4 ++++
 1 file changed, 4 insertions(+)
Comment 2 commit-hook freebsd_committer freebsd_triage 2025-09-01 08:26:44 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c61dde399b03b25692b6eab7dda0556fbccc48a5

commit c61dde399b03b25692b6eab7dda0556fbccc48a5
Author:     Mikael Urankar <mikael@FreeBSD.org>
AuthorDate: 2025-08-31 11:13:05 +0000
Commit:     Mikael Urankar <mikael@FreeBSD.org>
CommitDate: 2025-09-01 08:24:01 +0000

    lang/rust: fork 1.88 into a pinned port

    A temporary workaround for devel/git-branchless and games/veloren-weekly.

    PR:             288923, 289015, 289016

 lang/Makefile                                      |   1 +
 lang/rust-nightly/Makefile                         |   2 +-
 lang/rust/Makefile                                 |   2 +-
 lang/rust188/Makefile (new)                        | 283 ++++++++
 lang/rust188/distinfo (new)                        |  51 ++
 ...ustc__driver__impl_src_signal__handler.rs (new) |  28 +
 ...er_rustc__target_src_spec_base_freebsd.rs (new) |  11 +
 ...rc_spec_targets_i686__unknown__freebsd.rs (new) |  13 +
 ...r_rustc__target_src_callconv_powerpc64.rs (new) |  11 +
 ...ch-library_backtrace_src_backtrace_mod.rs (new) |  10 +
 ...ootstrap_src_core_build__steps_install.rs (new) |  17 +
 ...ols_cargo_src_cargo_sources_git_source.rs (new) |  36 +
 lang/rust188/files/patch-vendor_cc.rs (new)        |  75 +++
 .../patch-vendor_git2-0.19.0_src_lib.rs (new)      |  18 +
 lang/rust188/files/patch-vendor_libc-0.2.155 (new) | 745 +++++++++++++++++++++
 ...-vendor_openssl_crypto_threads__pthread.c (new) |  27 +
 ...t_src_spec_riscv64gc__unknown__freebsd.rs (new) |  21 +
 lang/rust188/pkg-descr (new)                       |  12 +
 lang/rust188/update.sh (new)                       |  35 +
 19 files changed, 1396 insertions(+), 2 deletions(-)
Comment 3 Jan Beich freebsd_committer freebsd_triage 2025-09-01 09:34:45 UTC
Thanks. I completely forgot forking lang/rust as a workaround, so expected BROKEN instead. ;)
Comment 4 commit-hook freebsd_committer freebsd_triage 2025-09-04 00:58:34 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=053b84a3d1db6acd184e4e4daf4e57a773c486eb

commit 053b84a3d1db6acd184e4e4daf4e57a773c486eb
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2025-09-02 12:54:50 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2025-09-04 00:46:07 +0000

    lang/rust188: chase version in suffix

    Extracting rust182-1.88.0: .......... done
    ===>   veloren-weekly-s20250828_1 depends on package: rust188>0 - not found
    *** Error code 1

    PR:             289016
    Reported by:    pkg-fallout

 lang/rust188/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 5 Mikael Urankar freebsd_committer freebsd_triage 2025-09-04 06:22:22 UTC
(In reply to commit-hook from comment #4)
Thanks, I remember fixing this error on my side and forgot to commit it :(
Comment 6 commit-hook freebsd_committer freebsd_triage 2025-09-11 00:26:17 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0dcdcf68e6df0d9dcdeb31ac6fe104a517714bda

commit 0dcdcf68e6df0d9dcdeb31ac6fe104a517714bda
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2025-09-10 18:21:00 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2025-09-11 00:24:42 +0000

    games/veloren-weekly: back to default rust after 7b3cb2622d8e

    https://gitlab.com/veloren/veloren/-/commit/2f42fc650d2d
    This reverts commit 457787fc6540d3e21d558967d7c399a9ce54cc5f.

    PR:             289016

 games/veloren-weekly/Makefile | 4 ----
 1 file changed, 4 deletions(-)