Bug 289098 - audio/beets: update to 2.3.1
Summary: audio/beets: update to 2.3.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rodrigo Osorio
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-08-25 15:29 UTC by Rodrigo Osorio
Modified: 2026-01-29 08:13 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (leonhard)


Attachments
Beets ports upgrade (7.67 KB, patch)
2025-08-25 15:29 UTC, Rodrigo Osorio
no flags Details | Diff
Add new port devel/py-lap (mark myself as maintainer) (1.58 KB, patch)
2025-08-25 15:31 UTC, Rodrigo Osorio
no flags Details | Diff
Update beets to 2.5.1 (8.33 KB, patch)
2026-01-03 16:21 UTC, Rodrigo Osorio
rodrigo: maintainer-approval? (leonhard)
Details | Diff
Temporary patch to build beets with PYTHON_DEFAULT=3.12 (1.12 KB, patch)
2026-01-03 16:24 UTC, Rodrigo Osorio
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rodrigo Osorio freebsd_committer freebsd_triage 2025-08-25 15:29:45 UTC
Created attachment 263228 [details]
Beets ports upgrade

Hi,

I try yesterday beet in a bunch of mp3 files, and had a python crash in the import, for some obscure SQL call. But before asking for support, we probably should update our port.
....Which in fact seems to work much better :D....

Multiple steps:
  - Update the port and dependencies
  - Add devel/py-lap port (new dependency, I'll take it)
  - Fix Makefile
    - remove broken option CHROMA (no desc since ecf4719d09f1490e4f9ba0ea42a3bf04a3323875)
    - fix style (portscout, portfmt, portclippy)
Comment 1 Rodrigo Osorio freebsd_committer freebsd_triage 2025-08-25 15:31:08 UTC
Created attachment 263229 [details]
Add new port devel/py-lap (mark myself as maintainer)
Comment 2 Rodrigo Osorio freebsd_committer freebsd_triage 2025-08-25 15:44:38 UTC
Not to myself: don't forget SUBDIR += py-lap
Comment 3 Leonhard Wachutka 2025-08-25 15:57:02 UTC
Hi Rodrigo,

thanks for you efforts. I will check your Diffs ASAP and give you feedback.

Best Leo
Comment 4 Rodrigo Osorio freebsd_committer freebsd_triage 2025-09-07 14:47:41 UTC
(In reply to Rodrigo Osorio from comment #2)
_Note_ to myself: don't forget SUBDIR += py-lap when commit
Comment 5 Lapo Luchini 2025-10-05 09:43:14 UTC
I'm here for the same bug in current ports version I guess:

    sqlite3.OperationalError: no such column: "" - should this be a string literal in single-quotes?

In the meanwhile 2.4.0 seems to have been released. :)
Comment 6 Leonhard Wachutka 2025-11-10 03:35:38 UTC
@ Lapo Luchini 
You need to use a custom build of sqlite that allows for doulbe quotes for this to work, since its still not fixed in beets. See: https://github.com/beetbox/beets/issues/4709
Comment 7 Rodrigo Osorio freebsd_committer freebsd_triage 2025-11-13 06:49:56 UTC
The (In reply to Leonhard Wachutka from comment #6)

The issue you point has a bugfix https://github.com/beetbox/beets/issues/4709
but this will be available in python 3.12 which is not our current target.
Comment 8 Rodrigo Osorio freebsd_committer freebsd_triage 2026-01-03 16:21:28 UTC
Created attachment 266783 [details]
Update beets to 2.5.1

Today I tested the new version of beets with Python 3.12 as the default python version and it works.

Doing the upgrade right now can be challenging because it requires to change dozens of python packages to support py312 flavor.

An upgrade of the default python version is planned i the near future, so at some point we will be aligned to commit the changes and made a working version of beets available.
Comment 9 Rodrigo Osorio freebsd_committer freebsd_triage 2026-01-03 16:24:13 UTC
Created attachment 266784 [details]
Temporary patch to build beets with PYTHON_DEFAULT=3.12
Comment 10 Charlie Li freebsd_committer freebsd_triage 2026-01-03 19:55:45 UTC
You can locally bypass the non-default Python flavour restriction by setting BUILD_ALL_PYTHON_FLAVORS in make.conf.

The referenced upstream fix has been available since 2.1.0 it appears:
https://github.com/beetbox/beets/pull/5447
https://github.com/beetbox/beets/commit/04ee04150ac6ce41393c4e8e0d04030f3c5e2596
Comment 11 Rodrigo Osorio freebsd_committer freebsd_triage 2026-01-03 22:16:55 UTC
(In reply to Charlie Li from comment #10)

Thanks Charlie, I didn't notice that change.
I gonna test it and if charlie is OK with my last update I can commit it.

Regards,
-- rodrigo
Comment 12 Charlie Li freebsd_committer freebsd_triage 2026-01-03 22:47:40 UTC
(In reply to Rodrigo Osorio from comment #11)
Looks fine to me but you should also test with Python 3.11 in the meantime, and of course give the maintainer a chance to approve.
Comment 13 Rodrigo Osorio freebsd_committer freebsd_triage 2026-01-03 23:36:56 UTC
(In reply to Charlie Li from comment #12)
Oops I meant Leonard :p
Comment 14 Rodrigo Osorio freebsd_committer freebsd_triage 2026-01-16 01:41:35 UTC
Hi, Leonhard Wachutka

I'm waiting for your approval to commit beets-2.5.1

All the best
-- rodrigo
Comment 15 Getz Mikalsen 2026-01-23 21:15:29 UTC
(In reply to Rodrigo Osorio from comment #14)

Maintainer timeout, you could commit it yourself now.
Comment 16 Leonhard Wachutka 2026-01-24 13:52:10 UTC
Hi everyone,

i thought I gave allready the green light for the commit month ago, but anyway here it is even if you dont need it anymore.

Best Leo
Comment 17 Rodrigo Osorio freebsd_committer freebsd_triage 2026-01-24 14:01:48 UTC
This will be committed today
Comment 18 commit-hook freebsd_committer freebsd_triage 2026-01-29 08:11:55 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=44f44a8779c1fcca84229afc48fc6a0de5ae68e5

commit 44f44a8779c1fcca84229afc48fc6a0de5ae68e5
Author:     Rodrigo Osorio <rodrigo@FreeBSD.org>
AuthorDate: 2026-01-25 16:05:26 +0000
Commit:     Rodrigo Osorio <rodrigo@FreeBSD.org>
CommitDate: 2026-01-29 08:04:01 +0000

    audio/beets: update 2.0.0 -> 2.5.1

    Changelog: https://github.com/beetbox/beets/releases/tag/v2.5.1

    Major changes:
    Unbreak audio/beats. The breakage was due to an sqlite2
    requirement, disabled in ports, to support Double-quoted String
    Literals.

    Also reorder sections and fix style to make portlint and portfmt
    happy.

    PR:             289098
    Reported by:    vishwin
    Approved by:    Leonhard Wachutka <leonhard@wachutka.eu> (maintainer)

 audio/beets/Makefile | 86 +++++++++++++++++++++++++++-------------------------
 audio/beets/distinfo |  6 ++--
 2 files changed, 48 insertions(+), 44 deletions(-)
Comment 19 commit-hook freebsd_committer freebsd_triage 2026-01-29 08:11:58 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5c1e98f8ca88718e62184ee72200a6a299ae6297

commit 5c1e98f8ca88718e62184ee72200a6a299ae6297
Author:     Rodrigo Osorio <rodrigo@FreeBSD.org>
AuthorDate: 2026-01-25 15:29:45 +0000
Commit:     Rodrigo Osorio <rodrigo@FreeBSD.org>
CommitDate: 2026-01-29 08:04:00 +0000

    devel/py-lap: New port

    Lap is a linear assignment problem solver using Jonker-Volgenant algorithm.
    It's required by the latest version of audio/beet.

    PR:             289098

 devel/Makefile               |  1 +
 devel/py-lap/Makefile (new)  | 20 ++++++++++++++++++++
 devel/py-lap/distinfo (new)  |  3 +++
 devel/py-lap/pkg-descr (new) |  6 ++++++
 4 files changed, 30 insertions(+)
Comment 20 Rodrigo Osorio freebsd_committer freebsd_triage 2026-01-29 08:13:25 UTC
Committed, sorry for the delay.