Bug 289133 - ports-mgmt/portshaker: mercurial dependency broken
Summary: ports-mgmt/portshaker: mercurial dependency broken
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Romain Tartière
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-08-27 17:44 UTC by Tassilo Philipp
Modified: 2025-10-08 19:12 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (romain)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tassilo Philipp 2025-08-27 17:44:48 UTC 
The portshaker Makefile uses the following line for a runtime dependency on mercurial, if the MERCURIAL option was selected:

  MERCURIAL_RUN_DEPENDS=  ${PY_MERCURIAL}

PY_MERCURIAL is only defined when USES=python is specified in the Makefile, which isn't the case, so it's always empty.
Comment 1 commit-hook freebsd_committer freebsd_triage 2025-10-08 19:11:22 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d0d3714812a0c8a4f27f7553c1acb8e08329047f

commit d0d3714812a0c8a4f27f7553c1acb8e08329047f
Author:     Romain Tartière <romain@FreeBSD.org>
AuthorDate: 2025-10-08 19:07:24 +0000
Commit:     Romain Tartière <romain@FreeBSD.org>
CommitDate: 2025-10-08 19:07:24 +0000

    ports-mgmt/portshaker: Add python as a build dependency

    It is not really required, but without it, the run-time dependency on
    mercurial is non-functional when the MERCURIAL option is on.

    Does not impact the default packagage, and poudriere will catch the new
    dependency if MERCURIAL=on so no need to bump PORTREVISION.

    PR:             289133
    Reported by:    Tassilo Philipp <tphilipp@potion-studios.com>

 ports-mgmt/portshaker/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 2 Romain Tartière freebsd_committer freebsd_triage 2025-10-08 19:12:28 UTC 
Thank you for the report.  Fix committed!