Created attachment 263452 [details] urbackup-client 2.5.26.0 patch Update to version 2.5.26.0 with some more port cleanup. Build logs can be found at: https://pkg.purplehat.org/data/fbsd_14-3_x64-HEAD/2025-09-02_21h06m44s/logs/urbackup-client-2.5.26.0.log
Wrong patch.
Created attachment 263455 [details] CORRECT urbackup 2.5.26.0 patch Oh, wow! Complete rookie mistake. I suppose it makes sense, since I'm a rookie. :) Proper patch attached. Sorry about that and thanks for pointing it out so quickly!
====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist ===> Checking for items in pkg-plist which are not in STAGEDIR Error: Missing: etc/rc.d/urbackup_client ===> Error: Plist issues found. *** Error code 1
Created attachment 263456 [details] FIXED: urbackup-client 2.5.26.0 patch Jeepers! I dunno how that crept back in there. But, fixed, re-patched, re-tested via Poudriere. New build log can be found at https://pkg.purplehat.org/data/fbsd_14-3_x64-HEAD/2025-09-03_14h51m53s/logs/urbackup-client-2.5.26.0.log *crosses fingers*
(In reply to ek from comment #4) You didn't add the script etc/rc.d/urbackup_client to the port. Ok.
(In reply to Vladimir Druzenko from comment #5) Yeah. I left the RC script as files/urbackup_client.in (which gets installed/removed as expected) but left it out of STAGE. I tested with manual ports, poudriere, and pkg install/delete and the file was created/removed for all. I'm not sure if this is the best/proper way to handle the RC script. Should it be dumped into ${WRKDIR} for STAGE as well or does it not matter?
(In reply to ek from comment #6) It handled by USE_RC_SUBR=urbackup_client variable. Suggestion to run REINPLACE_CMD for *.cpp and *.h files only: - ${FIND} ${WRKSRC} -type f -exec ${REINPLACE_CMD} \ - -e 's|auto_ptr|unique_ptr|g' {} + + ${FIND} ${WRKSRC} -type f \( -name '*.cpp' -o -name '*.h' \) \ + -exec ${REINPLACE_CMD} -e 's|auto_ptr|unique_ptr|g' {} +
(In reply to Vladimir Druzenko from comment #7) Perfect. Thank you for the work and the explanation/information. I greatly appreciate it!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=d70c8a415dd3d89ac879a2bce2c37b914538ebee commit d70c8a415dd3d89ac879a2bce2c37b914538ebee Author: ek <ek@purplehat.org> AuthorDate: 2025-09-03 22:13:39 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2025-09-03 22:16:00 +0000 archivers/urbackup-client: Update 2.5.25.0 => 2.5.26.0 Changelog: https://www.urbackup.org/client_changelog.html PR: 289279 MFH: 2025Q3 archivers/urbackup-client/Makefile | 9 +++------ archivers/urbackup-client/distinfo | 6 +++--- archivers/urbackup-client/files/patch-Makefile.am | 4 ++-- .../files/patch-cryptoplugin_src_files.cpp (new) | 11 +++++++++++ .../files/patch-libfastcgi_fastcgi.hpp (new) | 11 +++++++++++ .../files/patch-urbackupclient_lin__tokens.cpp (gone) | 11 ----------- archivers/urbackup-client/pkg-plist | 15 ++++++++------- 7 files changed, 38 insertions(+), 29 deletions(-)
A commit in branch 2025Q3 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=ddbf2805b0d3fb5d139813d08617f8d4982bb38b commit ddbf2805b0d3fb5d139813d08617f8d4982bb38b Author: ek <ek@purplehat.org> AuthorDate: 2025-09-03 22:13:39 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2025-09-03 22:18:18 +0000 archivers/urbackup-client: Update 2.5.25.0 => 2.5.26.0 Changelog: https://www.urbackup.org/client_changelog.html PR: 289279 MFH: 2025Q3 (cherry picked from commit d70c8a415dd3d89ac879a2bce2c37b914538ebee) archivers/urbackup-client/Makefile | 9 +++------ archivers/urbackup-client/distinfo | 6 +++--- archivers/urbackup-client/files/patch-Makefile.am | 4 ++-- .../files/patch-cryptoplugin_src_files.cpp (new) | 11 +++++++++++ .../files/patch-libfastcgi_fastcgi.hpp (new) | 11 +++++++++++ .../files/patch-urbackupclient_lin__tokens.cpp (gone) | 11 ----------- archivers/urbackup-client/pkg-plist | 15 ++++++++------- 7 files changed, 38 insertions(+), 29 deletions(-)
Created attachment 263460 [details] REINPLACE FIX: urbackup-client 2.5.26.0 patch Uploaded patch for update REINPLACE in the Makefile. Thanks again!
Thanks.
Thank you very much, Vladimir!