Bug 289445 - devel/py-click: Update to 8.3.0
Summary: devel/py-click: Update to 8.3.0
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Bartek Rutkowski
URL:
Keywords:
Depends on: 289597 289598 289601 289599 289603 289606
Blocks: 289596
  Show dependency treegraph
 
Reported: 2025-09-10 18:08 UTC by Thibault Payet
Modified: 2026-04-07 12:46 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (robak)


Attachments
git-formated patch (1.78 KB, patch)
2025-09-10 18:08 UTC, Thibault Payet
no flags Details | Diff
Patch for the port that had an upper limit on py-click that was < 8.2.2 (7.37 KB, patch)
2025-09-30 04:04 UTC, Thibault Payet
no flags Details | Diff
patch to update py-click to 8.3.0 (1.83 KB, patch)
2025-09-30 21:10 UTC, Thibault Payet
no flags Details | Diff
Patch for the ports that had an upper limit on py-click that was < 8.2.2 (3.24 KB, patch)
2025-11-21 04:18 UTC, Mark Linimon
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thibault Payet 2025-09-10 18:08:28 UTC
Created attachment 263681 [details]
git-formated patch

This would allow to update the py-pynitrokey and py-nitropy ports since they require a newer version of py-click

Given the number of dependencies, I am requesting an exp-run for this one. And some verification on the update since the build framework changed from setup.py to pyproject.toml one.
Comment 1 Antoine Brodin freebsd_committer freebsd_triage 2025-09-10 18:33:02 UTC
I don't think an exp-run is needed,  but you have to take care of the ports that specify maximum versions like:

comms/py-spsdk/Makefile:                ${PYTHON_PKGNAMEPREFIX}click>=7.1,<8.2:devel/py-click@${PY_FLAVOR} \
devel/py-python-semantic-release/Makefile:RUN_DEPENDS=  ${PYTHON_PKGNAMEPREFIX}click>=8.1.0<8.2:devel/py-click@${PY_FLAVOR} \
security/py-pyhanko/Makefile:           ${PYTHON_PKGNAMEPREFIX}click>=8.1.3<8.2.0:devel/py-click@${PY_FLAVOR} \
textproc/py-mkdocs-material/Makefile:           ${PYTHON_PKGNAMEPREFIX}click<8.2.2:devel/py-click@${PY_FLAVOR} \
www/mitmproxy/Makefile:         ${PYTHON_PKGNAMEPREFIX}click>=7.0<8.1:devel/py-click@${PY_FLAVOR} \
Comment 2 Thibault Payet 2025-09-30 04:04:41 UTC
Created attachment 264163 [details]
Patch for the port that had an upper limit on py-click that was < 8.2.2

This build fine, except for the two ports that already does not build without it:

textproc/py-elasticsearch-curator

and

www/mitmproxy
Comment 3 Kai Knoblich freebsd_committer freebsd_triage 2025-09-30 10:14:57 UTC
Release 8.3.0 of py-click should be used right away, because version 8.2.2 was yanked and has led to some regressions (see linked GitHub issues at "See also").
Comment 4 Thibault Payet 2025-09-30 21:10:52 UTC
Created attachment 264176 [details]
patch to update py-click to 8.3.0

Thanks for the heads-up, here the updated version
Comment 5 Thibault Payet 2025-10-01 21:47:22 UTC
For the moment, we have the following blocker:

- py-python-semantic-release
- py-pyhanko
- py-mkdocs-material (should be fine in two release)

So for now, until it is resolved, we can't do the update.
Comment 6 Thibault Payet 2025-10-28 12:56:32 UTC
As of now, the only blocker to this update is:

- py-python-semantic-release

Would it be viable to create a py-click-82 port in the meantime ?

What do you think Bartek ?
Comment 7 Mark Linimon freebsd_committer freebsd_triage 2025-11-21 04:18:09 UTC
Created attachment 265544 [details]
Patch for the ports that had an upper limit on py-click that was < 8.2.2

^Triage: make this apply to the current version of the ports tree.
Comment 8 Siva Mahadevan freebsd_committer freebsd_triage 2026-01-02 23:14:59 UTC
This also blocks the upgrade of https://grimoire.freebsd.org, since one of its dependencies (sortinghat) requires a newer py-click.

What's the status of this now?
Comment 9 Thibault Payet 2026-01-04 09:53:39 UTC
(In reply to Siva Mahadevan from comment #8)
There is still one blocker for the update, see my previous post.

The only ways forward would be to copy this port to py-click-82, so that py-python-semantic-release does not break.
And then upgrade py-click to 8.3.0 for all the other ports.
Comment 10 Siva Mahadevan freebsd_committer freebsd_triage 2026-01-04 19:27:03 UTC
(In reply to Thibault Payet from comment #9)
Let's hold off on copying this port to an unnecessary py-click-82. I've submitted https://github.com/python-semantic-release/python-semantic-release/pull/1411 upstream (tests pass), so we shouldn't have any blockers after this.
Comment 11 Jesús Daniel Colmenares Oviedo freebsd_committer freebsd_triage 2026-03-11 19:15:57 UTC
Any news on this? I updated my own port tree to have click (8.3.1) because typer needs it (which in turn is needed for rendercv), and it works fine.
Comment 12 Thibault Payet 2026-03-14 14:49:18 UTC
(In reply to Jesús Daniel Colmenares Oviedo from comment #11)
We are still waiting for python-semantic-release, which got a patch on 2026-03-03 here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289598
Comment 13 Po-Chuan Hsieh freebsd_committer freebsd_triage 2026-04-07 12:46:46 UTC
1. What is the final patch for py-click? I believe we should commit 8.3.1 instead of 8.3.0. Regarding attachment 264176 [details], please sort USE_PYTHON.

2. At least databases/py-dbt-semantic-interfaces and databases/py-pgcli are not handled in this PR (attachment 265544 [details]). A simple grep shows the following lines:

/usr/ports/comms/py-spsdk/Makefile:             ${PYTHON_PKGNAMEPREFIX}click>=7.1,<8.2:devel/py-click@${PY_FLAVOR} \
/usr/ports/databases/py-dbt-semantic-interfaces/Makefile:               ${PYTHON_PKGNAMEPREFIX}click>=7<8.3:devel/py-click@${PY_FLAVOR} \
/usr/ports/databases/py-pgcli/Makefile:         ${PYTHON_PKGNAMEPREFIX}click>=4.1<8.1.8:devel/py-click@${PY_FLAVOR} \
/usr/ports/devel/py-python-semantic-release/Makefile:RUN_DEPENDS=       ${PYTHON_PKGNAMEPREFIX}click>=8.1.0<8.2:devel/py-click@${PY_FLAVOR} \

I've patched databases/py-pgcli to allow py-click 8.3.1 in ports d73edc1fbace2742e56d53c24d1b2fce3efb155f.