Bug 289685 - net/libmateweather: yet another fix for METAR
Summary: net/libmateweather: yet another fix for METAR
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-09-18 19:22 UTC by Ale
Modified: 2025-11-11 02:12 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (gnome)


Attachments
metar: Update AviationWeather URL (1.34 KB, patch)
2025-09-18 19:22 UTC, Ale
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ale 2025-09-18 19:22:05 UTC
Created attachment 263909 [details]
metar: Update AviationWeather URL

Waiting for the release of a new version, here's a new fix for METAR.
Source: https://github.com/mate-desktop/libmateweather/issues/135
Tested on 14.3-STABLE.
Comment 1 rkoberman 2025-11-02 21:18:58 UTC
Is anything happening on this ticket? Looking at the upstream, it looks like the update was committed in September and the ticket closed, but it's still not working for me with Ale's uncommitted patch.
Comment 2 Ale 2025-11-08 10:54:21 UTC
(In reply to rkoberman from comment #1)
Isn't it working for you?
I'm using x11/mate and after rebuilding net/libmateweather with the patch I added  here as attachment both Clock applet and Weather Report applet are working as expected as you can see here:
https://i.postimg.cc/kgqBQkbf/Screenshot-at-2025-11-08-11-17-15.png
Comment 3 rkoberman 2025-11-09 00:08:26 UTC
(In reply to Ale from comment #2)
Issue resolved.

# git < weather-fix.patch

The problem is that the patch did not actually apply correctly. No error reported, but, since the net/libmateweather/files directory did not exist, the patch to metar.c was dropped into /user/ports/. I created a 'files' directory and moved the patch there. Rebuilt and it works again. Looks to me like a "new file mode" does not create a new directory and that causes to file to be dropped into the current directory; in my case, /usr/ports. I'll admit that I have never run into this.
Comment 4 Ale 2025-11-09 18:23:07 UTC
(In reply to rkoberman from comment #3)
What with the following?
# git apply weather-fix.patch
Comment 5 rkoberman 2025-11-09 18:54:34 UTC
Guess I'll start using 'git apply" from now on for 'git diff' patches. It worked perfectly.

So many tools available in git that I have never bothered to learn about.
Comment 6 commit-hook freebsd_committer freebsd_triage 2025-11-11 02:11:21 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f3fab2d229f08a40dc79410a912fadafe08175c0

commit f3fab2d229f08a40dc79410a912fadafe08175c0
Author:     Eric Turgeon <ericbsd@FreeBSD.org>
AuthorDate: 2025-11-10 23:43:57 +0000
Commit:     Eric Turgeon <ericbsd@FreeBSD.org>
CommitDate: 2025-11-11 02:10:23 +0000

    net/libmateweather: Updated from version to 1.28.1

    ALso swtiched the ports to GitHub since that package was not added to
    the 1.28.1 in https://pub.mate-desktop.org/releases/1.28/.

    PR:             289685
    Reported by:    Ale

 net/libmateweather/Makefile | 17 ++++++++++-------
 net/libmateweather/distinfo |  6 +++---
 2 files changed, 13 insertions(+), 10 deletions(-)