Bug 289920 - virtual oss - CUSE needed after transition into base conflicts with WITHOUT_CUSE=yes
Summary: virtual oss - CUSE needed after transition into base conflicts with WITHOUT_C...
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 16.0-CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Christos Margiolis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-09-30 16:03 UTC by Ralf Wenk
Modified: 2025-09-30 18:51 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf Wenk 2025-09-30 16:03:26 UTC 
Hello,

I am using WITHOUT_CUSE=yes in some VM installations.

As virtual OSS, e.g. virtual_oss/virtual_oss/int.h, tries to include cuse.h
the compilation fails because of WITHOUT_CUSE=yes there is no cuse.h installed.

As there is no WITHOUT_OSS switch it is impossible to update the mentioned VMs
at the moment.

Ralf
Comment 1 Christos Margiolis freebsd_committer freebsd_triage 2025-09-30 16:57:47 UTC 
Submitted patch for review [1]. I will try to commit this today. Thanks for reporting.

[1] https://reviews.freebsd.org/D52807
Comment 2 commit-hook freebsd_committer freebsd_triage 2025-09-30 17:02:49 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=f040ee6e407832fc9f08d85cd792d1cfb8104976

commit f040ee6e407832fc9f08d85cd792d1cfb8104976
Author:     Christos Margiolis <christos@FreeBSD.org>
AuthorDate: 2025-09-30 17:01:37 +0000
Commit:     Christos Margiolis <christos@FreeBSD.org>
CommitDate: 2025-09-30 17:01:37 +0000

    virtual_oss: Do not build if WITHOUT_CUSE is set

    PR:             289920
    Fixes:          9cab9fde5eda ("virtual_oss: Port to base")
    Sponsored by:   The FreeBSD Foundation
    MFC after:      1 day
    Reviewed by:    emaste
    Differential Revision:  https://reviews.freebsd.org/D52807

 lib/Makefile             | 4 ++--
 libexec/rc/rc.d/Makefile | 7 ++++++-
 usr.sbin/Makefile        | 2 +-
 3 files changed, 9 insertions(+), 4 deletions(-)
Comment 3 Christos Margiolis freebsd_committer freebsd_triage 2025-09-30 17:03:17 UTC 
Committed: https://cgit.freebsd.org/src/commit/?id=f040ee6e407832fc9f08d85cd792d1cfb8104976

Please test with latest main and let me know.
Comment 4 Ralf Wenk 2025-09-30 18:51:35 UTC 
(In reply to Christos Margiolis from comment #3)
make buildworld just completed. So your patch fixes it.

Thank you.

Ralf