Created attachment 264224 [details] Update to 25.10.0 Remove DISTVERSIONPREFIX, DISTVERSIONSUFFIX and use GH_TAGNAME.
(In reply to mew14930xvi from comment #0) > Remove DISTVERSIONPREFIX, DISTVERSIONSUFFIX and use GH_TAGNAME. Why? Current way look better…
(In reply to Vladimir Druzenko from comment #1) I prefer fewer lines.
(In reply to mew14930xvi from comment #2) What do you think about: GH_TAGNAME=v${DISTVERSION}-Release.2cfc2736 ?
I prefer simple. Is there a problem with the ID?
Please follow Porter's Handbook § 5.4.3 "USE_GITHUB", in particular see examples 17 and 18. "I prefer fewer lines" is not a valid argument for deviating from policy.
(In reply to Robert Clausecker from comment #5) You added the port using TAGNAME. https://cgit.freebsd.org/ports/commit/textproc/goldendict-ng?id=90396abe6ba1d754808eac9286e372650e11ac7d
(In reply to mew14930xvi from comment #6) Indeed, I missed that back then. I should have not approved it like this.
Created attachment 264252 [details] Add SPEECH option.
Created attachment 264255 [details] update to 25.10.0 Remove RUN_DEPENDS=stardict-rptts.
Created attachment 264257 [details] Update to 25.10.1 https://github.com/xiaoyifang/goldendict-ng/releases/tag/v25.10.1-Release.85f9a3d5
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=8311e0bba2d283983cd479f117d7e2bd0af24468 commit 8311e0bba2d283983cd479f117d7e2bd0af24468 Author: mew14930xvi <mew14930xvi@inbox.lv> AuthorDate: 2025-10-03 11:20:00 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2025-10-03 11:25:11 +0000 textproc/goldendict-ng: Update 25.06.0 => 25.10.1 Changelogs: https://github.com/xiaoyifang/goldendict-ng/releases/tag/v25.10.0-Release.2cfc2736 https://github.com/xiaoyifang/goldendict-ng/releases/tag/v25.10.1-Release.85f9a3d5 Add SPEECH option. PR: 289954 MFH: 2025Q4 textproc/goldendict-ng/Makefile | 13 ++++++++----- textproc/goldendict-ng/distinfo | 6 +++--- 2 files changed, 11 insertions(+), 8 deletions(-)
A commit in branch 2025Q4 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=f8b9baed1ff5339e2c99e63092a7ec3442e7b049 commit f8b9baed1ff5339e2c99e63092a7ec3442e7b049 Author: mew14930xvi <mew14930xvi@inbox.lv> AuthorDate: 2025-10-03 11:20:00 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2025-10-03 11:26:50 +0000 textproc/goldendict-ng: Update 25.06.0 => 25.10.1 Changelogs: https://github.com/xiaoyifang/goldendict-ng/releases/tag/v25.10.0-Release.2cfc2736 https://github.com/xiaoyifang/goldendict-ng/releases/tag/v25.10.1-Release.85f9a3d5 Add SPEECH option. PR: 289954 MFH: 2025Q4 (cherry picked from commit 8311e0bba2d283983cd479f117d7e2bd0af24468) textproc/goldendict-ng/Makefile | 13 ++++++++----- textproc/goldendict-ng/distinfo | 6 +++--- 2 files changed, 11 insertions(+), 8 deletions(-)
Thanks.
Created attachment 264271 [details] Drop maintainership
Drop maintainership.
Created attachment 264554 [details] drop maintainership
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=6634e68917079e76f6a0005767529dc19a846253 commit 6634e68917079e76f6a0005767529dc19a846253 Author: mew14930xvi <mew14930xvi@inbox.lv> AuthorDate: 2025-10-03 19:13:47 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2025-10-14 14:56:32 +0000 textproc/goldendict-ng: Drop maintainership PR: 289954 textproc/goldendict-ng/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
2025Q4?
(In reply to mew14930xvi from comment #18) Not really needed. When in doubt, the main branch is relevant for who maintains the port.
Any suggestions to suppress showing Maintainer in pkg info in quartely?