Bug 290461 - www/freenginx: There is no explicit explanation regarding the changes from nginx.conf to freenginx.conf
Summary: www/freenginx: There is no explicit explanation regarding the changes from ng...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jochen Neumeister
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-10-24 04:50 UTC by takefu
Modified: 2026-05-26 07:47 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (joneum)


Attachments
nginx.in.patch (548 bytes, patch)
2025-10-24 06:35 UTC, takefu
no flags Details | Diff
nginx.in.patch (550 bytes, patch)
2025-11-16 00:33 UTC, Mark Linimon
no flags Details | Diff
freenginx-1.29.3.patch (1.52 KB, patch)
2025-11-17 16:37 UTC, takefu
joneum: maintainer-approval-
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description takefu 2025-10-24 04:50:21 UTC
The configuration file was not loaded during this update.
I believe this should be documented in UPDATING.

You must execute one of the following commands.
  cd /usr/local/etc/nginx/ ; ln -s nginx.conf freenginx.conf
  sysrc required_files=/usr/local/etc/nginx/nginx.conf

bug #286607
Comment 1 takefu 2025-10-24 06:35:54 UTC
Created attachment 264827 [details]
nginx.in.patch

There was a slight error.

The specified directory in configure is not consistent with the rc.d scripts.

It appears that the section where %%ETCDIR%% should be used instead of %%PREFIX%% has not been updated.
files/nginx.in
Comment 2 takefu 2025-10-24 07:01:50 UTC
The update procedure after applying the nginx.in patch is as follows.
Of course, backing up nginx.conf is essential.

pkg delete www/freenginx
mv /usr/local/etc/nginx /usr/local/etc/freenginx
cd /usr/ports/www/freenginx
make install
service nginx restart
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2025-11-16 00:33:09 UTC
Created attachment 265439 [details]
nginx.in.patch

^Triage: rebase patch.
Comment 4 takefu 2025-11-17 16:37:02 UTC
Created attachment 265474 [details]
freenginx-1.29.3.patch

required_files directory optimization
Patch updated for 1.29.3
Comment 5 Jochen Neumeister freebsd_committer freebsd_triage 2025-11-17 18:08:09 UTC
(In reply to takefu from comment #4)

freenginx-devel is already at 1.29.3
This is about freenginx, and 1.28.0 is correct.
Comment 6 takefu 2025-11-18 23:31:26 UTC
(In reply to Jochen Neumeister from comment #5)

I had completely forgotten about the existence of -devel.
``files/nginx.in''
Please fix this file change during the next major update.
Comment 7 commit-hook freebsd_committer freebsd_triage 2026-05-26 07:47:06 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=220ba8ebf46b2b5b2a9dc4d91169c0e5a9d5f211

commit 220ba8ebf46b2b5b2a9dc4d91169c0e5a9d5f211
Author:     Takefu <takefu@airport.fm>
AuthorDate: 2026-05-26 07:44:59 +0000
Commit:     Jochen Neumeister <joneum@FreeBSD.org>
CommitDate: 2026-05-26 07:44:59 +0000

    www/freenginx: fix rc script required_files path

    Use %%ETCDIR%%/nginx.conf in the rc script instead of the
    obsolete hardcoded %%PREFIX%%/etc/nginx/freenginx.conf path.

    The port is configured with:

    --prefix=/usr/local/etc/freenginx
    --conf-path=/usr/local/etc/freenginx/nginx.conf

    The previous required_files setting no longer matched the
    actual configuration file location and could prevent the
    service from starting after installation or upgrade.

    PR:     290461
    Sponsored by:   Netzkommune GmbH

 www/freenginx/files/nginx.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)