Created attachment 264910 [details] patch
Thanks for submitting. This looks good overall, with one exception. You're keeping all the port flavors, but you're not installing any byte-compiled files. I've included a proposed change in the inline diff below. If you're okay with it, I can incorporate it on commit. Unless there's a compelling reason to only install the .el files, let's also install the .elc files, which requires keeping the flavors. I have similar comments on your other submissions, so I'll wait to hear back from you here before commenting on those. diff --git a/editors/orderless.el/Makefile b/editors/orderless.el/Makefile index c1d7b49fc223..e79c9904dd9c 100644 --- a/editors/orderless.el/Makefile +++ b/editors/orderless.el/Makefile @@ -18,14 +18,15 @@ GH_ACCOUNT= oantolin GH_PROJECT= orderless NO_ARCH= yes -NO_BUILD= yes OPTIONS_DEFINE= DOCS +do-build: + ${EMACS_CMD} -q --batch -L ${WRKSRC} -f batch-byte-compile ${WRKSRC}/*.el + do-install: @${MKDIR} ${STAGEDIR}${PREFIX}/${EMACS_SITE_LISPDIR} - ${INSTALL_DATA} ${WRKSRC}/orderless.el ${STAGEDIR}${PREFIX}/${EMACS_SITE_LISPDIR} - ${INSTALL_DATA} ${WRKSRC}/orderless-kwd.el ${STAGEDIR}${PREFIX}/${EMACS_SITE_LISPDIR} + ${INSTALL_DATA} ${WRKSRC}/*.el ${WRKSRC}/*.elc ${STAGEDIR}${PREFIX}/${EMACS_SITE_LISPDIR} post-install-DOCS-on: @${MKDIR} ${STAGEDIR}${DOCSDIR} diff --git a/editors/orderless.el/pkg-plist b/editors/orderless.el/pkg-plist index 758408b9ea46..5e2866dbb647 100644 --- a/editors/orderless.el/pkg-plist +++ b/editors/orderless.el/pkg-plist @@ -1,3 +1,5 @@ %%EMACS_SITE_LISPDIR%%/orderless-kwd.el +%%EMACS_SITE_LISPDIR%%/orderless-kwd.elc %%EMACS_SITE_LISPDIR%%/orderless.el +%%EMACS_SITE_LISPDIR%%/orderless.elc %%PORTDOCS%%%%DOCSDIR%%/README.org
I believe it needs flavors because it depends on compat.el which needs flavors, I wasn’t able to find a way to depend on compat.el but not have flavors. I could be overlooking something of course. In any case, I have no objections to building the .elc files as part of it. Thank you!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=5278c00a96c679e6e5162615974757ff27519d47 commit 5278c00a96c679e6e5162615974757ff27519d47 Author: Pat Maddox <pat@patmaddox.com> AuthorDate: 2025-10-25 00:11:22 +0000 Commit: Joseph Mingrone <jrm@FreeBSD.org> CommitDate: 2025-11-17 04:38:26 +0000 editors/orderless.el: Completion style that matches multiple regexps This package provides an orderless completion style that divides the pattern into space-separated components, and matches candidates that match all of the components in any order. Each component can match in any one of several ways: literally, as a regexp, as an initialism, in the flex style, or as multiple word prefixes. By default, regexp and literal matches are enabled. WWW: https://github.com/oantolin/orderless PR: 290541 editors/Makefile | 1 + editors/orderless.el/Makefile (new) | 34 ++++++++++++++++++++++++++++++++++ editors/orderless.el/distinfo (new) | 3 +++ editors/orderless.el/pkg-descr (new) | 6 ++++++ editors/orderless.el/pkg-plist (new) | 3 +++ 5 files changed, 47 insertions(+)
Pushed. If you notice any issues, please open a new bug report. Thanks again for contributing these elisp ports.