Bug 290586 - converters/libiconv: Strip shared library
Summary: converters/libiconv: Strip shared library
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-10-27 19:42 UTC by Po-Chuan Hsieh
Modified: 2025-11-11 05:51 UTC (History)
1 user (show)

See Also:
arrowd: maintainer-feedback+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Po-Chuan Hsieh freebsd_committer freebsd_triage 2025-10-27 19:42:33 UTC 
Patch is available at https://people.FreeBSD.org/~sunpoet/patch/converters-libiconv.txt

The proposed commit log is as follows:
converters/libiconv: Strip shared library

- Bump PORTREVISION for package change
Comment 1 Gleb Popov freebsd_committer freebsd_triage 2025-10-28 08:14:36 UTC 
This looks like a bug in the build system, because the port properly uses INSTALL_TARGET=install-strip.

Rather than adding workarounds I'd prefer first updating the port to the latest version to see if the problem goes away.

I'll put this into my TODO.
Comment 2 Gleb Popov freebsd_committer freebsd_triage 2025-11-08 10:22:35 UTC 
Updating to 1.18 did not fix the issue, so I think this is good to go.

(I tried to research this, but libiconv's build system is convoluted, so I failed to figure out the root cause).
Comment 3 Po-Chuan Hsieh freebsd_committer freebsd_triage 2025-11-08 19:54:38 UTC 
(In reply to Gleb Popov from comment #2)

I did try to find out why INSTALL_TARGET=install-strip does not work at the beginning but did not succeed. Therefore, I chose the workaround.
Comment 4 commit-hook freebsd_committer freebsd_triage 2025-11-09 16:44:13 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7c8e5db9b6d9ed6ae31d6c3d61fa02093e677c88

commit 7c8e5db9b6d9ed6ae31d6c3d61fa02093e677c88
Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
AuthorDate: 2025-11-09 16:27:06 +0000
Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2025-11-09 16:32:45 +0000

    converters/libiconv: Strip shared library

    - Bump PORTREVISION for package change

    PR:             290586
    Approved by:    arrowd

 converters/libiconv/Makefile | 4 ++++
 1 file changed, 4 insertions(+)
Comment 5 Po-Chuan Hsieh freebsd_committer freebsd_triage 2025-11-11 05:51:04 UTC 
Committed. Thanks.