Bug 290589 - devel/benchmark: Use googletest from ports tree for testing
Summary: devel/benchmark: Use googletest from ports tree for testing
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-10-27 19:54 UTC by Po-Chuan Hsieh
Modified: 2025-11-11 08:33 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (yuri)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Po-Chuan Hsieh freebsd_committer freebsd_triage 2025-10-27 19:54:54 UTC 
Patch is available at https://people.FreeBSD.org/~sunpoet/patch/devel-benchmark.txt

The proposed commit log is as follows:
devel/benchmark: Use googletest from ports tree for testing

- Clean up Makefile
  - Use TEST_DEPENDS
  - Disable BENCHMARK_USE_BUNDLED_GTEST
  - Remove unneeded GH_TUPLE

100% tests passed, 0 tests failed out of 80
Comment 1 commit-hook freebsd_committer freebsd_triage 2025-11-11 07:21:30 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=980e3d3db765e61edbf26f5ebdc02c7ad2c23c5d

commit 980e3d3db765e61edbf26f5ebdc02c7ad2c23c5d
Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
AuthorDate: 2025-11-11 07:13:28 +0000
Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2025-11-11 07:17:10 +0000

    devel/benchmark: Use googletest from ports tree for testing

    - Clean up Makefile
      - Use TEST_DEPENDS
      - Disable BENCHMARK_USE_BUNDLED_GTEST
      - Remove unneeded GH_TUPLE

    100% tests passed, 0 tests failed out of 80

    PR:             290589
    Approved by:    maintainer (timeout, 14 days)

 devel/benchmark/Makefile | 8 ++++----
 devel/benchmark/distinfo | 2 --
 2 files changed, 4 insertions(+), 6 deletions(-)
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2025-11-11 08:33:55 UTC 
Committed. Thanks.