Bug 290593 - devel/re2c: Update to 4.3
Summary: devel/re2c: Update to 4.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-10-27 20:06 UTC by Po-Chuan Hsieh
Modified: 2025-11-11 08:33 UTC (History)
12 users (show)

See Also:
chalpin: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Po-Chuan Hsieh freebsd_committer freebsd_triage 2025-10-27 20:06:12 UTC
Patch is available at https://people.FreeBSD.org/~sunpoet/patch/devel-re2c.txt

The proposed commit log is as follows:
devel/re2c: Update to 4.3

- Update WWW
- Remove unnecessary substitution
- Cosmetic change
- Request maintainership

Changes:	https://github.com/skvadrik/re2c/blob/master/CHANGELOG
		https://re2c.org/releases/release_notes.html
Comment 1 Paavo-Einari Kaipila 2025-10-28 04:25:14 UTC
Corey has kept this port with several high-profile consumers running for 16+ years and he usually reacts to PRs. I do not think it needs another maintainer.

Due to bug #289428, timing of it's commit just hours before quarterly branch, plus some other factors not related to that particular case, I CC'd maintainers of consumers of this.
Comment 2 Corey Halpin 2025-10-28 13:13:01 UTC
Patch looks good to me, passes `poudriere testport`, and produces no warnings from `portlint`.

After installing the built package, `sa-compile` succeeds.

I approve this patch!

As for maintainership, thanks Paavo-Einari for your kind words. However, sunpoet@'s observation that I've not been following `re2c` releases terribly closely in recent years is also entirely correct. I'm happy to keep maintaining the port if it's helpful, but I'm also happy to hand over maintainership to someone else who is following upstream more closely than I have been.
Comment 3 Paavo-Einari Kaipila 2025-10-28 13:54:59 UTC
(In reply to Corey Halpin from comment #2)

I find you maintaining this helpful, because it ensures that there are at least two people checking things before updates and they are not just blindly committed. And if anyone has any issues with this port, you can be trusted to react in a reasonable time.
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2025-10-29 22:03:17 UTC
(In reply to Corey Halpin from comment #2)
You've done a good job and I don't see any issues in you keeping maintaining it.

The layout and variables are also fine but feel free to switch if you want to.
I would recommend adding "CXXFLAGS+=      -Wno-switch-default" to reduce the noise during build.
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2025-10-29 22:05:35 UTC
(In reply to Paavo-Einari Kaipila from comment #3)
To be clear, we don't have to concept of co-maintaining in tree and as Corey is responsive I don't see any need to switch maintainership.
Comment 6 Paavo-Einari Kaipila 2025-10-29 22:43:53 UTC
(In reply to Daniel Engberg from comment #5)

By two people I meant Corey and the one who happens to commit any given patch
Comment 7 Paavo-Einari Kaipila 2025-10-29 23:28:05 UTC
(In reply to Daniel Engberg from comment #5)

The word "another" might have also been a bit misleading. It has several meanings in different contexts. It meant "new" or "someone else" in this case.
Comment 8 commit-hook freebsd_committer freebsd_triage 2025-11-11 07:21:27 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=793bdd0619387231cc6a68ed524715ff2b197d0d

commit 793bdd0619387231cc6a68ed524715ff2b197d0d
Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
AuthorDate: 2025-11-11 07:13:32 +0000
Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2025-11-11 07:17:11 +0000

    devel/re2c: Update to 4.3

    - Update WWW
    - Remove unnecessary substitution
    - Cosmetic change
    - Take maintainership

    Changes:        https://github.com/skvadrik/re2c/blob/master/CHANGELOG
                    https://re2c.org/releases/release_notes.html
    PR:             290593
    Approved by:    maintainer (timeout, 14 days)

 devel/re2c/Makefile  | 25 +++++++++++++------------
 devel/re2c/distinfo  |  6 +++---
 devel/re2c/pkg-plist | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 65 insertions(+), 15 deletions(-)
Comment 9 Po-Chuan Hsieh freebsd_committer freebsd_triage 2025-11-11 07:40:37 UTC
(In reply to commit-hook from comment #8)

That should be "Approved by:    chalpin@cs.wisc.edu (maintainer)".
See https://lists.freebsd.org/archives/dev-commits-ports-main/2025-November/169687.html
Comment 10 Po-Chuan Hsieh freebsd_committer freebsd_triage 2025-11-11 08:33:57 UTC
Committed. Thanks.