Patch is available at https://people.FreeBSD.org/~sunpoet/patch/www-gallery-dl.txt The proposed commit log is as follows: www/gallery-dl: Use upstream release tarball - Add LICENSE_FILE - Add USE_PYTHON=noflavors - Convert to USE_PYTHON=pep517 - Bump PORTREVISION for package change The release tarball includes generated manpages and completion files.
(In reply to Po-Chuan Hsieh from comment #0) > + https://github.com/mikf/gallery-dl/releases/download/v${DISTVERSION}/ Replace gallery-dl with ${PORTNAME} > +DISTNAME= gallery_dl-${DISTVERSION} Replace gallery_dl with ${PORTNAME:S/-/_/} > +LICENSE_FILE= ${WRKSRC}/LICENSE OK. A long time ago there was a recommendation to avoid duplicating licenses that exist under Templates/. > -BUILD_DEPENDS= ${PYTHON_PKGNAMEPREFIX}sqlite3>0:databases/py-sqlite3@${PY_FLAVOR} Still required by tests but after applying the patch tests no longer run. Creating empty tests/__init__.py exposes tests but without test/results/ directory (site) extractor tests will fail. > -NO_ARCH= yes Moving one line into its own section via newlines hinders readability. If you just want to pacify portclippy put the line at the end of the existing section (just after USE_PYTHON).
(In reply to Jan Beich from comment #1) Regarding the BUILD_DEPENDS, it is actually a TEST_DEPENDS. And since it is already declared in RUN_DEPENDS, there is no need to put it in TEST_DEPENDS again. I've prepared patch v2 at https://people.FreeBSD.org/~sunpoet/patch/www-gallery-dl-v2.txt It includes DISTNAME, NO_ARCH and 'make test' changes. % make test ... Ran 324 tests in 0.985s FAILED (errors=1, skipped=11) *** Error code 1
Approved. (In reply to Po-Chuan Hsieh from comment #2) > + https://github.com/mikf/gallery-dl/releases/download/v${DISTVERSION}/ Missed in v2. Replace gallery-dl with ${PORTNAME} > Ran 324 tests in 0.985s > > FAILED (errors=1, skipped=11) Thanks. Should be good enough.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=795967709c1442c820d95432133bd813a446f083 commit 795967709c1442c820d95432133bd813a446f083 Author: Po-Chuan Hsieh <sunpoet@FreeBSD.org> AuthorDate: 2025-11-09 16:27:09 +0000 Commit: Po-Chuan Hsieh <sunpoet@FreeBSD.org> CommitDate: 2025-11-09 16:32:45 +0000 www/gallery-dl: Use upstream release tarball - Add LICENSE_FILE - Add USE_PYTHON=noflavors - Convert to USE_PYTHON=pep517 - Fix 'make test' (after using release tarball) - Bump PORTREVISION for package change The release tarball includes generated manpages and completion files. PR: 290610 Approved by: jbeich (maintainer) www/gallery-dl/Makefile | 22 +++++++++++----------- www/gallery-dl/distinfo | 6 +++--- 2 files changed, 14 insertions(+), 14 deletions(-)
Committed. Thanks.