Bug 290708 - /usr/share/man/man5/pam.d.5.gz installed twice building packages
Summary: /usr/share/man/man5/pam.d.5.gz installed twice building packages
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: misc (show other bugs)
Version: 15.0-STABLE
Hardware: Any Any
: --- Affects Some People
Assignee: Lexi Winter
URL: https://reviews.freebsd.org/D53512
Keywords:
Depends on:
Blocks:
 
Reported: 2025-11-01 00:27 UTC by Ed Maste
Modified: 2025-11-05 19:38 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Maste freebsd_committer freebsd_triage 2025-11-01 00:27:57 UTC
Found by Cirrus-CI https://cirrus-ci.com/task/4927148705710080

su user -c "/usr/libexec/flua tools/pkgbase/metalog_reader.lua -c /usr/obj/$(pwd -P)/${TARGET}.${TARGET_ARCH}/worldstage/METALOG"
error: ./usr/share/man/man5/pam.d.5.gz file repeated with same meta: line 37554,37649
Comment 1 Lexi Winter freebsd_committer freebsd_triage 2025-11-01 13:33:53 UTC
i'm assuming this was meant to be filed against 15.0, since the relevant code doesn't exist in stable/14.
Comment 2 commit-hook freebsd_committer freebsd_triage 2025-11-01 13:41:09 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=a1806e6ff37a606277ab9657b951e918164e9f63

commit a1806e6ff37a606277ab9657b951e918164e9f63
Author:     Lexi Winter <ivy@FreeBSD.org>
AuthorDate: 2025-11-01 13:38:26 +0000
Commit:     Lexi Winter <ivy@FreeBSD.org>
CommitDate: 2025-11-01 13:38:26 +0000

    static_libpam: Don't install pam.d.5 twice

    static_libpam's Makefile includes libpam's Makefile after setting some
    variables (like MAN) to empty to avoid installing the manpages twice.
    After commit 031e711647c3, it neglected to do this for MANNODEVLINKS,
    causing pam.d.5.gz to be installed twice.  This is harmless for
    installworld, but breaks some things that rely on METALOG (NO_ROOT
    installs) since it causes two METALOG entries to be generated for
    the same file.

    Fixes:  031e711647c3 ("packages: Install development manpages in the -dev package")
    MFC after:      3 days
    PR:             290708
    Reported by:    emaste
    Reviewed by:    emaste
    Sponsored by:   https://www.patreon.com/bsdivy
    Differential Revision:  https://reviews.freebsd.org/D53512

 lib/libpam/static_libpam/Makefile | 1 +
 1 file changed, 1 insertion(+)
Comment 3 Ed Maste freebsd_committer freebsd_triage 2025-11-01 17:17:50 UTC
Confirmed fixed in https://cirrus-ci.com/task/4899659606392832
Comment 4 Lexi Winter freebsd_committer freebsd_triage 2025-11-04 00:06:04 UTC
this hasn't been MFC'd yet, so closing the bug may be premature.  i probably should have set mfc-stable15?, sorry.

however i'll MFC it either way, so it doesn't really matter.
Comment 5 commit-hook freebsd_committer freebsd_triage 2025-11-04 01:22:34 UTC
A commit in branch stable/15 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=92a081bc2d1ad2c06749d5fbcf31697db05a2001

commit 92a081bc2d1ad2c06749d5fbcf31697db05a2001
Author:     Lexi Winter <ivy@FreeBSD.org>
AuthorDate: 2025-11-01 13:38:26 +0000
Commit:     Lexi Winter <ivy@FreeBSD.org>
CommitDate: 2025-11-04 01:12:11 +0000

    static_libpam: Don't install pam.d.5 twice

    static_libpam's Makefile includes libpam's Makefile after setting some
    variables (like MAN) to empty to avoid installing the manpages twice.
    After commit 031e711647c3, it neglected to do this for MANNODEVLINKS,
    causing pam.d.5.gz to be installed twice.  This is harmless for
    installworld, but breaks some things that rely on METALOG (NO_ROOT
    installs) since it causes two METALOG entries to be generated for
    the same file.

    Fixes:  031e711647c3 ("packages: Install development manpages in the -dev package")
    MFC after:      3 days
    PR:             290708
    Reported by:    emaste
    Reviewed by:    emaste
    Sponsored by:   https://www.patreon.com/bsdivy
    Differential Revision:  https://reviews.freebsd.org/D53512

    (cherry picked from commit a1806e6ff37a606277ab9657b951e918164e9f63)

 lib/libpam/static_libpam/Makefile | 1 +
 1 file changed, 1 insertion(+)
Comment 6 Lexi Winter freebsd_committer freebsd_triage 2025-11-04 01:28:52 UTC
i've mailed re@ to ask that this be merged into releng/15.0.
Comment 7 commit-hook freebsd_committer freebsd_triage 2025-11-05 19:38:49 UTC
A commit in branch releng/15.0 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=593f5b29ef7c79d09e39c2a32861d4ecdb9049ad

commit 593f5b29ef7c79d09e39c2a32861d4ecdb9049ad
Author:     Lexi Winter <ivy@FreeBSD.org>
AuthorDate: 2025-11-01 13:38:26 +0000
Commit:     Colin Percival <cperciva@FreeBSD.org>
CommitDate: 2025-11-05 19:36:18 +0000

    static_libpam: Don't install pam.d.5 twice

    static_libpam's Makefile includes libpam's Makefile after setting some
    variables (like MAN) to empty to avoid installing the manpages twice.
    After commit 031e711647c3, it neglected to do this for MANNODEVLINKS,
    causing pam.d.5.gz to be installed twice.  This is harmless for
    installworld, but breaks some things that rely on METALOG (NO_ROOT
    installs) since it causes two METALOG entries to be generated for
    the same file.

    Approved by:    re (cperciva)
    Fixes:  031e711647c3 ("packages: Install development manpages in the -dev package")
    MFC after:      3 days
    PR:             290708
    Reported by:    emaste
    Reviewed by:    emaste
    Sponsored by:   https://www.patreon.com/bsdivy
    Differential Revision:  https://reviews.freebsd.org/D53512

    (cherry picked from commit a1806e6ff37a606277ab9657b951e918164e9f63)
    (cherry picked from commit 92a081bc2d1ad2c06749d5fbcf31697db05a2001)

 lib/libpam/static_libpam/Makefile | 1 +
 1 file changed, 1 insertion(+)