Created attachment 265087 [details] Patch for py-brotli * Switch from PYPI to GitHub (new version not hosted on PYPI) * Simplify port Makefile Compile tested on FreeBSD 14.3-RELEASE (amd64) (make, make check-plist) Poudriere testport OK 13.5-RELEASE (amd64) Poudriere testport OK 13.5-RELEASE (i386) Poudriere testport OK 14.3-RELEASE (amd64)
*** Bug 290726 has been marked as a duplicate of this bug. ***
Because this and archivers/brotli are built from the same (original) source distribution, this could be turned to a slave port too. It would save a tiny bit of sunpoet's time for other ports and archivers/brotli wouldn't have an automatic blocker for future updates.
(In reply to Paavo-Einari Kaipila from comment #2) Yes, in theory but in this case it'll be more workarounds for it to work in the port Makefile than making it smaller because it's a slaveport.
Created attachment 265274 [details] Patch for py-brotli Minor adjustments
(In reply to Daniel Engberg from comment #4) The sdist is available on PYPI (maybe it is not there at the first time). I'll commit https://people.freebsd.org/~sunpoet/patch/archivers-py-brotli.txt instead.
Manifest.in is broken in your patch
I don't follow you.
(In reply to Po-Chuan Hsieh from comment #7) https://github.com/google/brotli/blob/v1.2.0/MANIFEST.in#L11 --> https://github.com/google/brotli/blob/v1.2.0/python/_brotli.c
In the mean time, as of the ports tree at main-n725933-c868fe1f9fcd: * archivers/brotli is updated to brotli-1.2.0,1 * archivers/py-brotli is at py311-brotli-1.1.0 * an attempt to build a package for archivers/py-brotli using poudriere with the ports tree at main-n725933-c868fe1f9fcd fails, claiming: ... =======================<phase: build-depends >============================ ===== env: USE_PACKAGE_DEPENDS_ONLY=1 USER=root UID=0 GID=0 ===> py311-brotli-1.1.0 depends on package: brotli>=1.1.0,1<1.1.0_99,1 - not found ===> Installing existing package /packages/All/brotli-1.2.0,1.pkg [freebeast.catwhisker.org] Installing brotli-1.2.0,1... [freebeast.catwhisker.org] Extracting brotli-1.2.0,1: .......... done ===> py311-brotli-1.1.0 depends on package: brotli>=1.1.0,1<1.1.0_99,1 - not found *** Error code 1 .... (which causes ports that depend on archivers/py-brotli to also fail). Or so it seems to me.
(In reply to david from comment #9) Expected as py-brotli needs to be in sync, the attached patch fixes the build on my end at least.
The new version is on pypi, actually, just that its filename format has changed from Brotli-1.1.0.tar.gz (uppercase) to brotli-1.2.0.tar.gz. Also, setup.py had been reworked to use double quotes instead of single ones, one of the reasons that made the patch fail.
Since devel/brotli was updated to 1.2.0, there are a lot of broken ports until this is committed or the other is reverted.
Committed in https://cgit.freebsd.org/ports/commit/?id=ba641e09b817c181a7a3837a61347710eb826104
Updated to 1.2.0 in ports ba641e09b817c181a7a3837a61347710eb826104.